Some basic questions

[Christoph Hart]

addNoteOn is more specialised, but internally they are the same.

[Levitanus]

agggr, I can't get it....
I have pretty simple on my taste task - take the attack sample (~0.7 sec), and sustain momentary, but sustain at -120dB then on last 0.3 sec of attack fade sus to 0dB. But it seems to me that callbacks on one event are executed consecutive, including to onNoteOff my wait function from onNoteOo, which using the timer callback.
I feel that it's not working like kontakt, and there should be way to implement such a thing, but any other thoughts bring me to the table envelopes with per-note changing the attack time and moving points (for avoide stretch of the fade area itself withtin changing attack time), that seems to me too complicated and unrelieble (more than, I can't get how to edit points on the specific attack table) :)
I feel myself so stupid....

[Levitanus]

function onNoteOn()
{
	note = Message.getNoteNumber();
	velocity = Message.getVelocity();
	
	//if (lastnote = 0){
		//Globals.attack = 1;
		//Globals.sus = 1;
	//}else {
	
	//};
	Message.ignoreEvent(true);
	wait.start = 1;
	wait.ms = 10;
	Synth.startTimer(0.004);
}
function onTimer()
{
	if (wait.ms != 0){
		if (wait.start == 1){
			wait.start = 0;
		}
		if (wait.ms == 1){
			Synth.playNote(note, velocity);
		}
		wait.ms -= 1;
	};
};

P.S. It's just debugging code for understanding how things are working, but even here I'm confused)))

P.P.S.

take the attack sample (~0.7 sec), and sustain momentary

Why this way? From my experience momentary taking two samples produces less bugs and less code, than moving sustain noteOn in time

[Levitanus]

Well, Now I'm almost sure about logic and syntax, but while loop terminates.

var wait = 0;
const var timer = Engine.createTimerObject();


timer.callback = function()
{	
	wait = wait - 1;
	if (wait == 0){
		timer.stopTimer;
	}
};

function onNoteOn()
{
	note = Message.getNoteNumber();
	velocity = Message.getVelocity();
	Message.ignoreEvent(true);
	wait = 2;
	timer.startTimer(150); // in milliseconds
	while (wait > 0){
		
	}
	Synth.playNote(note, velocity);
}

[d.healey]

I'm still not really sure what the purpose of this is but this should help:

<?xml version="1.0" encoding="UTF-8"?>

<Processor Type="SynthChain" ID="Master Chain" Bypassed="0" Gain="1" Balance="0"
           VoiceLimit="128" KillFadeTime="20" IconColour="0" packageName=""
           views="32.rk1bzA.....B.........LUYtQFL..+O..........." currentView="-1">
  <EditorStates BodyShown="0" Visible="1" Solo="0" Folded="0"/>
  <ChildProcessors>
    <Processor Type="MidiProcessorChain" ID="Midi Processor" Bypassed="0">
      <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
      <ChildProcessors/>
    </Processor>
    <Processor Type="ModulatorChain" ID="GainModulation" Bypassed="0" Intensity="1">
      <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
      <ChildProcessors/>
    </Processor>
    <Processor Type="ModulatorChain" ID="PitchModulation" Bypassed="1" Intensity="0">
      <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
      <ChildProcessors/>
    </Processor>
    <Processor Type="EffectChain" ID="FX" Bypassed="0">
      <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
      <ChildProcessors/>
    </Processor>
    <Processor Type="SineSynth" ID="Sine Wave Generator" Bypassed="0" Gain="0.25"
               Balance="0" VoiceLimit="128" KillFadeTime="20" IconColour="0"
               OctaveTranspose="0" SemiTones="0" UseFreqRatio="0" CoarseFreqRatio="1"
               FineFreqRatio="0" SaturationAmount="0">
      <EditorStates BodyShown="1" Visible="1" Solo="0" GainModulationShown="1"/>
      <ChildProcessors>
        <Processor Type="MidiProcessorChain" ID="Midi Processor" Bypassed="0">
          <EditorStates BodyShown="1" Visible="1" Solo="0" Folded="0"/>
          <ChildProcessors>
            <Processor Type="ScriptProcessor" ID="Time Delay" Bypassed="0" Script="reg id;&#13;&#10;reg note;&#13;&#10;reg velo;&#13;&#10;&#13;&#10;reg waitTime = 0.5; //ms&#13;&#10;reg timePassed;function onNoteOn()&#10;{&#13;&#10;&#9;Message.ignoreEvent(true);&#13;&#10;&#9;&#10;&#9;note = Message.getNoteNumber();&#13;&#10;&#9;velo = Message.getVelocity();&#13;&#10;&#9;&#13;&#10;&#9;timePassed = 0;&#13;&#10;&#9;Synth.startTimer(0.05);&#10;}&#10;function onNoteOff()&#10;{&#13;&#10;&#9;Synth.noteOffByEventId(id);&#10;}&#10;function onController()&#10;{&#10;&#9;&#10;}&#10;function onTimer()&#10;{&#13;&#10;&#9;timePassed = timePassed + 0.05;&#10;&#9;&#13;&#10;&#9;if (timePassed &gt;= waitTime)&#13;&#10;&#9;{&#13;&#10;&#9;&#9;id = Synth.playNote(note, velo);&#13;&#10;&#9;&#9;Synth.stopTimer();&#10;&#9;}&#9;&#10;}&#10;function onControl(number, value)&#10;{&#10;&#9;&#10;}&#10;">
              <EditorStates BodyShown="1" Visible="1" Solo="0" contentShown="1" onInitOpen="0"
                            onNoteOnOpen="0" onNoteOffOpen="0" onControllerOpen="0" onTimerOpen="1"
                            onControlOpen="0"/>
              <ChildProcessors/>
              <Content/>
            </Processor>
          </ChildProcessors>
        </Processor>
        <Processor Type="ModulatorChain" ID="GainModulation" Bypassed="0" Intensity="1">
          <EditorStates BodyShown="1" Visible="0" Solo="0"/>
          <ChildProcessors>
            <Processor Type="SimpleEnvelope" ID="DefaultEnvelope" Bypassed="0" Intensity="1"
                       Attack="5" Release="10" LinearMode="1">
              <EditorStates BodyShown="1" Visible="1" Solo="0"/>
              <ChildProcessors>
                <Processor Type="ModulatorChain" ID="Attack Time Modulation" Bypassed="0"
                           Intensity="1">
                  <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
                  <ChildProcessors/>
                </Processor>
              </ChildProcessors>
            </Processor>
          </ChildProcessors>
        </Processor>
        <Processor Type="ModulatorChain" ID="PitchModulation" Bypassed="0" Intensity="0">
          <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
          <ChildProcessors/>
        </Processor>
        <Processor Type="EffectChain" ID="FX" Bypassed="0">
          <EditorStates BodyShown="1" Visible="0" Solo="0" Folded="1"/>
          <ChildProcessors/>
        </Processor>
      </ChildProcessors>
      <RoutingMatrix NumSourceChannels="2" Channel0="0" Send0="-1" Channel1="1" Send1="-1"/>
    </Processor>
  </ChildProcessors>
  <RoutingMatrix NumSourceChannels="2" Channel0="0" Send0="-1" Channel1="1" Send1="-1"/>
  <macro_controls>
    <macro name="Macro 1" value="0" midi_cc="-1"/>
    <macro name="Macro 2" value="0" midi_cc="-1"/>
    <macro name="Macro 3" value="0" midi_cc="-1"/>
    <macro name="Macro 4" value="0" midi_cc="-1"/>
    <macro name="Macro 5" value="0" midi_cc="-1"/>
    <macro name="Macro 6" value="0" midi_cc="-1"/>
    <macro name="Macro 7" value="0" midi_cc="-1"/>
    <macro name="Macro 8" value="0" midi_cc="-1"/>
  </macro_controls>
  <MidiAutomation/>
</Processor>

[Levitanus]

Thank You! I assume this code, thank God, something like this have worked, but are you using timer for stopping callback for a while?
This is the main purpose of wait))
For continue executing callback after "wait" function. Many of concepts in my head are still connected with time

[d.healey]

The timer goes around and around once started, I'm just counting how much time has passed and performing an action after a time limit has reached, once that happens I'm stopping the timer. Can't you use an envelope for playing attack samples?

[Levitanus]

Can't you use an envelope for playing attack samples?

Afraid, not. Or i have to have 3 envelopes, 0.7 sec for mixing with attack, 0,5 with gliss, 0.3 with leg
And Every time i want to change the main mixing properties should be edited three times...
Or i have poor logic)

in KSP I would make something like this:

on init
  declare constant $attack_time := 700000
  declare constant $leg_time := 300000
  declare constant $gliss_time := 500000
  declare constant $fade_time := 100000
end on
on note
  if (<first note trigger>)
    <attack groups allowing>
    $attack_id :=    play_note ()
    <sus groups allowing>
    $new_id := play_note()
    change_vol($new_id,0) {if i not mistake}
    wait ($attack_time - $fade_time)
    change_vol ($new_id, <0dB lvl>)
    fade_out ($attack_id,$fade_time,1)
    fade_in ($new_id,$fade_time)
  end if
{+some other stuff is not included
The same with leg and gliss}
end on

[d.healey]

I think you could do it with a table envelope. Or use 3 samplers

[Levitanus]

Or use 3 samplers

for sustain? The better to ave 3 envelopes, i think, but the problem of wasting time is here...

[d.healey]

It really depends on how you're laying out other things like RRs and Dynamics but I see no reason why you could have 4 samplers (3 was a typo), one for attacks, one for sustains, one for legatos, and one for gliss. They could each have their own envelopes. Or you can one sampler with 3 envelopes and change the attack/release time on the fly.

[Levitanus]

I have dedicated samplers for every phase. But The point is I need different attack delay (not attack time) on sustain depends on attack, leg, or gliss triggering.
And it's quite simple example... May be i'm trying to make things too complicated...

[d.healey]

What do you mean by attack delay? - I think I'm not understanding correctly

[Levitanus]

look. If I use delay event function with 200 ms delay, and take a note shorter than 200 ms, i'll get stucking note, because note off came earlier than note has started.
Even this code doesn't works in this case

var exit = 0;
function onNoteOn()
{
	exit = 0;
	if (exit == 0){
	Message.delayEvent(Engine.getSamplesForMilliSeconds(200));
	}
}
function onNoteOff()
{
	exit = 1;
}

And such problems will be worse with midi-routing instead of global events. So the better practise on my taste is take everything we need at one moment, just "mute" some things for a while. Than fade in. But if these notes are off yet they would not fade in because of they are not already exists) Simple, transparent logic. But in this case on every mixing event we need fade_in delay. It can be produced by the table envelope. But for several different mixing types we need different delay with the same fade_in (attack) time.
So just one envelope with changing attack time will not work both for 300ms and for 700ms, attack (fade_in) time will be very different in this case.
And it's just note events. More complicated logic - more request for exact timing...

[Levitanus]

well. lets try to understand how the timer works.
There's audio thread,which is executed one time per sample, timer function (callback) gets worldclock, or samples from start and is called every amount of samples. If i not mistake...
I don't think KSP behind logic works different. Just need to understand how does it came back to the callback.
I was thinking of null while loop, but it's terminated by too many iterations, i think...
Maybe there's a little bit more elegant solution? I really afraid of making garbage from the timer callback... especcially if some unpredictable usage will be produced

[Levitanus]

AAAA) getUptime!
I was confused by the "seconds" word in the API, but it uses ms

[d.healey]

Yeah that confused me too :)

[Levitanus]

emmm.... The same problem with while loop. Even don't know who could expect)))
Well, it seems, the unique timer is the best solution at the moment)

[Christoph Hart]

A key difference to KSP is that there is no wait() instruction. Instead you delay events using Message.delayEvent(). The problem with stuck notes can be solved by delaying the note off command with the same amount (it's hardly noticeable on note off commands).

1. Don't use the Engine.createTimerObject() for audio stuff. This is running in the GUI thread and has absolutely no predictability or accuracy.

2. There are scripting callbacks for adding volume fades. Check out Synth.addVolumeFade().

3. the onTimer callback runs in the audio thread and has sample accuracy.

Thanks for the hint, I'll fix the getUptime doc in the API...

[Levitanus]

Ok, I think, the last question in this direction))
How about JUCE API? Can it work inside the script processor?