Skrylar

Skrylar

Windows 7, Reaper 5.40 r584a8e, HISE VST 0.983, all 64-bit.

Reproduce: Put HISE on a track. Load a preset in to HISE. Save the project and close it. Re-open the project in reaper.

Alternatively, save the preset with Reaper's preset tool. Then switch back to "default," and finally to the newly created preset.

Result: Crash to desktop.

Expectation: Project should load, and also load the preset HISE was given at the time.

Recording of the bug: https://vid.me/1I2g

Skrylar

@Christoph-Hart I didn't know there was built-in support for sustains when I wrote that.

UX Sidebar: I expected there not to be one, since the program didn't show me that one existed. So I looked under the "hard-coded scripts" where things like note transposing is, and thought sustain control would be there. Since there A) exists such a thing as hard-coded scripts and curve editors and B) it didn't include sustain, I naturally assumed it wouldn't do it.

I don't know how well the "if it's not visible, it isn't happening" assumption holds for users of samplers. The UI probably ought to hint that a sustain pedal is built in to the sampler (discoverability.)

Skrylar

It turns that CC in to a poor man's sustain pedal, which is "held" when a CC value of 64-127 is given (high) and "released" when it is 0-63. It's just more forgiving than checking that the CC is exactly 127 or not.

Skrylar

I wrote this when testing out the Salamander and Ivy sample sets. Doesn't track which notes were on and properly release them, it just shunts all notes off when the given CC is released.

Globals.sustain = false;

function onNoteOn()
{
	
}

function onNoteOff()
{
	if (Globals.sustain) {
		Message.ignoreEvent(true);
	}
}

function onController()
{
	Console.print(Message.getControllerNumber());
	if (Message.getControllerNumber() == 64) {
		var newSustain = Message.getControllerValue() > 63;
		
		if (newSustain != Globals.sustain) {
			if (newSustain == false) {
				Engine.allNotesOff();
			}
		}
		
		Globals.sustain = newSustain;
	}
}

function onTimer()
{
	
}

function onControl(number, value)
{
	
}

Probably good enough to be an example of using the scripting system, if nothing else.

Skrylar