Hard Coded String Literals
-
Hard-Coded string literals bad. Please move to file. I can help.
-
I wouldn‘t put this too high on my priority list but if you are motivated to do this I can think of a system and then just give you the instructions on doing so, then you can grep the codebases for literals and move them to the centralized location.
I‘ll try to factor in the support for translations so that we don‘t have to change this again if we want to support this at some point (but that might be a bit too much work for now)
-
@Christoph-Hart For translations I've been using Crowdin for my app. For me it was quite simple, just one json file per locale with the English strings alongside their translated version. Probably a more robust method is to use a fixed ID rather than a string, but my app is very simple compared to something like HISE so not much of an issue - https://github.com/davidhealey/waistline/tree/master/www/assets/locales
-
@Christoph-Hart Sure, I'm motivated. Cheers.
