addPitchFade() bug?

[d.healey]

@ulrik I have the delay set to 7092

[ulrik]

@d-healey said in addPitchFade() bug?:

@ulrik I have the delay set to 7092

and all pressed notes were affected? Wow, why does it not work for me, strange

[ulrik]

@d-healey which commit are you on?
I'm on latest develop commit

[d.healey]

@ulrik Yeah

[ulrik]

@d-healey said in addPitchFade() bug?:

@ulrik Yeah

same?

[Lindon]

@ulrik not working -in the same way yours isnt - here - so add the delay - set a pitch fade, hold down two notes, press play - only the first note is re-pitched...

[ulrik]

@Lindon Thank you for confirming! Which commit are you on?

[Lindon]

@ulrik oh its quite old - I await teh filter display fix before I can move to anything recent.

[Lindon]

@ulrik ok so the culprit is this:

id = Synth.addNoteOn(1, n, 60, d*count);

the pitchfade apparently doesnt happen until the note is playing...and as you are delaying the onset of the note - its not playing so its not happening..

if you replace that line with this:

id = Synth.addNoteOn(1, n, 60,0);

it works as it should

[ulrik]

@Lindon unfortunately yes, it would be great to assign the pitch fade to the event before it happens and it will remember that when fired
@Christoph-Hart would it be possible?

[ulrik]

@ulrik in other words

we have the opportunity to set NoteOn and NoteOff delayed

local id = Synth.addNoteOn(1, n, 60, amount of delay in samples);
Synth.noteOffDelayedByEventId(id, amount of delay in samples);

Could we have
Synth.addDelayedPitchFade(id, fade time, pitch, fine pitch, amount of delay in samples)

or is it possible to achieve this, if so, how?

[d.healey]

@ulrik said in addPitchFade() bug?:

or is it possible to achieve this, if so, how?

Why not use a timer?

[ulrik]

@d-healey yes that is possible but I think it would be more accurate to work with sample delays as in above examples

[ulrik]

@d-healey I still don't understand how you could make my example work with the delayed NoteOns, can you explain?

[d.healey]

@ulrik I didn't change anything, other than the pitch knob's value. I'll make a video and you can tell me if I'm doing something wrong or misunderstanding.

[ulrik]

@d-healey and you had the DelayKnb set to a value as well?

[d.healey]

@ulrik Exactly as your snippet

[d.healey]

Ah I just tested again, you're right, it's only shifting the first note.

[ulrik]

@d-healey thank you for checking again!

[ulrik]

@d-healey as you said, I used a timer for the pitch fade part of the strumming

STRUMMING WITH PITCHFADE

HiseSnippet 1495.3oc2X0saaTDEd13rUwtzJJpB0KWEwEaprRsKkBRUP2DGmJqV2XkMMPEBUlr6w1CY8Lalc1zXPUpWxU7xvcbKu.7nz2.3Lytd85TmhqEEQYUTTlYN+7c9cNS5IEAPRhPRrpdv3XfX8A19i4pgsFRYbRmcHVWwNDhnicfSAthr83XZRBDRrrp7.MIVUWkX9d082lFQ4AvzsHjCEr.3QrQL0zc648PVTztzP3.1nRTeGuNABdKQjHEgSE6FjXZvwzAvioZxVwlXco1gLkP5qnJHgXs51hvw9CEOmmQ+grD1QQfdQShOJnrs2UDEpQrdWRqgrnvdSL6DBwxt2TmPkLmv0s6xBYE6O0Y7glCblxQY+g0JyBuJy.ulkgWiRvaNPxpDjVMCRWy1OPxhUSOQimKa2gq.YeJ51KCkLZIq7KqZ2RfTvUaNhdLrqDWTvg6cazntC9qMtWsZnqOQ4bJU5riNb+P9QNeoyDdG.pVhQwBNtvc8IDrNx2T15wTAC0Q02DqkIRyN9IgANGCiSBQ+Dx229c2q1jkaJgDPdJ31TCQMgrvjbZpcqaUMVmWl.mjBXZWMFOhwAm9o7.ESvcD7d349vIaq3ZzHEQtASfRcDyQovF09oZUY8cbyWUEWVEUxlAQ.U5hZsZ0HQ.MxID06DCWaTGpYHif9BoiK2gwKrCTPFIkyafHkqP9KrKFODNau9tbC+4TwzpvT7sIML7wBErG2sYcGtNFU2I7lFwjwQFYbMM86afEDt8315RzNgtrv5NMan+xnVaPwoICwCx1H9HcombyDEUpL+oaWJJPIkO.bayGfNRsQ1EKTY9.FjCS1ESroihifD2B6HB3CTCuY3F0ctciI5rwFFk7hZ3OunHyJWknIlK9.IfkIlM26ne.BTZmYsBjAY3pEMJ5HrMf6jvpqIjYb4nCC84nwoc2ENthTrB2P8YxMKE7p6XbP0ppFxRPmgHNyWfa9BMXtfb3hrp02Piy7bqBjNm7NTXkRKyCsFCoKVKis31jMfKjfI.5pjXpHhqB2rI1MgRDLZA73zQGogpFq0bNuz62OS7kpjFIvBoEUH43NRenVNm63b2zbNYRgF2H4xUYZBwtYy1hz9haQVtCdPVfnDgBdGNSsWLvun95j7nG1NsRNpv+RYZld07loampTBNgEpu2aZTiXPc46wHWjD7iXgfzHgZ1S5ObN9W627VD9upc4zzyig07HOoyNTEUe8PtoglaLHULsmzZG3T7t1rKKphPI4XLe1X64YtDq0VLq+rBs5AdimBgm58bVnZXwFu7Pug.avvR2s+UdrjthQn1nRjSqUTvY3wWxt2i15oZuXAVpsH9wRH46KiDBYVjfmddjzwKIsee1YZ44jj03hLhNUh+7u6knfXe1OBkGhYDKLLB5IRX5L5oT+qdKF5OWTbp9d4Iu0VPY3RbeafK4FEluMZ9XQvqOQANKiHLMhplc.G8Tc4GnkX4oJzSNvQMMtLB9GapmEEhWKyCOeLtxbvHVw7t.i4yJdE6186iWeMEfqZu627tYvvxp+pYp+x193sola+LJ+iMqc9Z5ofyC.NH0Nulug41+iEct83Edt88BTn5O.mlHIVjLif8gQrCvhnjxa9jDbxT3j80Qyx62RPky8nWc+cQibt73SUoRSZwVizyKMSZPk2z6GZtjueX0+y89g2CJ1m4INUmfQeltOca9oPDdylAieDdaPeZZjZxtylK2UvEwCEbVP4.89fRxFL.jkw9bMnsTJblso6bcu8Abz+xIseh2ivjMpD8SvR5KZ9V+bu4FutgcFbczEfNu+1jtx+uaRuuHUw3CvWTIMW.iSY6i8FC.T6bNDom60ZEc+sr0MzqyZNxCMK9S7K+vl50V4G1bxg+qniQz.o3YAYStpySWyrCZ2by+Qlp1c0qcZ95yKiikvdVPvrh50X71KKie5xx3cVVF+rkkw6trL94KKieweOi5Kg1JUIFkUZRHc60171BKq1bJlkapHH+Ew5WhH.