Mono Sampler

Casmat

@d-healey just implemented it and I am shook, the script is perrrrrrfecttt for my use case and feels amazing! Man, I need your hiseing skills!

Casmat

@d-healey Bug! I found this weird thing that happens with the mono script. You have to turn the glide time knob above 0 (try putting at 0.01) then hold down two notes, while holding two notes down, press another note and let go, then press another note and a weird pitch effect occurs. Tried fixing it, but I couldnt find a way to fix it.. here’s a video showing that pitch effect: monoissue.mp4

d.healey

@Casmat I don't know what I'm looking for in your video. Make a simple example with a sinewave generator, post the snippet and give me the steps to reproduce the issue (or a MIDI file).

Casmat

@d-healey Hold down two notes at the same time, lets say C and E. Then while holding those two down, hold another key, lets say G, and then let go of G, but not C and E. Then Repress G and there should be a pitch difference in the note

Edit: oops forgot snippet

HiseSnippet 2534.3oc0YztaaibjzwLHlW50bWuCsn+ZSPwA4q5bjby4jbAswxRT1DQeAQY6jeTbXE4Joslhq.4R6ndv.4G8wnEs+sOEsnOA8Qn8dB5aP5LK0GjxxNxt2k1JjH3c146Y1YmYUqPgKKJRDpouQmwiXZ520vYbfbP4ATdflcEM8OznNMRxBIIf1a7HZTDySSW+V6i.z2XcM0m+0y2i5SCbYyAoocjf6xpwGxkyg1Z2Wv88qR8Xc3CSg8i101UDTV3KhA84VFEzFQcOg1m0fhnslgl9ss73RQnijJYQ.N6I7F6LPbVPB9Gwi3c8Y3hhZN.iR.qUd.22q0TaMRSS2n0bK+VIV9mXTm6wmAetG3dpMHyoHsOPesqRkJdMTo0RoRqmnRejgiaHejb9Nn97AF1AP.oGEb0oUkDb0z+qFkE.BAxsFROgUMDVLifb6TnPdB70lOqWbfqjKBHhfFBIqYPtMM+FyMLO2jr3V85sz8PwDJ78YgKcaL5FdUDlKHdXWVXdxoT+X1LDAyOqO81qlO0MwpSgnHvNfKaNhMYcUguG5qv+9hQ.sItM3uNztBURgfh9DX.diXgRNpN5UXmBY0IgnMLpvhNQJFovc3HQ.xA86JmjSkDTp5KnRdP+NbPs4fF7CMRCpn1qSenY7rEu4jcOi6IG.Ir5ubMMsALd+ARbk2b8MQQLMdAabWAMzSqa+oGh131ddduE4DWxFNG5ae6a+oYgt8DvJjkrWKmi7T0R4RV6Wqa7MlDxC.ocLpZO3qHEezVExivpviF4SG2zUROk0PEbgs6Q8iXp8qINCHC.8T0xC3IqJt8iUqKGGIEC2OjNZ.2MJCkUX8nw9xRiFwngXQFXWYXbxl64C0I.V0FbnBXiBasySUedxSJ73mV3wEUX0QzuuOqtvikgy3Ya3rdP.yGUEErCiXGwbgLvT5xLoAaV0mJcji8WfSsrlFBVDNjIGJmKksmB2JvKkr2w7bn53JVE3GMA575REWV0f0dxcMd3ma1Y.iT2tCoFj3FDwH4fEaZZVVLZbHlRQ9a+Yx1EJ93732OQ88Swu2tf56hpu2lTgdJ2ib.i5yFaZ1hENjGEgmo4QjArPV2wj9P3Qx7xS5ExXDQOh6.ZXeVdhTPnAiIvwnHrHPWITeEx+MoDWPKPLkC.1zCNOPxIA88aeyu2QzSdFMj8su4OrohCdfnI7.Bt+zMImwkCDwRyPVjLjqJxjGPx0O1CDvzsI930PTUIHjbkcGgLMFBTJkHu4PgGu237DnxEpyih65yiFjm3wQV2MVB.iPfJ2Xdvh7dnHjDw78QN.0G.CwLs1ovAkxHzaImX+J4d1.wvrVBZ+wgAfHYdln4JHQBkD+MP9HRChdOnlq3LzzfRdPkRvhh9JSULl1UbJSYKIg0.gDT0DU.8tilGxlrUz.Jn6cYSbXfbA2KMk4DhhORBQUN36GIBUxKIdMW02Bj+AVDmlU6bbo1VDaGRq1MOxthUELPVxAf.Qw7jis6bPyC6P.rZWpQmWQZVkTpwqHuvtQk7DqW1pskiiYy1D65spYaAvraTt1gUrarOYOftFMgrXaH8EXbmlDTnSXkskCxr5VsKe.rrzd10r67p7lUs6z.3IoJvzRjVkZ2wt7g0J0lz5v1sZ5XAhuBv1F1Mp1FjhUcqFc1BjJ.iXcDrf3bPoZ0T1WoCAsuMHm1jxMa8p116ePGxAMqUwB.tmEnYk1qlUhn.ipbsR10ySpTpdo8sTT0D3RaSDsDsib7AVHHTdkf+UticyFnYTtYiNsgk4AqrcmYjdrsiUdRo11NnCoZ6l0yahtSfhlJl.z0vJgKnqljIp.nfqOzwZFCIUrJUC3kCRbZj2x7yeHVgHoUhHlTUtO2NeIz6PZvGntSJmBLbDrOwG5WDaaf7KIeQwmo.ExfSO86CcQNGF6TfA1dOaFMchw5A.FE.F8vGt+g1lP9cjDZOHjzUUZC1bpjodd6EKkhfbOHor2CxSJV.+OpGyITBcgjkrWDH5l6AX2IHI6.zfjf3glSaZPeVNUYOrUoBaUnHxvk2sDA9v6Qxc+D0aq9L4QXuL41bS0dIXLEq4NFzKr4r8liE9Ik6qNTWG5+EYKBI4F0bf5jF+I9wTnis8UBNl1i6BGYSi+4y9KFb6zkn.npp7FysFxuhTf7Ye1LYc+rFvE4A9Yp5v6GHBYVHo4vaQ27YKh4EHUMCBFqZwktCvQExMQz4IKnZ4Sm67yuLW1WL0qpB1jk74B5PlTxqkLxFeNOazJsee49Mz+m0QOweDjzK9disR1cJVKjPboVz0IS4hZd5yvK2RuNYtI79bneeyKYZiU+r0kmnYZdoNULc9RzR774TaY4mRQtkDS3QPOeUfINxMy+rY5CFKFduVY1SJMcE4kEV1tShAyTnEwYwpwKOhuPl5xMjUNkbdtGHQxRE44YiV2OQBXrIdXKn2NnwVvWGkayUnxYVy5xcZSSCmZvKOOIEf3.OVOd.yawjvU1ejwSX9Nz8ko2Kdn480X3FeWMF9UM5s9ZSzJ.0jYn+vIC5jbauZ546XjbkulRiSO5r1kQsiO2iEpn91Fp2cJMs69O+s+tmeyl5esTS8u96VieMN7tYxP9I+gVJFX9tTZE4+oojiTGgygh6is0nMj644yZIhTSEj5w49KCoyeigc+i6FE2qG+0pWUCl3ZHNcyH6gPwPM8O1.FwElzRMwMI5DdflOO3DlWGgB+kLh58Lf4pigohy9tY3CDNYCTaROdJ9hTAfVNN8CHdMdLsBW4iospp3GYnJCubcbskniXB52C53jmf7GXX0qGLn2bEbcipu7l9diqt3+zDw+AFGSOkoJjoD9mpV2SDNjrOKfEh9thWwK.+2W0W.dzJ+BvIOkTmPZPzHQDqXZNuvdamduJLYbPVzS.kAKz7pBlWZ71cJvTXdmcaQCxvLXcFNUmm5E79GO2JfBAAGFNedyHWvXQeWFFDC21nlnpXZBmCd6zfOfF5AwE2LIh2Jalv5qV44rmISg+RdR5a+80qju9pk09Ndu1+2uNjtdqK7KrbOCG9vQ9LqfSY9v8KJc7iMl7BmSgl8bVcQfXz.Q.OSFP6o8wkV2WpAURJotmLGxmraalOiFk5r2Oa2ZPaMzP7ARug9hhqtu3phW+DiD0kfEGH+mD2dullck2kbqU5tjuy02a98JumOgB0O++mH8O1.pouMQEtI+2Od2VDi+PR0oP0.r+PXbIG3BTW1jeZAr0c80vFMSVWXZqiNr.O0B728YxlEw05S1r3zMeuHigT2PwW6lz.OVv3NJHfcGn9Af2vnNtlTbZq6FFE1p.1xK+qccwb5u.7OKmlsuAz7KtAz7na.Me4MflctAz73a.MO4JoAuwuTrTLLI+G.zxRMBktdRGPpiBZ+aPUbLSM

d.healey

@Casmat Ha that's weird. The solution is simple, don't hold down two notes, in a mono script, use one note only :)

The glide works by pitch shifting the first note of the glide, the second note is never actually played. So if you glide between C and E, what you are hearing is the C being triggered and retuned up to E. The E itself never plays, so when you then press G it is still retuning the original C but now up to the G, and when you release the G it's going to go back down to the C.

You should increase the glide time and you will hear what is going on more clearly.

With the time set to 0.01, if you press C and E you will only hear one of those note, but that means the first note that was triggered is the other one and it's been retuned to the one that you hear. For example if you hear the C, that means it was the E that was triggered and has been retuned to the C. When you increase the glide time you will hear this.

So now it should make more sense. We are hearing the C at first but actually that's the E tuned down. When we play the G that is the E tuned up, when we release the G it goes back to the original note (E).

Now why it then jumps up to the B when you press G again I don't know, but it's related to the fact you're hold down a 3rd between the C and the E and it gets added to the G for some reason. You can test this by hold B instead of C and indeed it will increase by a 4th on top of the G.

Casmat

@d-healey ahh, that makes sense! thing is, It had been stumbled upon when playing notes fast, so if im understanding correctly, this is a problem with the pitch fade function itself, right?

d.healey

@Casmat

this is a problem with the pitch fade function itself, right?

No it's a user issue :) one note only.

Casmat

@d-healey aye-aye!

Casmat

@d-healey hey again! I noticed another thing which I was wondering how to implement, when the glide time is set to anything above 0, when you hold on one note, let’s say C, then press E while holding C, then release E, it causes the note to go back to the C and retrigger it, causing a trill like effect. However when you set the glide time to 0, causing retrigger mode, the same doesn’t happen, and instead holding the C, then pressing E while holding C, then letting go of E while holding C causes E to continue playing, what modifications to the script should I make to get that effect?

d.healey

@Casmat Have you tried using the hardcoded legato script that comes with HISE? That might do what you need without using my mono script.

Casmat

@d-healey not yet.. where can I find that?

Casmat

@d-healey just found it!

Casmat

@d-healey hm, this legato script in hise seems to continue playing notes even when I let them go, if I tap a note, it just plays on even when let go. And having a glide time setting is something I wanted, which the script in hise doesn’t have, or am I missing something, I can’t find any parameters for it

d.healey

@Casmat If the note continues playing that makes me think you have a long release time or the sampler is in one shot mode. The legato script doesn't have a glide setting, and as you've found, the one in my script needs some work for real-world use.

Casmat

@d-healey Woohoo!! After some long fought trial and error, I got the retriggering working for when the glide time is below zero:

/*
The MIT License (MIT)

Copyright © 2017, 2018, 2019, 2020, 2021, 2022 David Healey

Permission is hereby granted, free of charge, to any person obtaining
a copy of this file (the “Software”), to deal in the Software without
restriction, including without limitation the rights to use, copy,
modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished
to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

Content.setWidth(650);
Content.setHeight(50);

reg lastNote = -1;
reg retrigger = -1;
reg eventId;
reg lastTuning = 0;
reg vel;
reg retriggerHold;

//GUI
const var bypass = Content.addButton("Bypass", 10, 10);

const var time = Content.addKnob("Time", 160, 0);
time.setRange(0, 2000, 0.01);
function onNoteOn()
{
	vel = Message.getVelocity();
	
    if (!bypass.getValue())
    {
        if (lastNote == -1)
        {
            lastNote = Message.getNoteNumber();
            eventId = Message.makeArtificial();
        }
        else
        {
            if (time.getValue() > 0 && eventId != -1)
            {
                Message.ignoreEvent(true);                
                Synth.addPitchFade(eventId, time.getValue(), lastTuning + Message.getNoteNumber()-lastNote, 0);                    
                lastTuning = lastTuning + Message.getNoteNumber()-lastNote;
            }
            else
            {
                if (eventId != -1) Synth.noteOffByEventId(eventId);
                    
                eventId = Message.makeArtificial();
            }
            retrigger = lastNote;
            lastNote = Message.getNoteNumber();
        }
    }
}
function onNoteOff()
{
    if (!bypass.getValue())
    {
        Message.ignoreEvent(true);

        if (eventId != -1 && Message.getNoteNumber() == lastNote)
        {
          if (Synth.isKeyDown(retrigger))
          {
              if(time.getValue() == 0)
              {
	              Synth.noteOffByEventId(eventId);
	              Synth.addNoteOn(1, retrigger, vel, 0);
	              lastTuning = 0;
	              retriggerHold = retrigger;
	              lastNote = retrigger;
	              retrigger = -2;
			  }
			  else
			  {
	              Synth.addPitchFade(eventId, time.getValue(), 0, 0);
	              lastTuning = 0;
	              lastNote = retrigger;
	              retrigger = -1;
              };
          }
          else
          {
              Synth.noteOffByEventId(eventId);
              if (retrigger == -2)
              {
              	Synth.addNoteOff(1, retriggerHold, 0);
              }
              eventId = -1; 
          }
        }

        if (!Synth.getNumPressedKeys())
        {
            lastNote = -1;
            lastTuning = 0;
        }
    }
    else if (eventId != -1 && eventId != undefined)
    {
        Synth.noteOffByEventId(eventId);
        eventId = -1;
        lastNote = -1;
        lastTuning = 0;
    }
}

function onController()
{
	
}
 function onTimer()
{
	
}
 function onControl(number, value)
{
	
}

I definitely feel like I overcomplicated things and is not the most efficient way haha

If the note continues playing that makes me think you have a long release time or the sampler is in one shot mode.

Yup, the oneshot mode was the problem, the script still is very buggy and needs work as the retrig pitch shifts an octave lower and whatnot

Casmat

@d-healey scratch that, the retrig thing only works for “one pass through” if you continue “trilling” and let go of all the notes, the retrigger note still continues playing even when no notes are pressed. I had only accounted for one pass through. I was thinking I could make the retrigger note into an eventId, but I couldn’t find a way to do that from the addnoteon function. Is there a way to detect an anchor note (retrigger note) and then play that note when all others are let go except the original retrigger note?

Thanks!

d.healey

@Casmat If you're not using the glide feature just use the hardcoded legato effect (if you turn off one shot mode).

Casmat

This post is deleted!

Casmat

@d-healey That's the thing I think I may have to build something from scratch since I'm actually thinking of using a legato that uses the samples position and transfer that position into the samples that are being glided to.

Mono Sampler

35

1.9k

10.6k

92.7k