How could this possibly be?

[gorangrooves]

So, I recompiled my plugins using the latest HISE build, changing only the version number.

8/15 newly-compiled plugins have my variable hi-hats not making any sound. The HISE projects show everything perfectly and in working order.
All 15 plugins utilize the same system. 7 work, 8 don't. Those 8 all have the same issue: 2 notes for variable hats (G0 and A0) are not producing any sound. No errors in HISE. All 15 worked in the previous version.

How could this be?

[gorangrooves]

@Christoph-Hart This has to be a bug.

I cleaned up the compilation directories. Recompiled. I cleaned up again, and tried compiling directly from HISE (not using Projucer and opening up VS2017), but the issue is still there.

Standalone, VST, and AAX- all have the same problem. My project code is identical to what it was when I compiled it previously. The main difference is the underlying HISE code.

I spent most of last week compiling and re-packaging 15 instruments (VST, VST3, AAX, Standalone, PC, Mac), which turned out to have been a waste. I don't know if I feel like puking or crying.

[d.healey]

@gorangrooves

I spent most of last week compiling and re-packaging 15 instruments

You should set up a script to automate this for you.

[Dan Korneff]

@d-healey

:beaming_face_with_smiling_eyes: :beaming_face_with_smiling_eyes: :beaming_face_with_smiling_eyes: :beaming_face_with_smiling_eyes:

[gorangrooves]

@d-healey Direct HISE export doesn't allow me to set vst3 instrument category, doesn't do both vst2 and vst3 at the same time, and is missing developer email, all of which i set in Projucer.
Otherwise, I would do it.
Still, it wouldn't fix the issue of not compiling my plugins properly. The only reason for recompiling was to remove an FL Studio bug Christoph fixed in the source code, only to introduce something worse.

[d.healey]

@gorangrooves

Direct HISE export doesn't allow me to set vst3 instrument category, doesn't do both vst2 and vst3 at the same time, and is missing developer email, all of which i set in Projucer.

You should be able to do this with a script using a text replacement command like sed. A little complicated, but you only need to do it once.

Still, it wouldn't fix the issue of not compiling my plugins properly.

I don't really have a solution because I'm not sure what the cause is. Did you try recompiling one of the ones that didn't work with the old version of the code again to double check?

[Christoph Hart]

that didn't work with the old version of the code again to double check?

This. If something broke in a recent commit please go back in the commit history and check where it broke. I'm suspecting one of these buddies:

- fix multichannel issue introduced with previous commits · christophhart/HISE@d151991

The open source framework for sample based instruments - - fix multichannel issue introduced with previous commits · christophhart/HISE@d151991

GitHub (github.com)

- fix channel resizing in HISE · christophhart/HISE@813c0a7

The open source framework for sample based instruments - - fix channel resizing in HISE · christophhart/HISE@813c0a7

GitHub (github.com)

[gorangrooves]

@Christoph-Hart I will try commits before the two you pointed to.

Remember that my previous working version was with November 2022 HISE compiling. So, there have been a ton of updates since, and trying one by one is going to suck a lot of my time. Also, I have to make sure it includes the FL Studio fix, which is the main reason for recompiling the plugins.

Hopefully, I'll be able to narrow it down with a couple of compiles

I'll report back.

[d.healey]

@gorangrooves said in How could this possibly be?:

@Christoph-Hart I will try commits before the two you pointed to.

Remember that my previous working version was with November 2022 HISE compiling. So, there have been a ton of updates since, and trying one by one is going to suck a lot of my time. Also, I have to make sure it includes the FL Studio fix, which is the main reason for recompiling the plugins.

Hopefully, I'll be able to narrow it down with a couple of compiles

I'll report back.

Don't try one by one. Try one somewhere between the one that worked and the one that doesn't, if it still doesn't work do the same again. Repeat until you find one that works, then try one by one from there until you find the broken commit. And use got, don't download the zips. Also you don't need to rebuild HISE each time if the problem is only in your compiled project.

[gorangrooves]

@d-healey Thank you. Yes, good point that I don't have to rebuild HISE! That will save me time. I was thinking of the same strategy rather than one by one.

You mentioned I should use "got". What is that?

[d.healey]

@gorangrooves That is my phone auto-correcting. Should be git.

[gorangrooves]

@d-healey I know it sounds silly, but I don't know how to do it. I'll see if it takes me longer to set that up and learn or just download zips...

[d.healey]

@gorangrooves git checkout #hash that's the only command you need once you're setup. Or you can use a GUI.

[gorangrooves]

@d-healey Thanks very much. I'll check it out!

[Christoph Hart]

Yeah use a GUI client for git then its as easy as double clicking the commit and rebuild HISE.

Check around the commits I mentioned above.

[gorangrooves]

@Christoph-Hart I will do that. Thank you!

[gorangrooves]

@Christoph-Hart Bingo! You were correct: the first of the two commits broke my poor innocent plugins.

- fix multichannel issue introduced with previous commits · christophhart/HISE@d151991

The open source framework for sample based instruments - - fix multichannel issue introduced with previous commits · christophhart/HISE@d151991

GitHub (github.com)

Please let me know if you need anything else from me to help you squash the bug.

Thank you!

[d.healey]

@gorangrooves Can you make a minimal snippet that has the issue?

[gorangrooves]

@d-healey I don't think so. It is only the compiled plugin that has an issue. The plugin is quite complex, and without the samples, you can't tell that it is not working. Everything looks fine; it just doesn't play two notes.

[Christoph Hart]

@gorangrooves yeah, I either need a minimal example or you need to send me one of your projects. I keep looking at this commit but I can't see anything that would cause this issue, so I need to debug it.