Hise crashes when Sampler goes below C-2
-
@DanSound Oh that's caused because the sample is being stretched too far. Try remapping the sample lower and see if the problem goes away (this is a test, not a fix)
-
@d-healey Just tried - I set the lowest sample root note to C-2 but the issue is still there.
-
@DanSound Doesn't crash here with my samples. What sample rate are yours? Have you tried converting them to a monolith. Is it just one particular sample that triggers the issue or all of them?
-
@d-healey Most of the samples are 44,100 Hz, 24 Bit, Mono, PCM, some sample maps use 96,000 Hz samples. But this happens with all of them.
-
@DanSound What happens if you map a single sample to middle C and don't stretch it? Also are you using the develop branch?
-
@d-healey With just one note it works fine with any Transposer value. I think it crashes when I go to a non-existing octave below C-2.
I'm using develop branch, but to the freshest one, v2.1.0
-
@DanSound Now map that sample to the lowest note in the mapping window and test.
-
@d-healey Tried that and Hise crashed.
And for the first test, I did it wrong, I only played with Transposer.
So when I set just one sample to C3 and then press C-2 and set Transposer lower than -4 Hise crashes. -
@DanSound I think you need to post a simple project that demonstrates the issue because I'm unable to recreate it here with my samples.
-
@d-healey Will do that in few minutes. If I do it with the mouse like you, then it works fine, but when I press the lowest key on the midi keyboard it crashes.
-
@DanSound What about the HISE virtual keyboard (top right) ?
-
@d-healey I rarely use it and I don't know how to switch octaves, it's always plays higher ranges.
Here is the project. NoteRangeTest.zip
-
@d-healey If you mean to test it with the mouse then yes, it crashes Hise.
-
@DanSound There's almost certainly a way to make my MIDI keyboard play a lower octave, but I don't know what that is :p
Does it happen when you play any notes other than C-2?
-
@d-healey Well, when I set to -5 then only C-2 crashes Hise, C#-2 and above - all good.
But when I set -6, then it starts crashing on C-2 and C#-2
aaaaand if it's -7, then it starts crashing from D-2. Like there is some dependency
-
BTW I switched to MBP and the issue is still there. Midi keyboard is the same.
-
@DanSound said in Hise crashes when Sampler goes below C-2:
@Lindon This seems like the solution https://forum.hise.audio/topic/1035/ignore-note-range/2?_=1676312033909
But it doesn't fix the problem. Or there is another way to fix that?
Where did you place this script?
-
@d-healey it's on top, after the Interface script. And Transposer is on Sampler level.
-
Ok, after shifting the octave of my keyboard I was able to recreate the issue. And yeah it's weird, it doesn't happen on 24 but it does happen on 5 for example. I don't think it's as simple as it's trying to trigger a non-existing octave, otherwise the crash would happen at 24 as well.
@Christoph-Hart I think you should take a look at this.
@DanSound Do you need the user be able to transpose that low?
-
@d-healey oh, so it's not just me :) Thank you for taking time to figure out this issue.
I don't think the user will go that low, but it possible that someone accidentally find this bug (like I did) and will be annoyed by ruined session.
