Hise crashes when Sampler goes below C-2
-
@d-healey Here is the snippet. It works fine with Sine generator, the problem is with Sampler.
When I set Sampler's Transposer to -5 or below and press C-2 key on midi keyboard Hise crashes.
I also noticed that when Transposer is set to -1, -2, -3 or -4 there are no crashes, only at -5 or below.
And also from -24 to -13 there are also no crashes. The range -5 to - 14 makes Hise crash. Kinda weird, maybe there is something with my midi keyboard.My samplemap looks like this if this if this helps
HiseSnippet 1417.3oc4X8taaaCDmxNrKwMsXsqCXeY.BA6CN.YA1IsIEHaqN+sKnwIF1oY6aALRz1DQlTfhJ0Ys80XOG6QnOR8MX6n9iEkqbqqQaWWm9fg3c73869Cu6jaIENzf.gDYsvoW6SQVKh6bMW0e29DFGc3dHquEqnAJatPQskDdOpsK0Csy09jf.pKxxp7i0a0Zg4PQOu9Q6P7HbGZFID5LAygdDa.SkQsUimv77Nf3ROkMvX22uwgNB9tBOQH.qx3ZHehykjdziI5sUBirtw9tLkP1QQ.rgrlaGg60c5KdFOd+mwBXW3Q0Kpi5.GTL4CDdtZDqoh1sOyysUp4GfPV3VYNixwNi6gaxbYinm4T95HF1YRX5OrJkGdkyAu5lvqlA7J.RkLfzbwP5N3NNRluJiiFO2DeHWQkcIfa2DJw6EY8J7tBXCb0pCHWROPBKFIP0MpUaEa3mk2paH2QwDbaA+XHdeBu5xUddkEp7xJ1iypa2B4oUiT34QkExVGokuMAqxCGbAUth8UDuP5nMBledeJdx9TyPtSrUarQA+PNSchOkOoDAThqBd6oGtGQQf.gUBMXe9Tohogf0dzqfr53vxB38nAWpD9Pd8TFy9lDpYYQ0KJ1UZqxXvLfqfWQj1WxunIia+y1owShq6S3hKptTLmkVwFBlPnrR75UCnp15asUAx0WaS3mb7ptjhNTARszQhmYqirKA7qjWgjgSRgjgfn0efgJICmrJi4koxek0qeQ57BEuM0iRBn406NgJkfWcoL9vordsH0.mPF47p4Dtc51mXJNqqc0lPP.JyrZOpRy53nLwpKa+SIdcMiyzok.sW7B6Is8eIwmYr8kqXCOOO5W8Spnrdbgjt+Uf8UUIg78sh1xKgT9IceSCTCCcx53SgEkWiSgkEacEXieQU2vpbBpf2TQU.tcxc8NdLWpDwfK3yiiiAnHDa1rDM0RSFNlzu57FST53aOQRuHNKEp.8OKk8z17.eAW6.r9p2sUODhEVZkcc5KAJpeG1ePMGkX.XgF1l9FMxpBNsVk1UM0JENpHk9myjRuIdT0pbZEOcN4HMuhUhlWDN43icQbV0ohZc.CZHbC8Hp7SenG4JgAbMHWaCcecd.ScsoI8AajjoEh2A2hob5WLFKU.F0S67Q.iICxcK79c6RcTY.bN7A+9Gmo1LU+2Gq96h6njTx.FuWGx.enJWDFpfSVU+Cw7z9S87zsjTOAwMed+qZrSH3ij4o9WMhT01CDg7b5JA4so9ThBByFxLei1serTD5OtTu9QQIEmJg44AWgIiS3TvWqLswckhfftf4DcVAlrZEJ6o8UYTZSuhJCxSC5eAwaNm5oK7aouu+z.pN9xbZRTR1PycGokZmRhhwvGYDst9XqWar0qO156O15GL15MFa8lYqicnMI9wyFt8wae9YGdxQae9S9s8dXsZ0diVY2X5ZkAmXKB3CL14NrdizVLk2wmFciO+9zHq2rPzhXHyhG3KBRtecKCB4uhMh93onuWkgp+AoT4+hUyy4EWHEicX5bi84WAUI.JZLdWnOeWRnmJkZd2YSAW32WvYN4uSB2w50iJMwdgFz1JETRHix8Zj1RbDoenwQLNkHyWp48xWT+8Nipv302gigqstLq8+c6BW9+McgeatnamzC1FznT8YXLbQbTmBaci8OkvqsHTAMoSaThgtocfIHbnl8TKo6SGutV5H0cnb2nE+M7jvrdZCXMy5oLQNoGEXOIuG8kGVkobciwngE8fV6dlonAvbJZHAMM+jfxADGo3bm3OqRi04in.njG8ORt.todsc8zOkBiqsZMz.nM34NN5j7eD5pVrLqMCxr9LHy8mAYdvLHyFyfLaNCx7v2pL5IP1NTIFDWzCHzZ+3DKq8GkXUF8O.5iEMf. -
@DanSound Oh that's caused because the sample is being stretched too far. Try remapping the sample lower and see if the problem goes away (this is a test, not a fix)
-
@d-healey Just tried - I set the lowest sample root note to C-2 but the issue is still there.
-
@DanSound Doesn't crash here with my samples. What sample rate are yours? Have you tried converting them to a monolith. Is it just one particular sample that triggers the issue or all of them?
-
@d-healey Most of the samples are 44,100 Hz, 24 Bit, Mono, PCM, some sample maps use 96,000 Hz samples. But this happens with all of them.
-
@DanSound What happens if you map a single sample to middle C and don't stretch it? Also are you using the develop branch?
-
@d-healey With just one note it works fine with any Transposer value. I think it crashes when I go to a non-existing octave below C-2.
I'm using develop branch, but to the freshest one, v2.1.0
-
@DanSound Now map that sample to the lowest note in the mapping window and test.
-
@d-healey Tried that and Hise crashed.
And for the first test, I did it wrong, I only played with Transposer.
So when I set just one sample to C3 and then press C-2 and set Transposer lower than -4 Hise crashes. -
@DanSound I think you need to post a simple project that demonstrates the issue because I'm unable to recreate it here with my samples.
-
@d-healey Will do that in few minutes. If I do it with the mouse like you, then it works fine, but when I press the lowest key on the midi keyboard it crashes.
-
@DanSound What about the HISE virtual keyboard (top right) ?
-
@d-healey I rarely use it and I don't know how to switch octaves, it's always plays higher ranges.
Here is the project. NoteRangeTest.zip
-
@d-healey If you mean to test it with the mouse then yes, it crashes Hise.
-
@DanSound There's almost certainly a way to make my MIDI keyboard play a lower octave, but I don't know what that is :p
Does it happen when you play any notes other than C-2?
-
@d-healey Well, when I set to -5 then only C-2 crashes Hise, C#-2 and above - all good.
But when I set -6, then it starts crashing on C-2 and C#-2
aaaaand if it's -7, then it starts crashing from D-2. Like there is some dependency
-
BTW I switched to MBP and the issue is still there. Midi keyboard is the same.
-
@DanSound said in Hise crashes when Sampler goes below C-2:
@Lindon This seems like the solution https://forum.hise.audio/topic/1035/ignore-note-range/2?_=1676312033909
But it doesn't fix the problem. Or there is another way to fix that?
Where did you place this script?
-
@d-healey it's on top, after the Interface script. And Transposer is on Sampler level.
-
Ok, after shifting the octave of my keyboard I was able to recreate the issue. And yeah it's weird, it doesn't happen on 24 but it does happen on 5 for example. I don't think it's as simple as it's trying to trigger a non-existing octave, otherwise the crash would happen at 24 as well.
@Christoph-Hart I think you should take a look at this.
@DanSound Do you need the user be able to transpose that low?
