Look & Feel - ComboBox Background.

[David Healey]

@ILIAM said in Look & Feel - ComboBox Background.:

Did you Guys Changed the Source code?

Yes you'll need to wait for Christoph to merge it, use one of our forks, or make your own fork and pull in the PRs.

[ILIAM]

@David-Healey said in Look & Feel - ComboBox Background.:

wait for Christoph to merge it, use one of our forks, or make your own fork and pull in the PRs.

Great!
Can you point me to the Code you guys changed?
I want to stay with my Current Version of Hise for now

[David Healey]

@ILIAM Check these two PRs from @dannytaurus

https://github.com/christophhart/HISE/pull/805
https://github.com/christophhart/HISE/pull/806

[David Healey]

@dannytaurus Do you think the same trick would work with alert windows?

[dannytaurus]

@David-Healey Yeah, can't see why not!

I've never used an AlertWindow. Do you have a small snippet?

[David Healey]

@dannytaurus Here ya go

HiseSnippet 1027.3ocsVstaZbDEdVr2zBsMpQpO.S3WqqPD1XarsrppuRJpFGTvMs+KZXlyBS8vLnYm01nJK0Gs9+9xz2f1yr6ZC9hbRPpH.y457MemKq6aMbHM0XIA0Na1TfD70gClociObLSpIcOhD77vdrTGXoEpNX1TVZJHHAAq7FuhfpqRxe8O+3ALESyg4pHj2ajb3D4Doat1968yRkpCS.mImrf2arWWtQenQYxP7rRXKxTF+b1H3Tl2sJgjehkNlD78gayGJZuifs0v1sGtULWrSRq3cX.Lb8M2dcXSdadbRaVKRvyNVHcF6.GyAoXROvHlMXr4RcwA7dYpbnB7BwjA3IWnlb3XoRz+FxIkPBVs+bpZkBp56B6IExa0Omx91bCz4QrHoET4ofT7mAjBV.RqV.oWDNfakScys3wyWE1UiUvDFVaVDJE9Rp72UBOzfdncMmvNG5XQgaiHpcqVMn3WqsasZX8I0QUrD5OPOVORpglbKfWj2nLCYphDdhwb99ZQG.TQ9fd0qdIceEXczKkZg4xZX7MsvHouspSll6jFcTcgkcYta+ZtW0aPStw1nFTyveesZ+QspWvrTFd5nbSFdz6ViRo3mpiZlBthlmnVWkjrd75udiMVa2BaIXG26LYZAHdGvcL8HEDwZPecqbOPeteNJ9SZyKGKcvMoo.ixQZPbFbkKxiBmzofFTFdkDYbPDE2ZsFz5bjNQM0wPu1yB0jZExW2donF8AYNmQG64dqQEwMSlZzXXMnWvTYP98UlPidYoX0pVvkY0X1pVx9oXiSOrRiSIGXtJp9YdvfTW8yFKSo3aFE6xbnF+E8ZLxapzi72zxCLpdITpuVACjCnCYJ0PbBL59HEyzB2hSMN3s5nbzV65Zz6aJI4QsUlKrf+nl8qFrOUfQ5rICA6hbk2QbT3tyWO6Sa9hWPKK3nQ2UKcucJTJ2wnD94F+ue3zHojWwe8KcOh4X9AzRcneSw9ZoGNAGAWfqDKFWqFdDjdtyLM22xhAI3Kb4Ved4vbA4SjBe.kUBxU2t27OOeuY2J7Wp8jo8LSv7vrn5fJflgWW+BoS.lU6m6SYW.c08s.Vq8xjGtHAWgYDYJl6t607a7KMfEi6rLwuvPmJcyV7IBeFK6Z8jK69Tg3KB6Kc7wONFq7HXDKS+efwxGQ7MgGmjf6alCvUC67aK6yC9HGOteyI0i5wbVI1dDdZ1jA3JLNfmtVCJL4gAU7spExs7xdFX.nE4B+K9pzXrWNnzX7MFISXbq4C7hQP+Cg9xbMHlz4OjtJ9eKfxzXR9X4h77DrE7Cb9cS0CB70KafqurAtwxF3lKafsW1.2ZYCb6Odf9MD6m4LSJFaHjd8ONeOVPvw4qPx6VI+Gsp645A

[dannytaurus]

@David-Healey Cheers. I'll have a look in the morning. Just fixing some minor niggles with the MIDI Learn Panel at the moment.

[dannytaurus]

@David-Healey said in Look & Feel - ComboBox Background.:

@dannytaurus Here ya go

Hmm.. what am I doing wrong? Loaded your snippet using the latest develop commit 3c36e36c.

[David Healey]

@dannytaurus Ah you haven't got the rectangle class enabled I'm guessing, so a.reduced won't work. Just change it to a

[dannytaurus]

@David-Healey I'm confused.

Your code creates LAF for drawAlertWindow but the button callback calls Engine.showMessageBox() which I thought was a different thing.

[David Healey]

@dannytaurus drawAlertWindow applies to message boxes and lots of other little popups.

[dannytaurus]

@David-Healey said in Look & Feel - ComboBox Background.:

@dannytaurus Ah you haven't got the rectangle class enabled I'm guessing, so a.reduced won't work. Just change it to a

I get the same thing after changing a.reduced(10) to a

[dannytaurus]

@David-Healey said in Look & Feel - ComboBox Background.:

@dannytaurus drawAlertWindow applies to message boxes and lots of other little popups.

Oh, cool. Good to know. Well I'm still not seeing the LAF unfortunately.

[David Healey]

@dannytaurus Probably because it's global laf. Once you get an error with it you have to restart HISE, reload the snippet, don't click compile until you've changed that bit of code :)

[dannytaurus]

@David-Healey said in Look & Feel - ComboBox Background.:

@dannytaurus Probably because it's global laf. Once you get an error with it you have to restart HISE, reload the snippet, don't click compile until you've changed that bit of code :)

Aha! Now I see it! OK... on to fixing the bug

[David Healey]

@dannytaurus Also you should add this to the HISE juicer for future compiles HISE_USE_SCRIPT_RECTANGLE_OBJECT=1 then things like obj.area will return a rectangle object - it's backwards compatible so won't break previous projects.

[dannytaurus]

@David-Healey OK, I recompiled with Rectangle support and I'm on latest commit on the develop branch, but I still don't see the black corners.

[David Healey]

@dannytaurus Are you using your fork or Christoph's?

[dannytaurus]

@David-Healey It's my fork but my develop branch is identical to Christoph's.

dan ~/code/HISE@develop: 🔥 git diff develop hise/develop 
dan ~/code/HISE@develop: 🔥 

I keep all my own customisations on a separate branch:

dan ~/code/HISE@develop: 🔥 git diff meatbeats hise/develop --name-only
.github/workflows/build_installer.yml
.github/workflows/build_mac.yml
.github/workflows/ci_mac.yml
.gitignore
MEATBEATS.md
hi_backend/backend/BackendApplicationCommands.cpp
hi_backend/backend/BackendApplicationCommands.h
hi_core/hi_components/audio_components/EqComponent.cpp
hi_core/hi_components/floating_layout/FrontendPanelTypes.cpp
hi_core/hi_components/floating_layout/FrontendPanelTypes.h
hi_core/hi_components/keyboard/CustomKeyboard.cpp
hi_core/hi_components/keyboard/CustomKeyboard.h
hi_core/hi_core/Popup.cpp
hi_core/hi_core/Popup.h
hi_core/hi_modules/synthesisers/synths/SineSynth.cpp
hi_core/hi_modules/synthesisers/synths/SineSynth.h
hi_core/hi_modules/synthesisers/synths/WaveSynth.cpp
hi_core/hi_modules/synthesisers/synths/WaveSynth.h
hi_scripting/scripting/api/ScriptingGraphics.cpp
hi_tools/mcl_editor/code_editor/FullEditor.cpp
hi_tools/mcl_editor/code_editor/FullEditor.hpp
hi_tools/mcl_editor/code_editor/TextEditor.cpp
hi_tools/mcl_editor/code_editor/TextEditor.hpp
tools/auto_build/build_mac.sh
dan ~/code/HISE@develop: 🔥 

[David Healey]

@dannytaurus which OS?