[bug] Encrypted expansions magically turning into file based

[d.healey]

I've had this happen a few times and unfortunately haven't been able to recreate it reliably yet, but I wondered if anyone else has had this or if @Christoph-Hart knows what could cause it?

I've seen it with both hxi and hxp.

[d.healey]

I've managed to capture the transformation in action :)

It occurs when deleting the expansion's files while HISE (or the plugin) is running. In a real world scenario this happens when the user clicks my uninstall expansion button.

If the expansion folder is left behind (which I do when the user wants to preserve their presets after uninstallation) then an expansion_info.xml file is generated automatically when HISE is closed.

The next time HISE is opened it auto-creates the folder structure for a file based expansion and this causes mucho problemo!

Here's a video showing it happening in realtime.

https://filedn.eu/larUQgXOwVjQdvpPaD96lHH/encrypted expansion to file based.mp4

[Christoph Hart]

@d-healey nice catch. I think the solution is to set a flag whenever you call the uninstall function and then check in the Expansion‘s destructor whether that flag was set and skip the Expansion xml file creation.

[Christoph Hart]

How do you uninstall the expansions?

[d.healey]

@Christoph-Hart https://github.com/davidhealey/HiseDownloadManagerToolkit/blob/master/Expansions.js#L372

[Christoph Hart]

@d-healey Ah OK, so inside Expansion.unloadExpansion() would be the most reasonable place to set this flag, right?

[d.healey]

@Christoph-Hart Sounds reasonable to me

[d.healey]

Is there ever a reason to create the expansion xml automatically in the destructor?

[d.healey]

Ok I added the flag and it works! But I realised there is another scenario we haven't considered.

What about when the user has HISE running and then goes into their OS file browser and deletes the expansion files. The xml will still be recreated by the destructor.

[d.healey]

@Christoph-Hart Any suggestions?

[Christoph Hart]

I think it should be safe to assume that if the directory doesn't exist, it shouldn't write that data to the file so this would handle this case too.

[d.healey]

@Christoph-Hart The problem is that if the directory does exist but the content is removed (as in my video) the files are recreated.

We need to make sure the files are never recreated by the compiled project I think, unless you know a reason why they should be.

I guess it would also be good to also not create the files if the directory exists but is empty, that would prevent it happening when running in HISE.

[d.healey]

I think I've found a suitable solution, can you see any issues with it?

~Expansion()
{
    if (root.isDirectory() && root.getNumberOfChildFiles(File::TypesOfFileToFind::findFiles, "expansion_info.xml") > 0)
        saveExpansionInfoFile();
}

[d.healey]

@Christoph-Hart This solution good for a pull request?

[Christoph Hart]

Instead of

root.getNumberOfChildFiles(File::TypesOfFileToFind::findFiles, "expansion_info.xml") > 0

you can just write

root.getChildFile("expansion_info.xml").existsAsFile()

this will prevent iterating over the entire directory with the same outcome.

[d.healey]

@Christoph-Hart Ah nice, ok. I'll make that change and create a pull request. Thanks for your help!