Utter Confusion (LinkWindows)

[iamlamprey]

Starting a new topic since the other was technically about convolution.

Mr Healey has discovered an issue with my install process for expansions: the LinkWindows file is being generated in the root directory of the APPDATA folder, not in the APPDATA/Expansions/NAME/Samples folder.

The strange thing, is my pre-develop versions do the exact same thing (they don't put the LinkWindows file in the right subfolder), but the samples load just fine.

Obviously this has confused my brain quite a bit:

Moving the LinkWindows file into the Expansions/NAME/Samples folder makes the develop version work. So I could probably resolve it with some File writing shenanigans, but if someone else has a suggestion I'm all ears...

Set Samples Folder button is the HISE default Custom Settings tile.

Code:

inline function onButton_InstallLibraryControl(component, value)
{
    if (value)
    {         
        FileSystem.browse(installDirectory, false, "", function(result) 
        {
            hr = result;
            expHandler.installExpansionFromPackage(hr,FileSystem.getFolder(FileSystem.Samples));
            expHandler.refreshExpansions(); 
            installDirectory = result.getParentDirectory();
        });
    };
};

Content.getComponent("Button_InstallLibrary").setControlCallback(onButton_InstallLibraryControl);

[d.healey]

@iamlamprey Does it work if you uncheck Link expansions to project in your project's preferences?

[iamlamprey]

@d-healey Nope, it says it doesn't affect distribution either

I'm going to fresh install the latest commit and delete all my HISE appdata stuff and see if that does anything

[iamlamprey]

Okay that didn't work, still just creates a single LinkWindows file in the APPDATA root folder for NEAT Player, not one for each expansion in the Samples subfolder

[d.healey]

@iamlamprey I can confirm this issue. Installing an expansion from your demo project (the one you originally posted on github) places the LinkWindows file in the wrong place. Either there is a bug in your installation code or there is a bug in HISE.

[iamlamprey]

@d-healey so back to github?

The installation code is just installExpansionFromPackage and it works in the old one, it also installs all the other expansion stuff like images/presets without any issues.

I'm going to work on a dirty fix using the file system, I'll also browse the commits and see if anything with the LinkWindows changed between master and develop, but if @Christoph-Hart could take a look when he gets a chance I'd be appreciative

[d.healey]

@iamlamprey I'm trying to debug this issue now. One thing I'm seeing is that it's placing the link file inside the Samples folder of the expansion inside the HISE project instead of the appData location. Are you seeing this also?

Here's a minimal example (based on your example). If this is failing for you as well then I think we can call it confirmed and open an issue.

I've had a look at the code but I can't figure out the source of the issues. It's like it's reading the expansions folder inside the project folder as the install location - regardless of the state of the Link Expansions to Project preference.

expansionInstallTest.zip

[iamlamprey]

@d-healey Mine installed the LinkWindows into the proper location:

I suppose it's my installation process then... not sure what it's doing on your end either lol

[d.healey]

@iamlamprey said in Utter Confusion (LinkWindows):

@d-healey Mine installed the LinkWindows into the proper location:

Oh well nothing to worry about then

By the way I'd recommend not using the hr system at all and rolling your own installer using zip files.

This has the advantage that if you want to deliver an update in the future containing additional samples you don't have to also ship all the previous samples too.

[iamlamprey]

@d-healey So how would that work?

Innosetup script to put the .ch1 files somewhere, then automatically make the linkwindows stuff?

If i can't get the hr1 stuff to work I'll probably move over to installers

[d.healey]

@iamlamprey

Innosetup script

No it's all done through HISE using the zip extraction functions (video on Patreon )

[iamlamprey]

@d-healey Even if I don't use it I'll grab a month since you helped me so much with this

Would you mind if I used the method in your snippet for installing HR1s in NEAT Player? Since it seems to work and my current one doesnt

[d.healey]

@iamlamprey Of course I don't mind, I have no secrets from you

[DanH]

@d-healey Just checked my project and I can't find a link to the expansion samples anywhere. However the expansion is working fine.

[d.healey]

@DanH said in Utter Confusion (LinkWindows):

@d-healey Just checked my project and I can't find a link to the expansion samples anywhere. However the expansion is working fine.

It will be in appData

[DanH]

@d-healey I have the normal linkWindows file in there for the plugin's stock samples, but no other link files for the expansion

[d.healey]

@DanH What about in your project's expansions folder?

[DanH]

@d-healey nada.

[iamlamprey]

Had one user message me saying the latest version I just pushed doesn't output audio, but the linkwindows files are all in the right spot, and all pointing correctly to the samples folder... and all other things are (seemingly) working properly, pretty confusing stuff

[d.healey]

@iamlamprey Could be a DAW config issue. Do you have a standalone version they can try?