confusing convolution

[d.healey]

@iamlamprey said in confusing convolution:

@d-healey Sorry, any newer* commit

Yeah that sounds similar to the issue I'm having.

[A Former User]

Yep confirmed it with a barebones version:

1. Convolution works fine without an expansion loaded.
2. After installing & loading an expansion, it keeps the IR loaded (still works).
3. If you try to select a new IR, the convolution stops (I assume because it's looking in the wrong folder).
4. If you go back to no expansion loaded, it works again and you can switch files all you want.

@Christoph-Hart could you please take a look at this when you get the chance? I think something's wrong with the {PROJECT_FOLDER} wildcard or something :)

[A Former User]

bump, could we please get some acknowledgement that something's up with expansions? seen several threads about it now and this is the last thing i need working before i can push my mac release

[A Former User]

bump, officially reached 1 month of my convolution not being usable

[Christoph Hart]

It's fixed now, it was indeed looking in the audio files folder of the expansion.

[d.healey]

@christoph-hart Does this solve the includes issue with full expansions?

[Christoph Hart]

@d-healey I don't think so but if you can make a minimal example, I'll take a look (not sure if you did that already).

[d.healey]

@christoph-hart said in confusing convolution:

not sure if you did that already

Me neither :) but I shall whip one up very soon.

[d.healey]

@Christoph-Hart Here's the full expansion project and also the test expansion with the included scripts. I notice that the scripts are inlined when the expansion is loaded. I'm not sure if the issue is caused when the hxi is generated or when the expansion is loaded.

I also noticed the using Engine.loadFontAs("{PROJECT_FOLDER}FontName.ttf", "pretty-name"); causes issue too because once the expansion loads it's still looking in the PROJECT_FOLDER instead of the expansion folder. Even if I include the font in the shell's images folder it won't work. I assume the best way to handle this would be to have the hxi exporter replace PROJECT_FOLDER with EXP::EXPNAME ? That way it would work while developing the expansion but also work when loaded as an expansion...

I haven't tested but I think this would affect anything that's using PROJECT_FOLDER paths, like additional source code, sample maps, and images.

Test Exp1.zip
Full Expansion Test.zip

[Christoph Hart]

@d-healey Oh wow, that might be the commit with the weirdest looking fix in the history of HISE...

- fix scripts in subfolders not being included when exporting a full … · christophhart/HISE@2bdd95a

The open source framework for sample based instruments - - fix scripts in subfolders not being included when exporting a full … · christophhart/HISE@2bdd95a

GitHub (github.com)

Like you see the code change and immediately know, "yeah, that makes total sense".

[d.healey]

@christoph-hart Haha, you gotta love regex :D

Thanks, I'll give it a try this evening.

[A Former User]

@christoph-hart Thank you

[A Former User]

@Christoph-Hart im still getting this problem when using the later commits:

Same expansions from my current working version, same code too.

I'm thinking the problem might be similar? Expansion Wildcards doing some strange stuff? If I remove {EXP::Blackout} it removes the overlay, but obviously the samples aren't loaded. I feel like it might be looking in the appdata folder, not where the Samples are installed to.

const var expHandler = Engine.createExpansionHandler();

var currentExpansion; 

const var expansionNames = [];

expansionNames.push("No Expansion");

for (e in expHandler.getExpansionList())
    expansionNames.push(e.getProperties().Name);

for (i=1; i<expansionNames.length; i++)
{
    expButton[i].data.expansionName = expansionNames[i];
    expButton[i].set("allowCallbacks", "Clicks & Hover");
    
    expButton[i].setLoadingCallback(function(isPreloading)
    {
        if(isPreloading)
        {       
            this.data.preload = true;
        }
        else
        {       
            this.data.preload = false;
        }
    });      
    
    expButton[i].setMouseCallback(function(event)
    {
        if (event.clicked)
        {
            //Here we add the safety check.
            
            if (this.data.preload == false)
            {
                expHandler.setCurrentExpansion(this.data.expansionName);   
                load+this.data.expansionName;
            }
        }
    });    
};

currentExpansion = expHandler.getCurrentExpansion();
currentExpansion = currentExpansion.Name;

var expansionDirectory = FileSystem.getFolder(FileSystem.Samples);
var selectExpansionFile = "";
reg hr;

expHandler.setAllowedExpansionTypes([expHandler.FileBased, 
                                     expHandler.Intermediate, 
                                     expHandler.Encrypted]);

//Install Single

var installDirectory = expansionDirectory;

inline function onButton_InstallLibraryControl(component, value)
{
    if (value)
    {         
        FileSystem.browse(installDirectory, false, "", function(result) 
        {
            hr = result;
            expHandler.installExpansionFromPackage(hr,FileSystem.getFolder(FileSystem.Samples));
            expHandler.refreshExpansions(); 
            installDirectory = result.getParentDirectory();
        });
    };
};

Content.getComponent("Button_InstallLibrary").setControlCallback(onButton_InstallLibraryControl);

//Blackout

inline function loadBlackout()
{
    
        //Setting Up Samplers
    clearSamplers();
    
    SamplerA.asSampler().loadSampleMap("{EXP::Blackout}Blackout_SampleMap");
};

[d.healey]

@christoph-hart That fix works beautifully!! It didn't solve the font issue though. I've attached an updated test expansion that loads a font.

Test Exp1 - Font.zip

[A Former User]

Made a minimal example to demonstrate the issue.

1. Set samples install directory.
2. Install expansion.
3. Everything installs to the right place, etc.
4. Re-open plugin and get a Sample Directory Missing error.

Project: https://drive.google.com/file/d/11dZ_MwBFkGNkfg5mK7PzoKd1cfPXU4pA/view?usp=sharing

There's a pre-compiled windows Binary, and an encoded expansion in the root folder of that

is anyone else getting this issue with the more recent commits?

[A Former User]

bump (char min)

[A Former User]

still can't open my plugin on the latest updates without getting a Samples Folder Missing error.

this commit works: https://github.com/christophhart/HISE/commit/20dc01cfd48ea727a6d296615f594e262690a003

but pretty much all of the ones afterwards don't

[A Former User]

hate to be that guy but buuump :slight_smile: