Changing Hise Legato To only 2 Octaves???

[ulrik]

@natan You have to have the same if statement

if (Message.getNoteNumber() > 47 && Message.getNoteNumber() < 73)

in the Note Off callback as well, the notes are generated in there too

[ulrik]

@lalalandsynth here I deleted the panel, commented out the paint routine and mouse callback, added a knob in the legato script with exactly the same callback as the panel, and linked it to a knob in the interface

HiseSnippet 2431.3oc6Z0uaabbD+njNiP5zzl.ih9maIJJHcknHkTbbhhp021pVxVPT1o.BtAqtaIuE53tr2sTTrF5cqOB8e6aQdCZmY26SpiTLJxN.ok.Rh2ryr6LyNyuYtc0wARGVXnLvpT4SG0mYU5SsaORn71wixEVGrqUoGaeHqKUIIscB38UjgjWv65cnb3wAbY.WMh77AbxEB44VaOpOMLj4ZUpz7OGkuT4Erze9gmsM0mJbXojrrdqj6vNj2iqRod7luj66uO0kcJuWFtWayCbjhcj9xAftNucSq9TmKncYuhhrMmsUoGrmKWICZqnJVnUoE1V5Npsmbnvv+a4g7y8Y3CsrZCSjg79ReWTiwuasiG2283XeRnkUI6iS8Pya7POx9HtKOgdpm52nGfjJQV+Qo4xqdymS8ZMI0q.UpTFUZAiJ841lMmzQP84g1GHTrfNTvsmUUL7ZU5eZuiDXPnZzidAa+.3gDAp8jlMWj.+p95cFHbTbofHEuRpXuVTqdk2WobkqqPFenNcJbLbYBj99rfBGF2oCllf0DC5cNKXQxkT+ArDFAyOuO8AylO0wX0YXTJNPvUutOK54zfhVErCXE41v8hHMDXUo2I9rnch19bWVfEGljecNRsrzFQ17.q2bvtTEMd5fYFVs9r.EGMpR6xtDxSLazks2kEdgR1Wyau9RApGkd3Lu3WkMkZT1GFxcUdoD9aa5wf77LolGrYOZFws1LTw52l+OfE11tUilV83tt9rikgbb6Kaxe+Xu2AfJ8I19Z.EHCN.Rdg.Nj5mZi3IsGxUNd.LvMBwgjKo6.ePtbYbHLSz.3ZlMLGikEftLJqlLdZ3BSNjoYgnDEFPLip6maeLZdEquyUf9BgDen02HPsek8dc5vbToJ6B16+WmJB18tp7YFU4g1s4BltJjVQ9s5mIeG8RF44LAK.cpslRwl+0rVro+LWr40NJX4OMfJB6KCyMwsY83mB4ggYI9lP.Ok82OA2kyReGIMnvg9gmsOXjEJSapZPfNbYqdxABUtvi4uSE8xm0jYOrfxMK7gpB3ByFZ8sTfdlqFl.6TPov492OxF1wCUPEl.RJPDYCRbIRpq6KgdbpUMczpKRfZjPExJUh4JjkA6Fpn16uz90uJuLX0qpHdc0ugTMK3LLT4pbWjbN9KW8JfVS7Kih+RnZjudBPcRySdvWXH.Q1voAjNkRONNbynGn3juRilUtFsi.VWhGy2EqlGBV+YuacMs99zQLMUf3Re8WGwJrn7C4faaCxdhtP.bCm.Fr6dTD8ZvbFySiNPtVMPVbcpr7xkiqyGRflKc7XNWP7fJNLX59iDe4P7KntPDvxhBzkotIctvGQGRZZ.X5PMOnxZZpvW5P8I9fR1ZkuZcn2gxcjAjZBBWjZr0qTFXsrf7s.mOSysf.N3pf.WixDvfzPAwecn0iXsIVemp57BCSiqOXvUyaUa9y.eOSyagZimVaP04Xpf4SBjCTv5GBdvc1txxOtRZjjN1DRTUmX3oVrNVqqVqvH+gv5n73gM.096v9AvMP8HdYF4E5FCRF5bk.FbHYYxpQTB0Y3X3S0CogJHOoJrmf+A8EUgXpxc0gCaAQDUad0pqtu9S05Z+ANJnrF72Zl+D13beng+5IhBVg.vENApYQEc8Y0NasEIdKuBYIxJKBZyRjmtHYs2A+Xj4bFDedHDEGTSE.MQpI5FPGtKju11i5JGV6rUI+Is473Da8sXyZ0pCSMPrYiVKpGeIxSho7TXIxohKRZ0zL6fM77.pKG.F1Gi8OCL082eK8mHrCvkfz9R8GCMvFd2zLy6nNtlw2VjmcnGWkwgrkOuqf4dJ6JUMyN4YisRvzc1TUgUzpP7SOA3upC3EBXtlsXMVS9PyijCBY6P88OG7gowlrKA4t6wmUJy6PLSRCGetyEL2nTKTHcm3ffGQUdMfZ6cY0zesiuTFDI0UPb8PvLVstd2YEbVKqWovXy17VIIzc7vYxUu9WGYrOdYLGMpnhSjUdCvBoH0mD+pONwc4m8sePiJAqngOSzU4APEshrsPy5DoX.g2CNhxkcngLRyuA+pdFx.p+62HE64rwm4kZ8t5Zgdu92w3oTMt+TEaci.5d4ZHLug3tL8xt8n8P+6At0RJPjDGkpX0wrIc5T5ByLxAqsYdgJyQuWJD4iZE7dqqYpKqkJY9S1vLLEMOwrkqDGxgg905eeNTV6BCgDOYqI4IGqDTQ9NSUrav5OC9K8pe6drH1lpOSyys40VYJdsbUJKvsEWt8lL+w2wEoK2pmKguo45hXpPe20kQXjqGGuLBeHAwr.riIdzMGAcES6xzG6yVPqpc3NbpeDfIBLJvJ5wbAdKT3WoOClLnpFmBOzb7f5SN5RbVh.gVdYR+3SHz.HkAYJisjV8PiTgFejnFHFcaUigdcOsOil5T2jEh76u2b6E4H+NatMVgX8hxDfZAFCzfCjyDy.qHv9+xn6YyHh2cfZ0x.l1zSZrYrU75j08WLNtXjfbdtUx4491+umKB.oh1DRKOim+I7h.gvLUGd4hpUg2rHcz9CB8vQheSCleHyjQWrpjAlH1aTWqWENkEnq.31jNG4TXFDDZPuiCX3at+R1nvZ0gbilYZl6VvrxnNArdxKYwJzO1MVPrzMzeZ3bYgzPSXlZoByAzLZ7jjKXiRiRQGlYV13dK7OYxu0X2a170r060DZ8ZJMco8VSpIJsGJy4DfdnTuSjT2O9mYzuTPSVyZOVSrEqozbk9EhlbuRXHatSt3FgPIBuw8KH5s5oJrqpYtopI2SUVvvwP0tW.1uA3RFttApm97yz8z8ywkjYeecIY+juXrbW4yGfaEqxrsx3cZ8f3EcT1Gl7EZkd0WozF+1wFzoC+J8US2g62KTA5vA8fbFqReg8afjUWVG5.eEI7BtvxmKtf4dpTy+Guq+Z9Y6NbtkycubrN1l2quOaOwkLeXqRqieAr2nsyXp4u4lijBYeOof6jcu+DF3s51kEjU2Kzf1Rof29Ikxi17DlOil8JZ9CadHWvnAfehcG8E+3uQ9B2u9c1F0kfIyjeYbsky++lWao4Pz6dDEBTgjbanSy1xAANLPSDBn5BPqzbHjn44l3ylqKT3pe3+.ehFrE9bonAaEO3Gk0nG0IP98NFvZLV9SzT.6Vn+Gqor8Q3yjj+sErsaZtpe9263ft6k.+SwxrxcPlUuCxr1cPlu7NHyStCx7U2AYd5TkAuassFnj8Loh.gi2SWnrTo8DTHRVG0a8eAoqjo7.

[Natan]

@ulrik said in Changing Hise Legato To only 2 Octaves???:

@natan You have to have the same if statement

if (Message.getNoteNumber() > 47 && Message.getNoteNumber() < 73)

in the Note Off callback as well, the notes are generated in there too

Thank You Ulrik
Could you please Give me a Hint, I don't Have Confidence with Midi Scripts.
: thanks so Much

[lalalandsynth]

@ulrik Thanks mate !

Now it works for setting it from the front panel.

Did you try this with a sampler ?
I get hanging notes on a sampler, looking to see if there is anything else that might cause this, bit of an old project.

EDIT: Tested the sample map in a fresh project ,when I play notes with the legato script enabled, I get hanging notes , works fine for the waveform Gen.

[ulrik]

@lalalandsynth said in Changing Hise Legato To only 2 Octaves???:

@ulrik Thanks mate !

Now it works for setting it from the front panel.

Did you try this with a sampler ?
I get hanging notes on a sampler, looking to see if there is anything else that might cause this, bit of an old project.

EDIT: Tested the sample map in a fresh project ,when I play notes with the legato script enabled, I get hanging notes , works fine for the waveform Gen.

No I've not tried it with a sampler, I don't understand the difference I think it should work the same.
It's the hierarchy the same?

[ulrik]

@lalalandsynth I think I found the issue.

I had to go into the sampler settings and under "Retrigger", switch the "Kill Note" to what ever and then back to "Kill Note" again.
I don't know why I had to do that, it's like not all settings are there from the beginning and you had to confirm it by toggling the "Retrigger"

Maybe @d-healey or @Christoph-Hart or someone else, could explain that?

and also you should check that the GUI switch is connected to the "PrioSwitch" in the legato script

Anyway now it's working fine with a sampler as well

[ulrik]

@natan can you show what you've tried so far?

[lalalandsynth]

@ulrik Gamechanger ! Thanks !!!
My Logan String Melody works now !

Question 1: In some cases you would not want the retriggering to happen, I wonder if that is a sampler setting or needs any programming , i tried the playback settings and could not get it to stop the retrigger.

For example on the Logan there are 2 monophonic bass sounds.
On of them is sustained and needs the monophonic retriggering.
But one of them has a short decay and should not retrigger ( at least that is what I think for the moment , would have to go to the shop and test ) Will do that in a couple of hours.

Just thinking out loud as I can imagine that being needed for other analog emu´s.

Question 2:

When it does not play the sound the console throws up this error.
"legato:! onNoteOff() - Line 7, column 32: NoteOn with ID1280 wasn't found "
Thinking if that would cause any problems in an exported problem if its perceived as an error ?

[ulrik]

@lalalandsynth said in Changing Hise Legato To only 2 Octaves???:

When it does not play the sound the console throws up this error.
"legato:! onNoteOff() - Line 7, column 32: NoteOn with ID1280 wasn't found "

Hmm, I don't get that here, I'll investigate

[ulrik]

@lalalandsynth said in Changing Hise Legato To only 2 Octaves???:

Question 1: In some cases you would not want the retriggering to happen, I wonder if that is a sampler setting or needs any programming , i tried the playback settings and could not get it to stop the retrigger.

I think it would be scriptable, if you have a retrigger button and read its value inside all the cases in Note Off CB maybe?

like this:

case 2:
				var highest = getHighestNote();	// highest held key
				
				if (highest == playedNote || !Retrigger.getValue())
				{
					Message.ignoreEvent(true);
					break;
				}
				
				var eventId = Synth.addNoteOn(1, highest, 64, 0);
				midiList.setValue(highest, eventId);
				playedNote = highest;
				break;

[ulrik]

@lalalandsynth said in Changing Hise Legato To only 2 Octaves???:

But one of them has a short decay and should not retrigger

Could you describe how it's working, what will happen with held keys, what will happen when held keys (not sounding) is released?

[lalalandsynth]

@ulrik YEs, will give detailed explanation in a while.