HISE Logo Forum
    • Categories
    • Register
    • Login

    Preset Browser colours must be string

    Scheduled Pinned Locked Moved Bug Reports
    7 Posts 2 Posters 1.1k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey
      last edited by

      Setting the background colour or itemColour1 of the preset browser produces weird results if the colour isn't passed as a string, I think this is the only control that requires that.

      Libre Wave - Freedom respecting instruments and effects
      My Patreon - HISE tutorials
      YouTube Channel - Public HISE tutorials

      1 Reply Last reply Reply Quote 0
      • Christoph HartC
        Christoph Hart
        last edited by

        Really? I've to check that, I thought it could be fed with both.

        1 Reply Last reply Reply Quote 0
        • d.healeyD
          d.healey
          last edited by

          0_1511798943935_Screenshot from 2017-11-27 16-08-40.png

          Content.setHeight(300);
          
          const var data1 = {"Type":"PresetBrowser", "ColourData":{bgColour:0xFF000000}};
          const var p1 = Content.addFloatingTile("p1", 0, 0);
          p1.set("width", 500);
          p1.set("height", 150);
          p1.setContentData(data1);
          
          const var data2 = {"Type":"PresetBrowser", "ColourData":{bgColour:"0xFF000000"}};
          const var p2 = Content.addFloatingTile("p2", 0, 150);
          p2.set("width", 500);
          p2.set("height", 150);
          p2.setContentData(data2);
          

          Libre Wave - Freedom respecting instruments and effects
          My Patreon - HISE tutorials
          YouTube Channel - Public HISE tutorials

          1 Reply Last reply Reply Quote 0
          • Christoph HartC
            Christoph Hart
            last edited by

            The upper one is better. Case closed :)

            1 Reply Last reply Reply Quote 2
            • Christoph HartC
              Christoph Hart
              last edited by

              After a few hours of thinking about it and asking a few other people, I reconsider my opinion and decided to fix the bug:

              Link Preview Image
              - allowed FloatingTile JSON to use int values for ColourData · christophhart/HISE@18e6676

              The open source framework for sample based instruments - - allowed FloatingTile JSON to use int values for ColourData · christophhart/HISE@18e6676

              favicon

              GitHub (github.com)

              1 Reply Last reply Reply Quote 1
              • d.healeyD
                d.healey
                last edited by

                Excellent thanks. It says Linux Build is failing, so I should hold off rebuilding?

                Libre Wave - Freedom respecting instruments and effects
                My Patreon - HISE tutorials
                YouTube Channel - Public HISE tutorials

                1 Reply Last reply Reply Quote 0
                • Christoph HartC
                  Christoph Hart
                  last edited by

                  Ah, no, that lousy Travis CI build file is broken since weeks. Things should be fine there (let me know if it doesn't).

                  1 Reply Last reply Reply Quote 0
                  • First post
                    Last post

                  16

                  Online

                  1.7k

                  Users

                  11.8k

                  Topics

                  102.7k

                  Posts