CC# range in MIDI Learn menu and MIDI Learn panel not updating properly

[ustk]

Shouldn't the CC# range be 0-127 instead of 1-126?

Also, when learning a new CC# from the MIDI Learn menu command, the Midi Learn Panel adds a new entry instead of overwriting the old one.

[d.healey]

@ustk Looks like you found some bugs. 10 points!

[ustk]

@d-healey

[ustk]

@d-healey The first one is easy to fix but the other, I'll take a chance...

[ustk]

So the CC# not updating properly is too tricky for me to fix.
@Christoph-Hart any chance you take a look a this?

[Casey Kolb]

@ustk Ah yes, I should have pull requested this fix months ago. Just a tiny little array bug for CC 127.

As for the overwriting, I think HISE uses the standard MIDI Learn behavior which allows multiple assignments, either for assigning the same CC to multiple controls, or multiple CCs to a single control. This is how Kontakt does it as well.

[ustk]

@Lunacy-Audio It would be good to have a single/multiple assignment capability via a setting. But in the waiting it would be enough to fix the overwriting issue