fixed expansion hr1 archiving

[Dalart]

lol

[d.healey]

Darn it :(

[arminh]

My heart always beating faster when i see information about expansion in commits :D

[d.healey]

Is there anything stopping us from making our own expansion type system now we have the various file APIs (which I have yet to explore)? The main thing expansions solved for me was being able to change which presets showed up in the preset browser based on the selected expansion, is that possible via the new APIs?

[Casey Kolb]

@d-healey You can totally build your own preset browsers now with the new FileSystem API. I just finished building out a sub-preset loader / saver which stores the files in a different preset folder within AppData

Now that we can read / write any file and load it as an object, you can build pretty much whatever you need to from what I can tell.

[Casey Kolb]

@d-healey Though to answer your question, I think you still need to edit the C++ to change which presets are shown in the preset browser. Unless of course you just build your own preset browser.

[Christoph Hart]

Well sample maps and embedded midi files will require the „real“ expansion system, but for simple use cases like Casey described you might get somewhere.

[d.healey]

@Christoph-Hart Any ETA on fixing the proper expansion system?

[Christoph Hart]

What would actually be helpful would be a list of things that don‘t work (or what you are trying to do and what prevents you from doing so). It‘s basically finished (from the inside), but I kind of lost the overview over all use cases so this might be the most efficient way to fix all the trivial issies so you can work with it.

[d.healey]

@Christoph-Hart

These are the main issues I'm aware of:

• If you click the button to create a new expansion folder, the file browser will open to choose a destination, but then when you click save HISE will just close.
• The dropdown list of expansions in the sampler workspace is always empty (even for old projects that have expansions already).
• Engine.getExpansionList(); always returns an empty array
• I'm not sure if expansion loading is working (needs testing).

If these issues are fixed then I think we would have a usable system.

Other additions that would be nice:

• A method to extract hr files to ch from within a script so that we could implement an integrated downloader/installer.
• The settings tile has a button to change sample location, it would be good if this updated when the expansion was changed.

If anyone else knows of other expansion related issues please chime in.

[coreyu21]

@d-healey I still have the c++ saveInPreset preset issue as before. It’s really important for users when loading the plugin on a saved project in the daw. The plugin should be able to load the used expansion preset onInit so the user doesn’t have to spend amounts of time finding out what preset they used for their project.

..unless their had been a fix for this I’m unaware of. Thank you lots

[Christoph Hart]

These are the main issues I'm aware of:

Speaking of trivial issues, you haven't enabled the Expansion Support checkbox in your project's preferences in HISE :)

I changed it during the rewrite so that you don't need to recompile HISE with another flag in order to use projects with Expansions, (so the HI_ENABLE_EXPANSIONS flag isn't necessary anymore as long as you don't use any custom C++ expansions you don't need to mess with compiler flags anymore).

The default setting is "Disabled", which will be the case for projects created before this change. Just change it (restart HISE) and all the things you mentioned are working.

[d.healey]

@Christoph-Hart Well that was a sneaky thing to do :cat_face: Thank you!! Maybe replace the silent crashing with a popup message though.

[d.healey]

New issue (or maybe there is a solution already :p )

Loading an expansion used to update the preset browser with the expansion's presets but this doesn't seem to be working now.

[arminh]

@d-healey @Christoph-Hart i noticed issue on builded plugin. I copied expansions to plugin folder in AppData but they're not visible in plugin.

[Dalart]

Did anyone manage to get expansions working correctly since latest fixes ?

[d.healey]

@Dalart There hasn't been any fixes. Turns out expansions were (mostly) working all along, Christoph just hadn't told us we needed to change a setting. There are some other issues @arminh reported but there haven't been any expansion related commits since then so I assume those issues are still present.

[Dalart]

@d-healey Alrighty.