Recent commit to Processor.cpp breaking old project

[ustk]

@David-Healey @Christoph-Hart Could the fact that not having the MIDI Learn button available as parameter be related?

[David Healey]

@ustk Has MIDI learn ever been available as a parameter?

[ustk]

@David-Healey No idea, it's an absolute coincidence that I'm working on this today...

[David Healey]

@ustk I don't think MIDI learn is related to this bug

[David Healey]

Another issue I just noticed, CC mods don't work

[Christoph Hart]

@David-Healey Yes I've actually fixed that already on my local state. The metadata switched the default value parameter range from 0...127 to 0...1.

[David Healey]

Similar problem seems to be present when using Script FX in the latest version, it's unable to find the parameters in my script

HiseSnippet 1221.3ocuWssSiaDFdLjIcIaWT2p9.3xUYqVAIPHfzppMPHoMc4PZR1svUzI1iISwdFK6wa2TDR8MnW2dUeKp5c7.zmkp9Fr8eFam3.YgPDs9hnL+mO9M1sCDVzvPQ.xnPug9TjwGi6NjKGTe.gwQs1CYrL9.RnjFXFSZ2g9jvPpMxvXwuRQvXobH8y+7xcItDtEcLID5MBlEcelGSNlpesWwbcaRro8XdYjtRsVVBdcgqHBhmEwkP9DqyImQOjnDaAL5qIgCPFeA1tRUJoREaK55NzJauY+s1XisspVojcopqS2rpCozlaUwoBxHeCalTDzURjzPjQtcE1C6NP7i7XG7FVHquKUcnLpK34XxMEt1pTTQEUe.y0tcZgJDAVo83x1hwksOCe.ylMh93x2mnYXNVirEPiElL7Vbhvq7GJ7lRHYjIjxEGROE20Jf4KGyQEOOF2hCcSGBzmxFJwxhV3OLv0EfDb4pdjyoMCfCiznX0RkdtI7yydQgBPuJTZFqWyiM+RS8fypmQkMbbnVxhqDyyr4wqnjes09byWwE8Kmno9+fZotCTrtvyWvgCEWQyUom9OqFpXxkAB25DW29vbQQAWyJgrxCLtKiSMch3VRlfaNoDEsRs9yMeKwMh9rBWTXoz3W4gcjx.V+HIs3HppQ7TweQgKKjw1GJjzi3E0VA3XdcVNNSkWRz3RClJa0JQvsoXQdjWeZP1bPIHz1mbVJ+rMKYEW8yHnf2hyjG4SSNe6KCnj1mZFLIBAQk5IvkSl.65xroAHFXjOBqaIHcvmr5+8NNKeE50s1iHIolArH3EeZfjoRFi8nuE.RhGrWBuGM7bovWKaROEY7j6zouaLVyg0FN5vO+s0BkCUkl7ZAQdLaaWZaQHSU5Gqz5WA.g9cY+jNx+seU87muzKKH3IW4QdWV.vvHGGFPAiMs2E4vb8BggL+Vd.tFx3SwuNjZZScHQtRyvyASAivmSs6Iz.ddB6jD1h0m5hP2bMG.XD1QtD4jnNpA2DFpbH6ptZclC41vrX2WGJJ2Gd7ozLiTNqg6SwsYRqASOdWXJwKLl7ec7l.r+DbLZ13fMGt4w2JJ9CRnLMD8B3TboDn7Q.rSCJ23H7EMNtWiNGty9m1sdmVs6c4Es6bz2znduSadz960nykcFP7CE1rP4Z0EAz0Rs+ZG.yiLHm4bpqZTZ0e.RL7CzsUnNhHIie1ADXUPsabXjWW3ReKZhGU9xXAE3R74RpyptdWJ2Ve38vSByxpyFILKmxLCtTtY.WJudgYBXI34QWglAcg9fmPHG.Yz0LPMQMzLAJ9cLa4fq68SlIkWBm9ZWWSc3YtvTykASc46pfo5dFE.WMLsEcGPo4+62G+begRKV6gEJMQx2LkN9LbkR1dttF76ydMn.FV3HvlhMZpEgLYcseYTVCov8MkmZJByjwkh7X8qemMee7cNhpy0pF2i9scxr3DMS1CdZEusLCctw6K5b4utG4x3K0yz1Ru.81lcOYT5tHd+4bxEiaS3++.c5QrBDmZEi8ntK5QZJPzy0eI1RvmDBmMKeSHGnlwN0xZRScCEWedUbi4UwJyqhaNuJVcdUbq4UwsuaEUeK5NQRgW7aYgPGztg9JBCiF7XHI3EHP+aEpp1y

[Christoph Hart]

@David-Healey hmm, works, your snippet didn't include a network with a Gain parameter though - can you load this one?

HiseSnippet 1534.3ocuX80TabCDWmMBBNoYZloe.byzGb5jwXCDfYxzACF6T2veb4bnvST46jwpbmjm6zEvMMS62f9bdqeM5a7onO2OB4aP5Jo6ruCLDOdRiYFvRq1U+Vs69a2j1ABGZXnH.YUnyvATj0Cv1C4x906SXbTqcPVODuGITRCJZ1Z6gCHggTWjkU9Wn1vZw4P5OueysIdDtCc7VHzQBlCcWlOSNd2A0dIyyqIwk1g4m5zqVqkifWW3Ih.7jGWAMf3bN4L59D0wxgQeOIrOx5awqs9F8VsBsJwoR0UVaipqubkkojUd15qub0UVY8Uc6sV2JNarLxZ9FtLoHvVRjzPj0baKbGZ2WbA2bAGwBYc8npEUQ1vMa1tovyU4hpcQ06y7bam7PEh.qzd7yVdyy1Wg2i4xFs+3muuTKn3XMR+.ZkKK7xmAdUSCuJof2DfjUJHMmAROBa6DvFHGKQgm6iawgnYOBDmRCEyYQ49GKbcAbBtrrO4bZy.XwHMJsVkJOsH7qm77BEfXUnrnQulGW76JpSbJeFU1nWOpirziMxJ173GqN+RK80EeIWzsZrl5uCpkbcfh0E9CDbXQoGqkpzS+kxgJgbYfvqNwyqKjWTRv0hh2VcCvWCEdzxCBXfIRPVYUZpRLi6w3zh8h3NRlfWLqAJ4jb4Os3qIdQzmT3MEVbjQ..rkTFv5FIoYMcxwedg2VHks2WHoGvKosBHo30E0q2DkEiFOZvDEqpXBtKEKwi76RCR6CpCBYEYS0v2dpV5JAGSvI0AE7Vbl7fAT9sUefhinpzxXTAGUpSJeXbRosGykFfXPt2BXcX.oAbLav+9geeyqPup0NDIIwLfEgaY.MPxTNf0NzWCbKlb8Ew6PCOWJFnOabbD3z9nW5kioe1u1vQK9ierlOy00i1VDxTOviO1xWArgCrY+ZBV+q28t+dS+zLgmbkO4xzrfgQ85wfcv3htai7EtwP1g0k5gP2r1EXMDtQdDYVpDU5Vr.ElRW+ppQ4.VGllP9SF+xzBwGgayjN8mLFyMALBA2+OvXLq7WfMTQiA3b3lG+4iBt.NgoHl6cDi3j3dsN.+lFG2owg6u0tmZW+vVs6712z9vC9gF06bZyC1cmFG91C6SFDJbYgxkpKBnKkX+k1KxSx.+jyodpzjx+R3M59ke5p4mvS6ghHIie1dDfATkGuejuMzk1gFeiJBEqbpRey5Jp0pnqMk6pW7A3Srvpp0VwBqlHLEqwbSAqw75hgLjFvm6cEZJzEhC9BgrO3QWy.0D0PSEk0Owbk8u9sexTo7h3j4jtl5JNHp7BQv45zo3uirtmI2ITanS6cIZKOOwEJZNVbQFjCo2qsva3f9BNyQsk4DIgns7EQJNQSbZbE51dBmyMzYlPFLjUGBySUvZGEB77tGvsA6nmryJ+QzfP8ct.tRY3Gn.deMg1BMINPx1v1D3kAXBTsNfPDMnrynxuzdQ5J.yDdokprYxnfFbAtiulUGFDTkD2lD.ZASlnZFjyJeplClhQ0JfpIm5he.tU3QJoNDOzQl2c3gPcKlGasKLu5nXrejGJiyT.6C+srZ+ahZy4ua7ZkKM5PoftBpIqfWf8X7itdVwdjKu1dueS6r8fzerOmdgA1oOoxkV.aLPG5kxNB82gD0WC3Qeo3Wwco8fPkKfryLiZaG08EAhnA5E2352g1i.DN2X+shjB3oxP2e6tYAEnhqf+z6wPtc1HQiKgakS7R0VBBo6vBI.62s4yYbQyHHbpdXqvrKiK.Z4ljJLxQa4N9oGssPbtOQWaOaC1LWpAat+GiWL03GeSsL8a+zMWSoZ28bMtSLIQSQOxQVbpHoScotSm2.ybMIuIE7q8m0lH.gV.FGYdr9edZZztvGsivX6+ygSGROoVlGU1jQko2xTLX63tKiM5U+1L9noKmtqTfSFkBjGuabB.F2lv+7LxfOwIPbpiomqpr7d5c.zv0TyKh2SstX0a1pEdCXm53j0T2PwkmUEWYVUb0YUwmMqJt1rp35ypha7wUT8eZRbyDUJJzRncCMmokUCtg1FZ.i9ODdN.kA

(the 300 extra bytes indicate that this includes an embedded network).

[David Healey]

@Christoph-Hart said in Recent commit to Processor.cpp breaking old project:

your snippet didn't include a network with a Gain parameter though

You don't see this?

With your snippet I see this:

[Christoph Hart]

I saw it until I added a DspNetwork with a Gain parameter.

I totally overlooked that you added UI controls to the script FX like only a madman would do... Why?

Also the script FX doesn't contain a setForwardParametersToNetwork(false) (or whatever it's called) call so they are dead in the water anyways?

What's your use case? I think there's a valid issue with the metadata system only looking in the DspNetwork to build up the parameter metadata list (so the fix would be to also check the UI controls in there.

[David Healey]

@Christoph-Hart said in Recent commit to Processor.cpp breaking old project:

I totally overlooked that you added UI controls to the script FX like only a madman would do... Why?

Haha, I'm using the scripting side of script node :p I made this years ago, I didn't need any of that fancy node graph stuff.

@Christoph-Hart said in Recent commit to Processor.cpp breaking old project:

Also the script FX doesn't contain a setForwardParametersToNetwork(false) (or whatever it's called) call so they are dead in the water anyways?

I don't know what that is, but the effect was working fine up until the latest commits. I'm not compiling it to a DLL, if that makes a difference.

@Christoph-Hart said in Recent commit to Processor.cpp breaking old project:

What's your use case?

I wanted a simple gain that can handle multiple channels.

[Christoph Hart]

Did you use the actual processBlock method where you shuffled the buffers into a Libraries.load() module?

Also the script is completely empty, all you're doing here is declaring some parameters in the XML.

I wanted a simple gain that can handle multiple channels.

If you were stuck with the "script" part in scriptnode, use that instead:

HiseSnippet 1249.3ocuW8zSiaDEelDb1krzpcUaumaksBgBfS.odfPHv1nVfHbJp8Dch8jjQwdFK6w.oU8du0y6s9QnW6M9Nz9AoeCnuwyjDmD1.Dw1fDxu2ad9868+wshDtz3XQDBWr8vPJBulkyPtr+g8ILNpYCD9SsNgDKoQkzrpOLjDGS8PXb92oXfWcET5u+c+5DeB2kNgEBcgf4R+NV.SNgaXsuk46eLwi1lEj4z10Z5J3GJ7EI.dxaUFERbGP5QOknNVNKz2Ph6ivekkmcUJw11yktcWp8dU5r6N6rmaU6xdkqtMsR0tjxU10tqMBW3HOlTD4HIRZL7RqK7F5zWbMWafKXwrN9TEwVHGvxZ1nC6y78ZMJ3DiP3UZMITkWGp9bqSXdrw7mDxdcpfRSzHaPCmaQPZqm.jvYfzJZH8FKG2HVnbhDEddkUSNjA6RfbSVnnOKBeq0gB3.b4lAjAzii.hwJrd0xk2nD7u290cS3tRlfWRvOUHomwW+sE+khqV7WKVZVQc6duxTlIR36SitWwpxgnEo357jfNznMJcEwOgN9ff6OcLsviKl5p85LGTvaxYxyBoF5iE9dpXk544y.HSXCd56a1fHIpjhgGbtPZjjofCtA8JnMPmhV0pAMdfTDhPym+fJGgWhOQNc4jpQyH.hGSkCUIJdLSNLai3SnFq7BqwdrP7MVsXR292OFycOXDhTeLvnoy7SrNpaWpqbB.Ww53eXYaCK+jaCKZZCAap6+zjklACi5+9MqI05gQzPRDssnkOY35wjfPe54.D2nTGeg6.G1OSmuAITif5pSrtaeBmS8iWl9nBOSylPmKRjLduSHxH1MPB4zj.GXrtK8PC5PXKbAUKjltrhVUV3P4doD2A+LB2RQiMB2ZFgaqnyYDt8LB2QQm2HbmYDZqnWwHzdFgUTzVFgUFILSG+oT40hnAoU.lmQ3WpS2woI1K6dC5.eew0GJBBYl9BHsmxqkveXXeAm4pXoOwnfyAAhDvFF+ZRSU8QU.iBVv9v1DlupGyIIFlZ4cF2AdOoKgw4ufFEmZyWXUdS3Onm6TgGH5EGSbgz7vVDYeUyqZPHzoPi1zcbGSVuHaQqdYbVop24ns1ZbAtSfJJo1YqJeZQh.sfMJpgg4v4yLbT2+nnfoC4TFdMqlwWnj5R7QWnJPUJkZEcvN0EJnNZAqdJ3Nk27Jvahna1a1KqnwsQiECYbtr.DkA8P89XJvTmv3F.NZt1Od6IjalgGTCIog57VJu+38u+u12Y.8ZMvMbus2e9E0zdU5EqZSuQ1Vj9tfptq.3nroZ8gKqC0GfUO8shbR57tHQRXJwb1tAsKIwWNG+CRjh.nMOcBMJiWUbduBJBm0qp860dTd0O8YM968MCACDBYeXpvGv0JXkdevGkeYW698K6ZOfq7bjfVy5bZL0X5Oxoooq9vYbt0xTq776mvTmoaPN5Fvpbhelc7vdtFrXBrQv6C3lS4UOXnJKb+m6t6KuM81TbZ51qXykqLjlYYM8F2SONzn4kFWP0EhAAjzwzK2cz9edQFZQKxvKZQFZQKxvysHKf3FItzUee.Ur8kobfAb7zAkqBe1GPWZKzUyVDE.ebykttS+plSwsWVE2YYUzdYUrxxpX0kUwcWVE26gUT8smlg6p9DX1cqiRK7w3i35lUXcH5+.8tIYVB

[David Healey]

@Christoph-Hart said in Recent commit to Processor.cpp breaking old project:

Also the script is completely empty, all you're doing here is declaring some parameters in the XML.

Not sure what you mean