Matrix Modulation System - Last Call for bugs fixes & changes!!

[DanH]

@Christoph-Hart So in my project I get a straight crash when clicking the 'Add' button in the ModulationMatrixControler floating tile. A simple project is fine.

I've removed all styling scripts for any modulation floating tiles, knobs etc - anything that interacts with the mod matrix. I've removed all global modulators. I'll keep removing things to see if I can find the source of the crash but in case you have a second to look at the crash report below you might be able to suggest something more specific for me to look at... The crash is identical each time and has been happening on UI elements too from time to time.

Thread 0 Crashed:: JUCE Message Thread Dispatch queue: com.apple.main-thread
0   HISE-5.9                      	       0x100627204 hise::MatrixIds::Helpers::IntensityTextConverter::IntensityTextConverter(hise::MatrixIds::Helpers::IntensityTextConverter::ConstructData const&) + 80
1   HISE-5.9                      	       0x1007d8b38 hise::MatrixBase::RowBase::updateIntensityConverter() + 1252
2   HISE-5.9                      	       0x1007d67ac hise::MatrixContent::Row::updateValue(juce::Identifier const&, juce::var const&) + 676
3   HISE-5.9                      	       0x10167e3ac hise::valuetree::PropertyListener::handleAsyncUpdate() + 196

[Christoph Hart]

@DanH Hmm, I can't spot anything obvious. If you can dumb it down to a pasteable snippet that reproduce the crash it should be pretty easy to fix.

[DanH]

@Christoph-Hart ok will give that a go, thanks.

[DanH]

@Christoph-Hart Stripped back the project to bare bones - just a few ui elements. Have emailed you link to the project. Many thanks for looking if you find time

[Christoph Hart]

@DanH yup I could reproduce the crash - the fix was trivial, but I'm not sure if it also fixes the actual project, so feel free to check it out.

[DanH]

@Christoph-Hart ah lovely, will do

[DanH]

@Christoph-Hart so it seems to have fixed the project I sent you but now I can't open my main project at all Want me to send the stack trace? Or try something else?

[Christoph Hart]

@DanH have you recompiled the dll?

[DanH]

@Christoph-Hart trying that now - throwing errors so I'll do the nodes first and then the networks.

[DanH]

@Christoph-Hart fixed

Thanks!!

I see the delete button as well, although I need to style it. Are there docs for this yet? Or an example?

[Christoph Hart]

@DanH just use the css inspector to get the CSS selectors (#delete for the column and .delete-button for the button itself.

Not much to add to the docs here…

I‘ve also added a property for disabling the unselecting of exclusive source draggers.

[DanH]

@Christoph-Hart thanks, I was just about to look for that.! So do we add that into the data? I can't see a property tab for it.

[ustk]

@DanH yeah just add this

"UnselectableExclusiveSource": false

or delete the floating tile and create a new one

[DanH]

@ustk ah yes the old create new component to see the changes You'd think I'd have learnt that by now!

[DanH]

@Christoph-Hart So since we have the new shiny delete button do we need the 'remove row after selecting "no connection"' behaviour?

Also I'm experiences a little weirdness with the delete button - the matrix components seem to cramp up to the left in my project if no source is selected and in the mod matrix example snippet the aux intensity and plotter combine too. Will test some more

EDIT - Oh I don't think the AUX combobox is being drawn in this case.

[DanH]

@ustk

"UnselectableExclusiveSource"

this working for you?

[DanH]

@Christoph-Hart just a heads up but weirdly I'm getting the exact same crash just trying to move panels around in my main project. Will test more tomorrow

[ustk]

@DanH said in Matrix Modulation System - Last Call for bugs fixes & changes!!:

@ustk

"UnselectableExclusiveSource"

this working for you?

Haven't tried, my project still either crash or refuse to compile the DLLs with the new Hise... So I'm stuck & lost for now...

[DanH]

@ustk for the dll try removing the networks from compilation so you're only compiling the nodes. Once that is done restart hise and add the networks back into the compile process and compile again

[ustk]

@DanH thanks, that’s what I did but it’s the nodes that are not compiling.
Although they compile from XCode directly, but then in this case the project crashes when opening…

So it’s either:

• xcode compiling nodes but leading to a project crash
• opening the project but nodes not compiling from the wizard