Major MIDI automation bug
This may be an OS specific issue but if one of you could confirm it on another system that would be helpful.
I have a project which uses the standard preset browser. Each preset has some MIDI Automation CCs assigned to various knobs. If I open the compiled VSTi in a host and send it some CC data to one of the mapped CC numbers the DAW and plugin will freeze and I have to use task manager to close them. If I open the project in HISE and move one of my controllers that is mapped then HISE will instantly close.
d.healey last edited by d.healey
@Christoph-Hart Here's a minimal example that demonstrates the problem. It seems to only happen when the control is inside a panel (but there could be other scenarios too that I haven't found yet).
Steps to reproduce:
- Import the snippet
- Open the interface preview
- Right click the knob, select MIDI learn
- Move a controller
- Save the preset
- Close HISE
- Open HISE
- Load the preset
- Notice that the MIDI learn panel doesn't show the knob but it does show the CC number
- Move the controller again, HISE will crash.
Here's a video of the problem
Lindon last edited by
@d-healey this might only be of very minimum help but i have a compiled plug that uses CC data from a controller, that the user can assign. It works fine here. BUT: I'm not doing any midi learn stuff on it. I'm letting the user select from a combo of options to set the CC# to use.
@Lindon Yes that approach works fine, I was using it before too. This problem is with the MIDI learn feature, it seems that when the preset is restored the automation data is not loaded properly.
Lindon last edited by
@d-healey yep cant say I've tried that --- over to Christoph.....
@d-healey I tested your project and did as you instructed. It is not crashing. I tested it both in HISE plugin and a standalone version, the latest master branch built. I am on Windows 10.
I hope this helps a little bit.
@gorangrooves Interesting, maybe it's OS dependant. I'm on a build from 23rd of March so I'll try the latest master branch (although I don't see any related commits) and see if that helps.
@gorangrooves I just tested with the latest build and I get the same issue.
When you tested did you see this when you reloaded the preset after saving it
Or did you see this
@d-healey I did not see any values under the CC, Parameter etc. either prior to saving or after. It would just save the status of the nob to wherever I would put it.
@gorangrooves But did it says Knob1 in the parameter column?
No. It doesn't have the second column. Only the first one with CC#, Parameter, Inverted...
@d-healey I tested it and have the same result you have:
- nothing in the parameter column
- HISE crashes as soon as you move the knob...
ustk last edited by ustk
Well, it seems your preset/archive (still don't know how to call it ) is corrupted for some reasons...
I just made a snippet of my own and it works (HISE dev branch 4 April)
I noticed your knob step size was weird, but even when changing it didn't do the trick...
Ok, here's what I found
Your snippet works as well when you remove the knob from the panel.
As soon as you're placing it inside a panel, learnCC, save, reopen, move the knob, HISE crashes...
@ustk yeah I already said that but thank you for testing and confirming the issue
@Christoph-Hart Bump bump
The only work around I've found so far is to move all of the controls out the panel. But I really don't want to do this as I'm using the panel's
enabledproperty to control the enabled state of a lot of controls. If I get rid of the panel them I'm going to have to set the state of each control individually.