Preset Browser doesn't update after expansion change

[bendurso]

@bendurso Actually, this works... but I realized that the search bar only functions if I select the expansion manually in the preset browser (and I'm not using ShowExpansionsAsColumn).

When I change the expansion using Engine.setCurrentExpansion or ExpansionHandler.setCurrentExpansion, the search bar in the preset browser doesn't work.

This makes me think that the expansion isn't being updated properly.

Any ideas on how to update the expansion in the preset browser without using the expansion column, and still have the search bar work?

[d.healey]

@bendurso said in Preset Browser doesn't update after expansion change:

Any ideas on how to update the expansion in the preset browser

I don't think you can. You'd need to modify the source code.

[bendurso]

@d-healey

Doesn't this mean it updates the preset browser with the selected expansion?

[d.healey]

@bendurso That implies it would, but maybe it only works if the expansion column is visible.

[bendurso]

@d-healey Oh yeah, that was the problem.

I changed the expansionPackLoaded from PresetBrowser.cpp from this

void PresetBrowser::expansionPackLoaded(Expansion* currentExpansion)
{
	refreshColumnUpdatesAfterExpansionSwitch = true;

	if(expansionColumn != nullptr && currentExpansion != nullptr)
		selectionChanged(-1, -1, currentExpansion->getRootFolder(), false);
	else
		selectionChanged(-1, -1, File(), false);
}

to this:

void PresetBrowser::expansionPackLoaded(Expansion* currentExpansion)
{
    refreshColumnUpdatesAfterExpansionSwitch = true;

    if(currentExpansion != nullptr)
        selectionChanged(-1, -1, currentExpansion->getRootFolder(), false);
    else
        selectionChanged(-1, -1, File(), false);
}

And now it works without the expansion column:)

[bendurso]

@d-healey Oh and the favorites are working now too! Amazing! That was the problem too.

[d.healey]

@bendurso Might be good to make a pull request on that, I can't see any down side

[bendurso]

@d-healey Oh, I don't know how to make a github request

[d.healey]

@bendurso Commit it to your working branch. Then checkout Christoph's develop branch. Then create a new branch (it will use Christoph's as the base). Then cherry-pick your commit onto that new branch and push it to github. Then go to github to create the PR.

I think I showed this recently in the modding the preset browser video (might only be on Patreon).

[bendurso]

@d-healey Oh nice thanks I will check it, i'm a patreon :)