[Feature request] Click track overlay in wave editor

[d.healey]

This is a strange one but hear me out :)

I'm trying to create loops that sync to tempo. In order to do this I need to put my loop points inline with the beats of the audio. My current method is I load my click track and my sample into audacity, to locate my beats, and then I eyeball it in HISE.

What I would like is to have a grid overlay in the wave editor that matches the current HISE host tempo, so I can more accurately place my loop points.

And maybe this little drop down can have a beats option.

Or is there another obvious solution I'm missing?

[Christoph Hart]

@d-healey nope sounds like an easy addition (adding a new mode to the drop down menu)

[d.healey]

@Christoph-Hart said in [Feature request] Click track overlay in wave editor:

sounds like an easy addition

This gave me confidence so thought I'd try and add it myself :)

I've got the menu option working, easy.

I've got something happening when selecting beats, but it's not what I expect. I've pushed it to this branch if you could give me any pointers that would be good. I'm assuming also I'll need to get the current time signature, and also add a tempo listener to trigger a redraw when/if HISE's tempo changes?

[d.healey]

I think I'm getting there :D

[d.healey]

@Christoph-Hart I'm changing the tempo in the HISE Controller popup, but my tempoListener isn't firing. Any hints?

Edit: It fires when I change the tempo in the settings floating tile... so I'm guessing the HISE controller is totally separate then?

[clevername27]

@d-healey I'm trying to remember from the last time you and I messed with this. I uncommented the related JUCE stuff so I could call it from HISE—are you familiar with that?

[d.healey]

@clevername27 I'm not sure what you're referring to, more details please.

@Christoph-Hart I think I'm 99% there now. But I'm running into an assertion when I change the tempo, something about needing to remove my tempo listener, not sure exactly what I should be doing there. JUCE Assertion failure in MainController.cpp:1679

Attempt at implementing beats view on timeline · davidhealey/HISE@1c7d93f

The open source framework for sample based instruments - Attempt at implementing beats view on timeline · davidhealey/HISE@1c7d93f

GitHub (github.com)

I'm still wondering if the tempo listener should trigger when changing the tempo in the HISE controller, is there a bug there? The time signature listener is triggered correctly.

[clevername27]

@d-healey There were a bunch of transport-related parameters that are commented-out in HISE; @Christoph-Hart introduced the Transport object as a higher-level solution, if memory serves.

While searching, I also found this post, which kinda blew my mind lol…I didn't realise I knew how to do that.

[d.healey]

@clevername27 I think that's unrelated to what I'm doing here.

[d.healey]

Something occurred to me. If we adjust the start time of our sample, then the timeline doesn't make much sense because it always goes from 0. So in the branch I'm working on I've adjusted it so it always starts counting from the start position of the sample - any downsides to this approach?