Renaming C++ nodes causes them to break

[griffinboy]

(Edited to be concise)

Yesterday I suffered an issue where my C++ external nodes all broke. They all suddenly used 0% cpu and emmited no sound. Even when rolling back to old versions of the code and backups, ones that I knew to work a few hours ago, they were inflicted the same. Importing the nodes into a new project also yielded silence from the nodes.

See the comment below for what I believe to be a specific bug / framework issue.

[griffinboy]

@griffinboy

AHA!
Okay so I think I know what's wrong, and it is indeed a bug.

It's to do with the scriptnode c++ workflow.
If you rename nodes, or copy nodes across manually, you can break them.
You used to be able to rename to .h files and then compile inside hise, and it would fix everything up and compile the nodes it finds: But right now that doesn't work.

I had been renaming nodes and that breaks them instantly. I know that you need to change the name inside the node, as well as the file, and I've been doing that.

It looks like something may have been broken recently.
Some of my nodes have not been working when dragging the .h files into the hise dsp networks folder and compiling in Hise. However, when I created new external nodes from inside of hise (no copying files across or renaming) and then replaced the internals of the node with my code (I had taken special care to define the node with the correct name when creating it in HISE, so no renaming is necessary) everything suddenly works again.

If you want, I'll create a repeatable test project where the issue can be seen. But I'll have to upload the whole project.

[Christoph Hart]

@griffinboy yeah renaming stuff that is used elsewhere is not the smartest idea.

You also need to adapt the custom_properties.json file as it will look in there for properties of your node (eg. whether it should create a polyphonic version).

Also the compiled scriptnode networks will assume that the factory path (project.my_node) relates to the class name in the namespace project::my_node.

[griffinboy]

@Christoph-Hart

Right I understand.
I was still having issues, just simply transferring over node files though. I'll take a look to see if it's just the renaming that is the problem, but I felt I was also having issues simply bringing in node header files.

Idk if this is the case, but I'll test it. I was about to give out some nodes so lets see

[griffinboy]

@Christoph-Hart

It seems that the drag and drop is broken now though.

You used to be able to copy paste .h files for external nodes. Now that doesn't work. the nodes don't make any sound unless you create them via Hise. Particularly for scriptnode synth nodes. Effects seem to work when you import them that way, but not scriptnode synths.