High Threshold & High Ratio is not working on the dynamics.updown_comp node

[orange]

There are really great additions in Hise lately, congrats @Christoph-Hart

I found an important bug on dynamics.updown_comp node. Using the commit from 10th Septhember 2024.

• dynamics.updown_comp node's High Threshold & High Ratio is not functioning. (Low Threshold and Low Ratio is working). High section should be working like a standard compressor (when the Low Ratio is 1.0 of course)

[Dan Korneff]

Looking through the code for this node right now.
The high threshold logic depends on the value of the knee. If the knee is too small, the high threshold and ratio might not work as expected. Also, if the high ratio is too large, the ratio behavior might be nonfunctional. I'm gonna throw this on the analyzer and see what happens.

[orange]

@Dan-Korneff
High section should be independent of Low section and adjustable with common knee. High section is classic compressor (downward comp adjustable with knee), Low section is upward comp.

[Dan Korneff]

@orange
All of the controls seem to be working. My only complaint is that the knee only controls the curve between the up and down compression. I would love to see a knee for the entry point as well.

[orange]

@Dan-Korneff When the Low ratio is 1, is the High section working alone?

[Dan Korneff]

@orange If low ratio is 1, high works independently for me: