Slot FX Broken?
-
The issues seem to have been on the develop branch since November/December.
- Loading an effect slot and setting an effect from the module browser popup = instant crash. This doesn't happen with hardcoded slots.
- The "swap" function breaks parameter values of swapped effects, instead of restoring them. This snippet can be used to recreate the issue, but it also affects hardcoded fx.
Just want to confirm it's not a rogue file or something on my end before submitting an issue on GitHub
-
-
Confirmed
-
Appears to be related to the new dispatch system, I tried disabling the new system and reenabling the old one (by changing the flags) but then HISE won't compile - so that needs fixing too (or removing).
-
@d-healey said in Slot FX Broken?:
Appears to be related to the new dispatch system, I tried disabling the new system and reenabling the old one (by changing the flags) but then HISE won't compile - so that needs fixing too (or removing).
Thanks, I hadn't found that flag yet. The bugs started with the Nov 10 commits (not sure which one, compiling gets spotty there), which makes sense given the dispatcher changes. The effect slot crash points to
.../hi_tools/hi_dispatch/02_events/Source.h:118
Unfortunately the swap bug didn't trigger any crashes or meaningful changes in debug
-
This post is deleted! -
-
-
Sorry to dig this one up. The Effect Slot issue was resolved quietly months ago, and I incorrectly assumed the fix carried over to HardcodedMasterFX.
HiseSnippet 2420.3oc4Y0sbaabEFT1HMDwo0YlzK5cq4EYHiooIonjrrqmJJRPKNg+MjT1ViphmU.KIVIP.V.PKooQuQ8gnOR8Mn8b1Ef.fhR9mIIWTCMiD1cOmc+N+tGbz.OWCluuqmRFswWMmoj4ApitxIvpgEk6nztoRl+hpE0yzv0jYRlbIw21MvmDv7CT1+p4TeeloRlL26UH4YxdeEwy+4usO0l5XvhmRQ40tbCVG9LdP7rC16m311snlrw7YInt1dsMbcZ3Z6t.f18TKqLmZbNcJqGEIaCUkCn9VJY9Q0xasMisylSLMoato41au8tOa2Z6VgNobM5oU1d2ZUqsS0msyDkLektIOv0aT.EPuRl6uuq4UirbuvQd.ul6yO0lgCpnLBNY4zsbsMQQDmUogE21bPjNyWA1kAwZv6I0feuZWtIe47wZxGJVfDyQREXlMRCu6kBdURBuxIf2ZfTlDP59RH8cpiL73yChWAwy2n11If4MgB1ojPQRqxFa7P0Ft.ENAklQOm0xCFrji7aWtbQxVkKW3EZZO8oY6UuqNoeKx3CzIsdKYbeR6dizGNljWu6fwGQdIomKrPgrOYcOZf01Of7dpGx7KIGqkSe17fqxUTKWiEdumo+OvWGwmM2lMj8dl2owiQeObTSlMUvgvIi4ImapG3cI1GKWuE93aCrn9rVuUrCzfEdTPuKH9JG5LtgflQVz4HMZmHkO.Vi5ze7HxP8V5C060PO6sIAiDgHnPHBkJMkEfS05s4yoOYByHPPQkbEJdmDT8CQvleHBp8gHXKjfPAbP8d5cP6Vy1iFzo9QQVxF86bX2d2zrkEdHhekx3Mf5vrAgOxyAN3Ftyl65.CxmKb8bnSCdnidS8A3gz5vdMF2teu04cnwcr4NLxjENFAbWGh+Ez444lWVoHA9c0BZ+Ssr1tFTaH+TE3nE5+iQB.Qa4JUStRUbEsr.8kD6FrbAwLg.rjGaN3UEjGl85kN.RUzf5s6MlLr+gia2KkSfVDy9rfAH2CcWD.HOeDxyOUf0okl.I8paamOvh6iZn74NcpLYWtBHNlhaQKWTiYxlPWXGjqHoRMbITKSAQIh0Nn3su6BGS+7kkx.RBllFnhd7lmPdpTtKYyblFXsjjIWJbRQMApJb8H48IbGIwEzxBHMjNfLwYAQhdfYT5.gpFIAbSffIWhTz1LdZHVhAKvMK4u3T+.OtyTvpUh6Xxtr+j74dWtBjGSDFwPnsj0SCyFI2WteT1I4lGRj6omQdI7Nhyr4lbYtmuVTVLbYDNqkDDyRhBIA+ibhHb.SF8JL+0gf.Tfkluv2JOfDDXWGoYo1ysPaT4RaIz1nittNFaM9f5iEAVMGV+UuRuYXNk18Zp+VRaL4B71PX9N0GMVxHjHcLodm2T+nQj2ztSGx9GQdc6Qs2uit7zL.ie.0yKxXFZKOCAvKHmQ9qoM+jyd7iAqaV9DjlGE5IYRCnkf.CbkrQ6nT5NS5UkdxzL8BDpQROOFCmKwv42.CmKv.Z43.IQa8wmKbFIgnCzuGyOozRmge4WHgSIcsdII7RBAniU56faBy1mkb5JkJGZ1DAWxnsDAfvEFyRFBlMDDoDTTcwKD4yIiiGhwdLygfmD0YpMK+wUKRpBd1hPvejvKBQgUOg7DRshx4f2NoHYSwojBMx+3W5BdfUcD2wyXA3qnzwpPDildzKpaym5vLGytLHReIc0KRNtbwUvfbL7mbFf2uG3WK1pqkRanF6SPzRqadbhw.zldzuqBdJrH8PRoB9nv5sqftV65BqbOP29GNRmzndmN6WuwOs5MWIuLnq6BeVCps8oPQrw2F.kw3DHtQ.CarRjT+.FepkLCahj4VqKSN5iJ1nRVtPYQje3GHORN1i4CWbfdqwxpjlWR5RgZBlX655Ex7UvdiGSgU1zvMAyD0oe8lIuqF1X7Vp2leksuHQxJFQglmU2RCatw4xvY4DnAHJavpTIBsSa69.nOapsIbuStGB6MrKwDbTHaBZLr.e8vqZtNMxmg1wCmi5XteS1D3tcyUxDhqciTFOoRn3kDDtymKtf6tEFQ0Io1vhjarKBJWUI8jJuX8hTji7HVfrJsKCV.UHMi4rH6cW2EFuFQedHeM8pD0dglaYUuYy8DxJ+.UTmMmqyScmLQ7pGaF3p.g01hgqmd7MtiOyKHZpDWugGGVsRHLjdOHDj2OguJE23Z57w77ycmuXdWPVaiDCkUIY5LWtS9b+cGQxerhuzBK7gKRkVBEVjdY8eQyspBg.FgUTfPT84CY8LrjRTnfX.eeBYMZkmmZsD5Fbgrm5wnm+hkjDptEKIMQIJqZYkvmrlRltQEWYuaxAoZI8OJ5PjLtBlRX2E35lUcBOfCqMi5kes6f7F+muBn9PL.eH2GEKfE9.n9KxazIhzcXoZ0aL9v5cvLePc+8i9rHrvMfgvxyWcyAMRn1I1Q71+5Bsk9GtN8bCX8cxK7LztVir5RSlr10P+ROWaal2ZWF6th2cwXdmEyNEyc+dp8B1RBUxb+zskP81aKQxtlXH+5uDD55z1gGzeNy415khR3mLBucX6lPhLrWFgyAzMG704HDxzj8dtAS1YirpMY9mG3NWPa32Ypj4AAhU+1n9dfZcEtIRenMP4xkca5eau2UwsdZ7dWvMCrhm3m2yRbcbL8d6g4.h5N0CTqUc2Z6t8NU2cKEvy18hnq5Av9mTguyiDOQ5zOJY9Wp2HJWSF3pEGqncSZRG+qIbx0B6ThVx1jnE2iDMQCRzB6NhVXqQzj8EQKroHZK6HhVT6PzB6EhRbMxRo9Ykqt41aWsrRzWuJmdmmUcypU2sbB5qFsRkcKW9YkUTtYOpdnZWWyE13ImrkYHvCW.bXS0mJrWTN97fqR13we05i1GKD+N0AX960iwMVCFA25eKvXX2G+VUYhmX.devk+2nVMpdSczeV8fksKtK0GbzfrkBb7GUS18qTHpGK3BWuyEM1My89nQWk6V4Ha+xTn.KONDsq1awrQfunACzMNPJ.LcVlMvDOxwkwwn8YDywTL3+BOgKVAGmIbwJQKp7Yq.p9ktBXyuzU.09RWAr0+mn.983LlQM7bemgrXML06WKlAjaGw+Qr+fZmV8IUTDkuEWox61aF2j+NCizazJrU8yisM+7Xq1mJappuVuymJSekZu9i0WgK34t45qUGVuWy9c+TOsuQsa+lj2bf9M.5ZNR7+BX8EAtyjkKnnzcftnd2LYzcnfesHdP4+UVDtQA