ScriptNode: problems when compiling network to dll

alhug

@ulrik unfortunately, that didn't work either.

ulrik

@alhug sorry to hear, I think someone more familiar with scriptnode than me, should take a look at this, sorry I couldn't help

Christoph Hart

@ulrik I think I've lifted the max parameter limit - if you exceed 16, then it will dynamically allocate more parameters.

It seems to be a quite complex patch and I noticed two issues:

The last container (Tone) has a recursive parameter connection (xfader to the container parameters). This causes an endless loop at code generation, which is why it crashed on you. I've added a failsafe to detect that on both the UI level (trying to connect a modulation output to a parent container's parameter will show a invalid icon) as well as the codegen stage (will abort compilation and show the error message with the parameter that has the recursive connection). In order to solve that, just connect the eq gain parameters directly to the fader without going through their parent parameter.
If you do this, the compilation goes through but it crashes because you have a slider bank with an unconnected slider at index 1. The compiled node expects all sliders to be connected, however that is not coherent with the scriptnode version, so I've changed that. There's a small performance overhead when modulating a slider bank, but now it's consistent with the scriptnode behaviour.

I've pushed the fixes for this and I can compile and load your network now. Attached is the updated snippet with the recursive connection removed.

HiseSnippet 3738.3oc6c0sbaiaElxNP9m3r6llrs6E8BcQuH6zDMDf+O8hMI1waxz3DuVoI6cYXjfr4ZJRsjT1wamdeer5iPeD5iPeCZO.jTBjhRlT+X4jXmYxHB.BbvAmy24.b..OLvuMMLzOPp1Vu4h9ToZ6fZcgWzI6dhsimzK1Sp1WgNvNLhFzHNomdQe6vPZGoZ0V+GYITaqaIw+6+9CO0101qMcTRRRu02oM8kN8bhFk5gO9u535tucG5ab5ITZ0G+h19d6565O.nm0QxR8saep8wzWYyJ1ZHoZ0eVGmH+fVQ1QzPnLO0uyEsNw+bu3x+VmPmO3RYOfkZAUTbxR6dhiamCS6qgRR0PGNpmudbO+9nCb53LL8QbfugmQiQugHOn1ZSijvUfjpIPR2JljtKpU6.m9QixgQO2F8BOX.oqMvpEIk3xJU6eg10GJfWTyd1mR2O.dX3K7.cY4G1.9uu+uzcfW6HGeuF9duxOh9ZuG78a+22dqs+Ga2HeVc6VXdrlIv20kFTX1rQ2fo8hOvaPuOPCdXiyrcGPGVPn6mkmVub7z1w8ZgB568BOmnW2ml7799tcX7J1uGeDPJgsA+5u8h8rirYCJIoAkqOMHxgQN01idFHUGODsEZOZ3oQ98A45wF+.IG+NCbsixJNwzaRx.3GYFCYCTdgNQWHpWUAYL4oJiUVR7tnCchZeRwz3ZEPi.mZYPiIZl2A8rtcosiFQf2Bs+OOqpgxUVMb6D0PnMYM9NIO1X+eFWnB3+DMRXue.suc.8M9G5ZewCBs602kdDPiOrwGb8aeZKmeiNtFR+XR3orR7f1mX64QcCmEEo5KHvIoi7GD43c7A1QANeDfOe0fds.X51zcSnNHsZqwzgheVl8LStnE0qC+g+G7WRlX1y0RxDmlof52qnQm6GbJe3H42R01fw62F0gBLx2eFQ5szfPlnYsMPxMg+I8DWW+y20uWemDgVd2hm5g9tWz+DeOm1rwo3xjR5Oom+.nUSn+maG9FaGWlbdqAg.xQmW60BJL2tFSN6U9cfeUee61.i8hCsiNgouvvd.gSZPy1CEREn0QRIb4OXD3P6.vpFfJGFSlrpM0zWLmCnxdL1A2v25r7i4G71GwZf6f5B0A48bIIoLTz2IPQcCDJUVJY1Z08Bt3cznV8cAq5SjODxyd1Zt0DZtuB0I3hcSqVoKguO+s2lnO1EbMIWK8M7VBT0Zlja0ZHAyGPJIOA3mqwZwuloMIHO7VlRLqdIbvPwhVmgVSSKABczAs.snyYf0uwN3XZDu9ESHwFlGkCYDl8wjd9K5vThNF3eDogzAKw5bSUYagpUg3hqPgdKCwM8I.w8.Gug8NlR8A1eb3yX3YFWXCTbROYPjeO.YK0htvnXZ2Iyf3sgAw.ZyiqrfxZYn20En25in2MQOBKmmjYO2Jh1mgyybwTtITF9eXUKYLVGvcOkddLYJU6dHslpDBwP1vP0TEqHaIEOty4aBcX.rpXxHOaaSDqEqFYvJfhLVVAJfkkopkgLNw0yV878iNALEjJDVGQX0tzUOSYGzQzPZTb0loxkD02xHrkIGtsdQ0qcPuH7srbaa6lVi.iNCZz4znkLZzsEZu6iB4LbZm22eHCNSq9GGhLUPImCTpZSE54NnWB8S6fFGAdzHIMxSwQvPECKrI5W3VEyhKbavKZHQ97AklnxVNvAkJANHTOnQ0SgBeUW4IFFentAuejTE2Cgw3lV7hqqanpXYMIhoXDuQM8nN4Vnm4YCdt0QJSQEkT2BEPaScNilWHMH1UtloYOGHgkF4VtoUhKQ6Soc9.Ls9wGeDUYyXONQfIS23NPpg8alj0bzEVqbCEiDDJCL4Fn3k7H+KWxw8MPFkusDUcJAOsdLO8Y+zK8g4rNy3W6fTIVJDrkooUA9yJOAns0yHfFdV22S+Uk7dZ00wkUOMiythXXLe6coeLc566GWWi9ICMyqC8ir4P9Hrzyf4M0oCsCu7rZHK5S8hGvRr4MZDaKHghkOHDKKYUMcBQQ0zvTKYLa+.5uN.lTwEkDm5d7g+XPGrEQ1hXIz72CY0zzh8mN1TSQlXnLNgnqZfMLwFJx5ZXScNgrN5mDvoZJKqYfMsHDSYS3mYHFA86MPORMa+uNhmPwtpLkt0DP7lQWQXkUFqXnaBzuprNwzPu7sr5DvZy6yMo7JxUG.eRnfoJKp2nrTNoJkEk5wTZxrpDXybpD7DVwpD+dVsIaE+mggtpIQyjr3UJTWkJEjaTJtNXAIczpz1L9RRAQ4JSAY9ltKe8ey3p349efsFwUxUwh7HrrS+ccgV+1nd9c3M.NKAbeABHsHKPZX6Lq2YnqSGZvGr8NsPpfO26gEoZnMnoN.MsUFbgrpe6f7Ca63xC+S9YjOBfYlV+u6HT05SotyA21hyHODlgXX1GmJr6WiLaB+08O+aNO8cl6trVfwBVlCQ6QY3liouDPaJj8bYSZOmv9vb9d5ftcS5gYRAdVjUUJCRKN+gmxZQBP9ZYpUtd5bXuK6pflo6fy2x5Sn+rCupabDabcxlxlI7ZlcsHZorONMgwCOwNbrU3rh0RhI1x4X0Fn9T6SUKb0yY4TMo2aU9UGbJfFogNXwoJLwteVp3FE4KWjuNel2YTkY.lqDMWyOI0bqCCvSW0srKXZcTe+yyMknsQvadRSHiqjk6Muczxg5rMJz4XB3MWNh+qhI9jLuF2ApygMu5QM2B8Am99t14bgKk3uJfLGQBELOAlCxoYWM3xxyC91BBTlxD3GkM.SxyZ.lJY8zBl2EsBy5UKS8PJXVu5Jr40anaJapoZXYjzP+ncud1kTHtXF4mxgbbqjHHQV.wbT9SjXNRzRh4nhglhtLQ6JIliEI6f+jV1oNJx16jUENxUcfp0UaZvJNQUSkPvjk3JVs.2SFIiQ4L6x8Yfmwxvggw8Uyb5CpSztYJ1zWNg2F7newGc6Eq.UH0qSdmPS22D77p3PxzoGAjmgQCHc2YjsiM1NbCeyNb6lc3l350ylo2ozC787m7J12afajyBbOIuVl0.87.69LcDLd4uYc2fqohWkppampphmrt5vxPtNrYrRsMW1Mi0hDZ8q4hGobrqLIDx0BIDRIjPveQJgLYxLlLNHES6xn5bjY9PUsVgN4KL.kwQegtuzzeQ7jewIuZW+Re14OIXLzqXW+hybQ46W4VoQD5P6YOL75SbsTOZfaEVDP.dX7Cfwx.aX6gQWtxAWdVN3L6HDH4qIwQVY73Hu9rDrWDpeO6ILK4oVeyTnkKZYFzJ2ZeNagW9aQXRb7kY+u0tv+o75YMHyr0wqpAYdAYBNYGcv8+CuZ7OL1AfDzMykjC.hay3XQybytNUcik07uhzSxpRxZdSlnnYguUBuI2aECMu3WxoryxpblI.6wLIj9tWjJgcW1zoTIlxJFXYKECsYHLWHzS5zQbq7pwNvDZxJVx5DUK9wlXhFMFxpWQgeX3vl4Uyv1Th3vTXwogbHaIW0QbPf2UVOgvet5IzhetVIrOqkDTasrGNtQMHY4CsKfU9EufykDEFsOKhfm5UYD7l3NTY4GJlMP3prf5y44DLk29kTDHTtFFAhkWErPm+vVn2Qidiu2bukvwyG1xT285rW3VYBoy3T70x6zgMSvHWPav6ziHCdwcwNrYRUthtYGPrlOOVkvA94y8S6yvn0aPZZRzAKI.1mEQgnr5N4OrxXpoqanYZfIFl5ZFj44jxMwML4R9X.oqnPT0wpJFxJlVFZK9iADdUdN4veYeN4FJvqnYzTyxvDD100UwS9PBu5OybU4PkNksT8mhmXtUx4rdnwsazT36HLKEfcg0zk0v.1nL4FMkaNaoEMyt0iqhm6z5DpaWoKYjgQS4CDz3U1K8u7JK93dLw55Z3LoxvBua9PcWGwtbHktrK5HA+tzMUvf+JXUCCYMYvVV47huvKVpKYatNLb7Cit8kcm+HPmDUCKc0jkxmsZ9kcBLoa7gIGg8bz2lIWPgW5lEX3xRwPe.bPdfKJ6jfRlyX4XYIS+rBDjpokLfFRJKAkzBkibtC5c7C08dz9f4sRRULHdMCMU1RXAPYpkmYMwymRbzHFi71Ig7XFjJK0wDwT0LL.gLcEY9XoZoOoxhGv6KkChhQ6Y2fRmmiBmGavir4ZxlLkJQAaYoo.74JNUekobXqyyoS5Fb6ik398YHu9QZMULM.Sa5rn8oVE04BIxwV8.A17ANcVFrYMY8lV5FJ5XMClHiQE6ApkiMiRuusftwOIsfuiZFcbOZBy+WES.TCXdqvPy70YXtcUnrBzIFWVoXOuRd5a.ZSW2RGb7QVo7vYSfvljbx1.s8bmkgXBLCQ8lDSMFuUQUiPpXGfTAsw3dQITFEYvfxnYSLwzRSiavPEj.lOZr.lLm79cnV1QCB3QrI4RStjfywYN6atGbosqAd1FP8emSmKwtFKz1y.wkYKbUVS+kZiKl4gxQLBa06b9FMb6RNF0DGdxKMRly.qQX+LV3NfXFbU9o99m1yleOfO22H+eabl2F8N6yn7OwERwwJk8bW+fdM9QJP7rizOdJejK92k8ibQ+R+Qt30si.R3MA1dg88CoXwZNWdDw71iFMvKawiSJSoXcu8gtmP417woIRDSDFlxTYvyYpoCXW76oO9e9g3YK1hB8lNudz0gfvmsfCG3FR4phXwWbTxDwjetcPGXboclOp.qm89q+Vk69qO62WAgxWv08e8UvGBjEyGogU32QhLejD1JkFa4vVlqm4cF0ETMkhMYrGsq8.2nzTypawvnRuV9GMpeDMJv43ioYDlJrC8jnH9V2LMk6+3intT1Utvvj9SONNdZ7ULY13EU+61RgiWeGJlbav.DZ7o62+i0+r96+Q409.7vq2ih+ADfKSZvGJarZFKuJ9rgbUzF8raG3+9jsK.SoeSdJP+1i+soZKvkK34FXoyD8bpGXt38samdSZT76Plg2QYFdG0Y3czlg2QeFdGiY3cLm56vrTmrh+LYdHgCeVb.UpktN2f3uz+G.8WMz1

ulrik

@Christoph-Hart said in ScriptNode: problems when compiling network to dll:

@ulrik I think I've lifted the max parameter limit - if you exceed 16, then it will dynamically allocate more parameters.

Ok, I was not aware of that. Great!

alhug

@Christoph-Hart fantastic. For some reason I had to recompile HISE. But now everything's working perfectly. Thanks.

Christoph Hart

@alhug said in ScriptNode: problems when compiling network to dll:

For some reason I had to recompile HISE

Well if you don't recompile it, you don't get the changes I made :)

alhug

@Christoph-Hart ohh I see. you made the changes to the develop branch. Well, thank you sir, it's highly appreciated.

ulrik

@ulrik said in ScriptNode: problems when compiling network to dll:

@Christoph-Hart said in ScriptNode: problems when compiling network to dll:

@ulrik I think I've lifted the max parameter limit - if you exceed 16, then it will dynamically allocate more parameters.

Ok, I was not aware of that. Great!

@Christoph-Hart are you sure it's working with more than 16 parameters?
I have a network with more than 20 parameters, I can compile the network to a dll but when loading Hise again it will crash, I have to delete the compiled dll, then Hise will open the project without crashing. So there is something strange with more than 16 parameters...

Christoph Hart

@ulrik Can you make a minimal example with more than 16 parameters and check if it works? If not, please upload it then I'll take a look. The limitation is lifted, but it might be a problem at some other point in the process, however I'm pretty sure I've build and loaded an effect with more than 16 parameters recently.

ulrik

@Christoph-Hart ok, I'll do that

ulrik

@Christoph-Hart said in ScriptNode: problems when compiling network to dll:

@ulrik Can you make a minimal example with more than 16 parameters and check if it works? If not, please upload it then I'll take a look. The limitation is lifted, but it might be a problem at some other point in the process, however I'm pretty sure I've build and loaded an effect with more than 16 parameters recently.

I think you're right, I have successfully built an effect with 17 parameters and everything is working.

What I was referring to before, was a project I had with more than 20 parameters, but my project seems to be badly built and crashed Hise every time I tried to load the dsp.
So I removed a lot of parameters and found other solutions to reduce the amount of parameters, but the compiled network still crashes Hise, my bad...

This is the project I'm talking about https://forum.hise.audio/topic/8258/what-s-wrong-with-my-network

ScriptNode: problems when compiling network to dll

40

1.7k

11.8k

103.0k