Pops/Crashes All DAWS Mac/Windows
-
@Adam_G Please click on the Sampler settings so I can see the buffer sizes.
-
@Christoph-Hart And your DAW buffer size is really 4096? If yes, that doesn't make sense, try a lower latency and enjoy a responsive music production system lol.
-
sorry haha. you are right that would be unusable but i dont use this machine for music production. the trial of fl is installed purely for testing purposes. the same issue i mentioned is happening across multiple daws with various settings both windows and mac.
after testing further i think what you mentioned about extreme pitch cases may be right because it happens when notes beyond g8 are pressed. does that also relate to buffer size?
-
@Adam_G Yes, there are multiple safeguards in place. If you pitch a sample up by 4 octaves it needs 4x as much samples, so with a buffer size of 4096 you request 16384 samples at once which will blow up the streaming buffers). I need to check because I think I've added a failsafe so that the "internal" buffer size in HISE never exceeds 512, but it might still cause glitches.
I'll take a look at it now, should be enough information for me.
-
@Christoph-Hart thank you for looking into it
-
I don't see a problem here in the default mode, however when I'm activating Lazy load, it will throw an assertion about some buffer overflow. Can you check if deactivating LazyLoad prevents the issue?
-
@Christoph-Hart thanks that seems to resolve the issue some but if you add a Global Time Variant Modulator and increase the intensity then try again - crash. is there a way to resolve that?
-
Where do you connect the time variant modulator? To the pitch modulation? Please make a snippet with the patch that crashes.
-
@Christoph-Hart yes, with the same patch i shared
HiseSnippet 1091.3oc2W0raaaDDlzxqajZZPRPNzCs.7PO3.jFHk33TfdHxRV1PnQ1BhtF8VvZxURK7xcIVtzspE8cpOB4QJuAsytKk3OQUVVwIMn5f.mYmY427+vgRQ.IIQHcbqe1rXhi6cQ9y3pocmhobm9G53dOz.bhhH8rr5LKFmjPBcbcqcrlga8scL+d2q5fYXd.Imkiy4BZ.40zHpJm6v1+DkwNBGRNiFUP58Z2OPv6JXhT.O0PMchwAWhmPNAqEaKji6N8BoJgzWgUjDPlNhvY9SE+J2J+4zD5ELhlnkiObQV1NcmRYgCmaqINNtng4VdMqk+Hz.ZHcA+bOv8MG3kqQQef6VqBRstAPxs.j11BoGf7CjzXU9IZ77kn9bHfLFCt5hPwJqi6aQcEf.b0SivWRNRBDKTX28a17IdveO9GGmxCTTA2SvOQnHmx28wM9iF0a7mM7pdz3wK8L8qQJXLhboGqitxUo3t7znKHxm3cElkRVHHX9k8o6rd9z.qUWPPAuOmpNMljQejfEp8U5me+HfSlaCd5m6eHVg0AkLdfbwDohpgi6gjqfrZaHpN5PRxkJQLjW+dwOHyQDlxvpxoS55lrC.+QoXnNPwSnpYEqqplis8+t+nYA+w0XsqIbe.ZHUELc43cqkfWvq8wFuYUreEp23wj.UNX2Fczurxxyacn7sVn7PjuRRvQT9DebTLTRXvSCTFUqaiFmwqciygRBSfC8o+dAwda6Nof+RVl6e017pNHRjxK8txP9HRLAqfveActS6QiNVJRiqp06dkIY4LIz3FbEEO3TNA76ph1XWoHIYLXNl6Jo3QCSkSz9pbNiHWQjIk4cRZDD64bBCTF45pqbSH5XMMX.VIo+VQoMuklmgMwaXZhgtUE5mUg94Un2qB8KpPueE5WlSacnCvw5LC8zrJs49h0qMGbACwfIWPxNzIKtbKmxsXJH5BetAWElctjIR67wZH4mzFXe38aqsdv8ZloWeNF8o5PUO9UPMJvQiwGBSQFiSYp4bK2uXffKhmJ3zfxUDPF9jIDYQruTC5.kBJHy47n1iHLBNoPI82090TNAKKWnei7E278aVZ75qQV35oax48+i4j09PmS1Zo3ccy49FzwLwEXl1idNVRwb0BKv.duLAr97LQ7VHSqq2V5PiELrTuS.zBNqomVVnqsxpmgoYuJc2OXwJNwrPnsY3sUd1mo6IrpTm6kskfG71kpOyyyuKxLWySuFx+UPcjHUAqWLeDOB1CvG18IfTbafszaXXoapo0.xmvCMD+M7K6vVyWcPeXq4G5DL+p.aK6YataMBWmHaV+kAKkvJVFj.aXogDjQ+IAkQ3.o3MA1umRi06X3.nja9n45vWuCzdsbLeiEnGp4Sa5DAypeSPftP36AO7x04YafNOeCzYuMPmWrA5r+FnyK2.c9gUpidMoCRUhH6PBfwvd1DK2dKRrp47ODq6lxA -
@Adam_G nope, still works OK.
What happens if you set Preload Size to -1 (this will deactivate the streaming and load the entire sample into memory)?
-
@Christoph-Hart crashed upon hitting around 6.00 st on the modulators intensity, i was playing notes in the c7 octave at the same time
-
@Adam_G Ah yes, setting that mod values will bump it over the MAX_PITCH_FACTOR constant and then it'll crash later.
I've pushed a fix, let me know if it works.
-
@Christoph-Hart legendary! thank you. Hise no longer crashes on those notes but now when compiling i get an error in factory.cpp "error C2027: use of undefined
type 'hise::FrontendHostFactory' " -
@Adam_G Reexport your scriptnode DLL, the API has changed.
-
@Christoph-Hart works perfectly on mac and pc. thank you!!
