MIDI Player/Transport bugs & info requests

[ustk]

@Christoph-Hart After having the above double triggering issue fixed, I wonder how one would approach automatic file change when reaching the end of the current sequence?
I can't find a reliable method to perform a synced sequence change...
I tried using setOnBeatChange and getPlaybackPosition, and computing the sequence length from the ceiled Numbars times the Nominator to count the beats but it behaves unreliably...

Another one, when not having the endOfTrack event, the midi player overlay draws the content ending at the last noteOff.
So in the end, I wonder if this shouldn't be handled by Hise, instead of rounding the bars in script?

[clevername27]

@Christoph-Hart Thank you - understood.

[gorangrooves]

@Christoph-Hart I want to provide further info regarding the bug @ustk demonstrated in the video above, regarding the double triggering of the same note when a MIDI file loops.

The dual kick notes (#36/C1) happen on beat 1 of the 2nd play through the loop, when the tempo is set to 120bpm and 160bpm.
If the tempo is set to 80bpm, the dual kick note plays on beat 1 of the 4th repeat.
If the tempo is set to 240bpm, the dual kick note plays on beat 1 of the 3rd repeat. Other tempos seem OK.

I don't know if the issue is present on any other notes, but it is definitely there on C1.

And just to clarify, @ustk did not fix the bug, as it may seem from his previous answer.

[ulrik]

@ustk said in MIDI Player/Transport bugs & info requests:

A strange thing the files don't contain an EndOfTrack meta-message since it is stated by the midi normalisation and they are exports from different DAWs... I couldn't find a tool to show me what's aside from the on/off notes and controllers.

I found this tool (MacOS), and opened one of you midi files

Synalyze it

It will show the end of track info

Did you manage to get Hise Midi Player to read the End of track data?

[ustk]

@ulrik Thanks mate! So I tried and the EndOfTack event is present in all the files I have...

@Christoph-Hart Why is the NumBars metadata always throwing a length that corresponds to the last note off?
Bug or misunderstanding?

[Christoph Hart]

@ustk because the JUCE Midifile parser seems to ignore that value.

[ustk]

@Christoph-Hart The note that is triggered twice when looping is still not resolved.
Here's the related post that demonstrates the issue: https://forum.hise.audio/topic/7311/midi-player-transport-bugs-info-requests/21

[gorangrooves]

@Christoph-Hart I was chatting with @ustk about workarounds for the issue where HISE shortens MIDI files by a beat, when playing them once. 4/4 becomes 3/4. (It only plays correctly when looping).

Here is the thing: even if I were to modify and re-export all of my MIDI files (several thousand) to have a note off at the very end of a MIDI file, it would leave countless regularly-exported MIDI files by other users not properly-playable by a HISE player.

Keep in mind that simple players like Windows Media Player will play all MIDI files with the correct length, so this is really a HISE bug that I strongly feel should be resolved in the source.

Do you think you could please examine how HISE handles playback of MIDI files (single play, not looping) and provide a fix so that the entire length of a bar plays fully?

[ustk]

@gorangrooves So this has been fixed here:
https://forum.hise.audio/topic/7581/still-trying-to-make-sense-of-tempo-sync-and-midi-loop-issue/19

[gorangrooves]

@ustk that's fantastic news! Thanks @Christoph-Hart

Apologies for me being a bit late to the party