Widget of the Day for Y'all
-
Looks nice. I noticed two issues.
You're including a font from the project folder, if the user doesn't have that then the script will fail to compile.
You're using non-standard parameter names for you LAF function.
graphics
should beg
andwidget
should beobj
. The auto-complete doesn't work with those parameter names (not sure this affects theobj
parameter actually). I found this out myself years ago when usinge
instead ofevent
for mouse callbacks :)I've never seen
reg
variables declared inside a function. I don't know if there are any downsides/benefits to this... @Christoph-Hart ? -
@d-healey Hi David, thanks for your feedback. What do you recommend I do for the widest font compatibility?
-
@clevername27 A snippet should be self contained, so I wouldn't load any fonts inside it.
-
@clevername27 Just a little suggestion
But of course, I know you wrote this code for beginners. It is good to see how things can be reduced/simplifiedThis:
local componentBlue = colourArray[1]; componentBlue += brightnessAdjustment; if (componentBlue < 0.0) componentBlue = 0.0; if (componentBlue > 1.0) // would benefit from an else if statement here componentBlue = 1.0; colourArray[1] = componentBlue;
could be better written:
local componentBlue = colourArray[1]; componentBlue += brightnessAdjustment; colourArray[1] = Math.range(componentBlue, 0.0, 1.0);
Or even a one-liner
colourArray[1] = Math.range(colourArray[1] + brightnessAdjustment, 0.0, 1.0);
-
@clevername27 Like Dave I'm surprised to see the
reg
declarations inside the function. But if it's not an issue then I'm sure LAF functions in general will largely benefit from this increased variable speed!
Just a shame we can't nest namespaces because the 32reg
limit will be quickly reached in any small project if they're all in one unique LAF namespace... -
@ustk the limitation to 32 slots is one of the main reasons why they are so fast :)
-
@Christoph-Hart Sure! I wouldn't need more anyway... When I reach that number I always get back to another design because it means I overdid something... (By the way, it would be cool to have an alert when reaching the limitation because I already struggled multiple times to find the origin of a bug while I was simply having too many regs within a namespace )
And what about declaring them inside a LAF function like @clevername27 did?
-
@d-healey Thank you - I simply don't know how to do that with fonts, could you please tell me?
-
@Christoph-Hart Are these literally register variables?
-
@ustk yes good idea, I‘ll make it throw an error (no idea why I didn‘t do this earlier, lol)
-
@clevername27 said in Widget of the Day for Y'all:
@Christoph-Hart Are these literally register variables?
no, there are about 20 layers of abstraction between these variables and the CPU registers…
-
@ustk I've added your code as a comment - thank you.
-
@d-healey Thank you for your suggestion - I've revised the code to use 'g' and "obj".
-
@clevername27 said in Widget of the Day for Y'all:
@d-healey Thank you - I simply don't know how to do that with fonts, could you please tell me?
You can't, if you load a font in your snippet then the user must have that font. So don't use them in snippets.
-
@d-healey How do I draw text then - don't I have to specify some font?
-
@clevername27
loadFontAs
but just give the name of an embedded font (that you can find in the property of a Label)
If you just want to draw a text for an example snippet, just do:g.setFont("Arial", 14.0); // or whatever embedded font
inside a paint routine (or LAF function), you don't even need to loadFontAs...
And if you just ignore this line, a default font will be used anyway so you don't even have to bother setting a font (but then you lose the ability to set its size) -
How do I draw text then - don't I have to specify some font?
If you don't call
g.setFont()
, it will default to Arial or whatever is the standard font.For a "real" project, I would always embed the fonts, but if you want to pass around snippets that need to be self-contained, you can just assume that the user has installed the font on his system and if it isn't found, it will fall back to Arial (or Comic Sans MS on April 1st).
-
@Christoph-Hart said in Widget of the Day for Y'all:
(or Comic Sans MS on April 1st).
-
@clevername27 said in Widget of the Day for Y'all:
@d-healey How do I draw text then - don't I have to specify some font?
No need to specify a font at all, it will use the default
-
Thank you, everyone. Fonts sorted.