Develop branch cannot support more than 19 scripts

[Lindon]

@d-healey - OK well "good " news there - its crashing in the same way as my version of HISE....

[d.healey]

@lindon Have you tested on MacOS?

[Lindon]

@d-healey not yet.

[d.healey]

@lindon Good news (sort of) is I get an instant crash too (on Debian). Now to debug :)

[d.healey]

First error I get {PROJECT_FOLDER}backgroundBass.png wasn't found. I doubt this is the cause of the crash though.

[d.healey]

I see some UI updates from the MIDI callback but they haven't been deferred. I don't think this is the cause of the crash either because those callbacks aren't triggered when loading the project, but it might be something to look into.

I managed to bypass everything in a debug build and I'm able to open it in the release build. Now I'm enabling things bit by bit to see if I can narrow down the crash.

[Lindon]

@d-healey said in Develop branch cannot support more than 19 scripts:

backgroundBass.png

huh -- I cant find a reference to backgroundBass.png anywhere....

[d.healey]

@lindon

[Lindon]

@d-healey said in Develop branch cannot support more than 19 scripts:

I see some UI updates from the MIDI callback but they haven't been deferred. I don't think this is the cause of the crash either because those callbacks aren't triggered when loading the project, but it might be something to look into.

I managed to bypass everything in a debug build and I'm able to open it in the release build. Now I'm enabling things bit by bit to see if I can narrow down the crash.

yep sure -- can you point at them to save me looking for them?

[d.healey]

@lindon said in Develop branch cannot support more than 19 scripts:

can you point at them to save me looking for them?

Yep will do.

[Lindon]

@d-healey meanwhile I'm going in the complete opposite direction and rebuilding from the ground up .....

So far I've re-set up all the backend sound sources and fx and rebuilt the UI, I've found:

-- only that HISE develop doesn't seem to like Slot FX very much (or copying them around anyway..)

[Lindon]

@lindon said in Develop branch cannot support more than 19 scripts:

@d-healey meanwhile I'm going in the complete opposite direction and rebuilding from the ground up .....

So far I've re-set up all the backend sound sources and fx and rebuilt the UI, I've found:

-- only that HISE develop doesn't seem to like Slot FX very much (or copying them around anyway..)

....and I started adding in the scripts ... leaving the interface script until last....

they all work fine right up until I add the rangefilter scripts, and it crashes....

Here's the contents of the range filter scripts:

const var LowRange = Content.addKnob("LowRange", 0, 0);
LowRange.setRange(0, 126, 1);
const var HighRange = Content.addKnob("HighRange", 150, 0);
HighRange.setRange(1, 127, 1);
const var FadeButton = Content.addButton("FadeButton", 300, 12);

const var SubMults = [0.7,0.65,0.6,0.5,0.4,0.3,0.25,0.2,0.1,0.05,0.025,0.0125,0.0125];
SubMults.reserve(15);

function onNoteOn()
{
    //Console.print(Message.getNoteNumber());
    if (FadeButton.getValue() == 0)
    {
        // not fading out strictly cutting off
        if(Message.getNoteNumber() < LowRange.getValue() || Message.getNoteNumber() > (HighRange.getValue()))
        {
            Message.ignoreEvent(true);
        }
    }else{
        //cut things outside the fade ranges...
        if(Message.getNoteNumber() < LowRange.getValue()-12 || Message.getNoteNumber() > (HighRange.getValue()+12))
        {
            // outside everything - just cut.
	        Message.ignoreEvent(true);
        }
        if (Message.getNoteNumber() > HighRange.getValue() && Message.getNoteNumber() <= (HighRange.getValue()+12))
        {
            // in the high range fade range
            Message.setVelocity(Message.getVelocity()* SubMults[Message.getNoteNumber() - HighRange.getValue()]);
        }
        if (Message.getNoteNumber() < LowRange.getValue() && Message.getNoteNumber() >= (LowRange.getValue()-12))
        {
            // in the low range fade range
            Message.setVelocity(Message.getVelocity()* SubMults[LowRange.getValue() - Message.getNoteNumber() ]);
        }
        
    }
	    
}
 function onNoteOff()
{
    if (FadeButton.getValue() == 0)
    {
        // no fade just cut
	    if(Message.getNoteNumber() < LowRange.getValue() || Message.getNoteNumber() > (HighRange.getValue()+12))
	        Message.ignoreEvent(true);
    }else{
        // is it outside all fading ranges?
        if(Message.getNoteNumber() < LowRange.getValue()-12 || Message.getNoteNumber() > (HighRange.getValue()+12))
	        Message.ignoreEvent(true);
    }
	    
}
 function onController()
{
	
}
 function onTimer()
{
	
}
 function onControl(number, value)
{
	
}
 

-- nothing is jumping out at me....

[d.healey]

@lindon I don't see anything unusual there. I'm off to cook dinner but I'll dig a bit deeper when I'm back.

[Lindon]

@d-healey --and now just like every other version its crashing no matter what I do to it.....grrrrrrrrrrrrrrrrrrrrrrrrr

[ustk]

@Lindon I don’t know if it’ll have an impact but instead of calling things multiple times I would store the note number in a reg, and same thing for the range values

[Lindon]

@ustk what?

[Lindon]

@d-healey said in Develop branch cannot support more than 19 scripts:

@lindon I don't see anything unusual there. I'm off to cook dinner but I'll dig a bit deeper when I'm back.

Yeah I have to call it quits for today too?

[Lindon]

@lindon said in Develop branch cannot support more than 19 scripts:

@ustk what? er we are talking about using multiple scripts (one per voice) so its more modular...

[d.healey]

@ustk said in Develop branch cannot support more than 19 scripts:

I would store the note number in a reg

You can use a local in the MIDI callbacks, I don't know if this is better than a reg...

[ustk]

@d-healey For what I understand a reg is faster, hence more suitable for real-time stuff...