Expansion encode error

[David Healey]

You have to clear out the combobox before you can re-add the items, this is a long standing quirk (although I thought it had been fixed).

ExpansionSelector.set("items", "");
ExpansionSelector.set("items", expansionNames.join("\n"));

[David Healey]

@d-healey said in Expansion encode error:

although I thought it had been fixed)

Yep it has been fixed so that's probably not the issue.

HiseSnippet 896.3ocsV8+RaCDE+R0SVxlhB6OfP+oJzIo0pafLlqUcT1TKqNYfSjyjq1albWI4hyxPX+x9+c+CL1dujzznV5zBK+PHuu+48t26coSnxkGEoBIFlGMb.mX7LZ2gRc+V8YBIo8NDikn6yhz7P6TVMGNfEEw8HFFy8Njgg47jjme8llLelzkOlEgbrR3x+fHPnGysy1uW36uGyiejHnf1M1tsqR1R4qhA7LG0gLf4dI6B9ALTsRThwB65IzpvtZllGA5zT4Mrae02jo5erHRbtOGIpQ5BNJkMoUeguWmQ4ZDgXLemwY9boY9yo6K7D47GWAVNQf8XKJVCLJMMHU6Q.IiBPZ9THsBsqanXfdrDDOOk1VBGH8XPotHTR0kT5jRzVJPCods.1k78BAhbKproiSUa30paYYAk6HssuHRWy901mTqpc8p1qW0tQU6M.kNcqBZTOQCz353q0wWMvWa33bZtuthAMJpfyUMUWi9bDPtfqA1CTRfnR4bMJCnHmXsHNHSn4AQkqlhp09pRHqT9Kxxqh3UH8ERtcuXoqVnj1JYyXsVIqggIT4WwcTLpBHwOlup02sLE8rqjQYZ9vilI2OhOcKpeaKtAf3jS3LXVdUzGYfsEy2+bnAuxcyBvSExvCTZ9gxJIYh0MV12UTudSTVlu74gSTLN4ENMCqHiCNmGVrNhJBsl2teegGV+taZYofhJYaoPe3.dF8dJeOrOF+99SGjr5JNmjgPPUcxTxxYSIiNnHBObHI+bijjBE2JQ9T6cXZ1HmA9Eh0.dnVfojwN7qfsVoiflzc3QWpUCfEP4GnPZ+.C804g8Gmr8vwX3nsCXfLpwB.QRKEwXQZMq5Vqa0vZCqMwLNOZzznsTVzRaWRhkIMq2gj3seBdaH9wugOhXWwaK6DxgdNb+.49KXfUaJuXel9166vE6YBflhasjAWjHiD5gEW7+HVB5L0kfOTHtBsiP61exXrzDvHbT++.iYWcrHc2d83t5w.bd5dedVum3eD9Oph0B4E6yzgB7P+f3ftvMltbH5RIrzBO+KgiLozNHMVA5xkdID+AdxDVCoMxDVajPR.yMTcla5fFd4zSR3.XRlbWrI7SA.sc9rEk5rlCI.tm7LWWL8eALEOYapOC1r9LXSiYvlMlAa1bFr4kyfMuZp1f+hxai0pfzwAfQmcS1wYXrqjAcVIcgj+9Mty1N

I see you're pushing values to an array called expansionNames where is this array declared? Have you cleared the array before pushing more values to it?

Also your if statement and for loop are missing curly braces!

[DanH]

@d-healey said in Expansion encode error:

Yep it has been fixed so that's probably not the issue.

I'm in master so it quite possibly is....

[David Healey]

@danh said in Expansion encode error:

I'm in master so it quite possibly is....

Yes probably not fixed in master, but your lack of curly braces won't help :)

[DanH]

@d-healey thanks for your help on this :)

So it kinda worked, but it seems to be repeating the list rather than clearing it and starting again. More precisely: I have one expansion installed already, I install the second and the list comes out as:

Exp1
Exp2
Exp1

Which is weird. Are my braces right?!

function(ok)
        {
            if(ok)
            {
                 expHandler.refreshExpansions();
                 pnlProgress.showControl(0);
            }
                 //expHandler.setCurrentExpansion();
                 for(e in expHandler.getExpansionList())
            {
    expansionNames.push(e.getProperties().Name);
    ExpansionSelector.set("items", "");
    ExpansionSelector.set("items", expansionNames.join("\n"));
            }
        });

[David Healey]

@danh

Are my braces right?!

Do you want the loop inside the if statement?

[DanH]

@d-healey doesn't seem to make a difference where I put it... It always doubles up.

So I set the combo box names in the oninit, and then I'm doing it again in the expansion installer, but somehow it's doubling up despite ExpansionSelector.set("items", "");....

[David Healey]

@DanH Go look at my post from a couple of hours ago.

I see you're pushing values to an array called expansionNames... Have you cleared the array before pushing more values to it?

[DanH]

@d-healey oh I’m clearing the list only…. How does one clear an array? Just array == []?

[David Healey]

@danh said in Expansion encode error:

Just array == []?

Yes, or arrayName.clear()

[DanH]

@d-healey that did it, thanks!