Expansion User Presets

[d.healey]

@arminh You're mixing a few things. Loading sample maps, changing presets, and expansion are all separate.

We need to narrow down exactly what the problem is that you have found. Firstly you should test with the latest version of scriptnode branch, since that's the one Christoph will be working on and updating.

Expansions seem to be totally broken at the moment so don't worry about that for now.

Christoph has already mentioned that he'll fix the issue with presets not being recalled in the preset browser so we don't need to worry about that.

So the sample map issue is the only thing we need to work on at the moment. But first you need to test with the latest build.

@Dalart said in Expansion User Presets:

I'm a bit out of the loop, has expansions been fixed ?

Nope :(

[Dalart]

@d-healey Ok, i'll try to keep an eye out for when it is. Thanks.

[arminh]

@d-healey said in Expansion User Presets:

But first you need to test with the latest build.

yeah, but latest build crashes when i trying create expansion folder. I guess you haven't checked the latest version?

I checked latest version and it's not working. I created manually folder for expansion but HISE don't recognize this as expansion. I even create expansion folder in older version a copy to new and still without success.

[d.healey]

yeah, but latest build crashes when i trying create expansion folder. I guess you haven't checked the latest version?

Doesn't matter. Expansions aren't the problem. The problem you have is sample maps, so make a demo project that reproduces the sample maps issue without any reference to expansions or presets.

[coreyu21]

@d-healey the main issue I’ve seen with moving forward with the expansion system is the same issue of the combo box not saving the Expansion chosen for the user preset box to load the correct preset. The combo box resets itself on load. I thought we’ve talked about this before. The user when using the plugin needs to choose their expansion and use the presets. Save the project. And when reloaded by the user, the plugin goes to the expansion that was previously loaded.

Currently the combo box used to choose expansion resets itself when save in preset is checks resulting in the loop error I’m guessing. This fix would enable me to actually use the expansion system instead of the workaround mess I have currently.

[arminh]

I agree with you. User will not remember what sound he used in certain project.

[d.healey]

@arminh said in Expansion User Presets:

loaded plugin in DAW and selected sample map. I saved DAW project and reopen app. I loaded project and ... combo box with sample maps loaded first item and when i hit a note i hear nothing.

This is the problem we are trying to solve (first), it has nothing to do with expansion or with presets. It's about his sample map not being loaded when he reopens the DAW. It might turn out that the problem goes away once we remove the expansion/preset element of the program in which case the above quoted problem is not the problem at all, but first we have to isolate the issue to check what is really causing it.

[Christoph Hart]

This is most likely a glitch because of the expansions or a user fault (wrongly scripted). Samplemaps will definitely restore when you load a DAW project, that's one of the most basic functions.

[arminh]

@Christoph-Hart ok so if you think it might be scirpt issue please check it and tell me is something wrong

Content.makeFrontInterface(600, 500);

const var expansions = Engine.getExpansionList();
const var expansionNames = [];
var sampleMaps;

const var Sampler = Synth.getSampler("Sampler");
 
for (e in expansions){
    var p = e.getProperties();
    expansionNames.push(p.Name);
}


//cmbExpansions
const var cmbExpansions = Content.getComponent("cmbExpansions");
cmbExpansions.set("items", expansionNames.join("\n"));

inline function oncmbExpansionsControl(component, value)
{
    Engine.setCurrentExpansion(component.getItemText());
    sampleMaps = expansions[value-1].getSampleMapList();
    cmbSampleMap.set("items", "");
	cmbSampleMap.set("items", sampleMaps.join("\n"));
};

Content.getComponent("cmbExpansions").setControlCallback(oncmbExpansionsControl);

//cmbSampleMap
const var cmbSampleMap = Content.getComponent("cmbSampleMap");


inline function oncmbSampleMapControl(component, value)
{
	Sampler.loadSampleMap(sampleMaps[value-1] + ".xml");
	//Console.print();
};

Content.getComponent("cmbSampleMap").setControlCallback(oncmbSampleMapControl);

[coreyu21]

@Christoph-Hart the sample maps do actually restore but the expansion box doesn’t restore making the sample maps not pop up in the user preset browser. Therefore you cannot load your saved samplemap because the expansion selected isn’t being saved in preset That’s the issue I’ve been running into

[coreyu21]

@Christoph-Hart im also assuming the percX expansion system when complete will resolve these minor issues?.. can’t wait

[arminh]

@coreyu21 oh i cant wait for this