Collaborative project!
-
@ustk shoul be linear. not logarithmic as gain is...... I guess
-
@hisefilo The issue is that the knobs are necessarily linear. But if you just apply a factor 100 to it and map it as gain, the dB scale is not respected.
If you test your code above (mine has the same issue), we begin to hear a tone only from the midpointWe need to use a
valueNormalizedapplied to a dummy knob set in decibel, so it will convert to the right scale for us. I remember having this issue and that's what Christoph suggested. -
@ustk yepp that sounds good. you nailed it
-
@hisefilo I pushed it if you want to test...
-
@ustk after dinner will do
-
@hisefilo So see you tomorrow! 2am here
-
@ustk @lalalandsynth @d-healey a pleasure to work with u guys. tomorrow is the day
-
@ustk morning!!! gain is working fine on drawers :)
-
well we are ready. Only thing left is background render and knobs/sliders filmstrips @lalalandsynth and we will compile and test (and record some blues for demos :)
-
@hisefilo @lalalandsynth I was thinking to find a more precise rule (like the original) for the drawbars gain factors.
And I simply found it's a mere -3dB rule for all positions, plus -inf for the last one...I replaced the hacky mapping knob for a lookup table, so it should be more consistent and closer to the original.
Have a listen and tell me ;) -
@ustk I was thinking in that. A table. :) it's perfect in my opinion
-
@lalalandsynth mate are you ok? are you going to send the renders?
-
Hi guys , had to go to real life work today . Just got back.
Pulling now, I guess leave it alone until i deliver the graphics ?When graphics are applied to do I just commit to master ?
-
@lalalandsynth :) yep. just commit to master!
-
There is a percHarmKnob with three settings ?
And a Keyclick switch ?I might have misunderstood , in my model its one switch to turn on the perc and one switch to select 2nd and 3rd harmonic .
And I have not implemented a keyclick switch ?
Just so we are on the same page , there is perc setting with 2nd and 3rd and ALSO a keyclick switch in the plugin ? So basically we need to change the 3 setting switch to be 2 switches , on for off/on perc and one for 2nd 3rd and I need to make a Keyclikc switch ?
Also , the order of drawbars is supicious , its KnobDrawBar1 , KnobDrawBar3 and KnobDrawBar2? I will assume that is a mistake and will order them sequentially , just læooked at the drawBars script and its safe to assume that is was not lined up correctly in the project.
-
@lalalandsynth that s right. just link perc on of to keyclick. and I will later change the switch to just 2 positions.
drawbar order is ok. 2nd comes after 3rd (Hammond placed harmonics that way I don't know why)
-
@hisefilo So the order of drawbars in the gui should be 1 , 3, 2 ?
-
@lalalandsynth yes!!
-
@lalalandsynth just keep it as is now. they are placed already the way they should be
-
@hisefilo Sure , just was not sure if it was a mistake
