Collaborative project!

[hisefilo]

@ustk @lalalandsynth sliders are already inverted. So just inverting the strip as @ustk said will do the trick

inline function onKnobDrawbar4Control(component, value)
{
	SimpleGainMain4.setAttribute(SimpleGainMain4.Gain, 100 * (1 - value) - 100);
};

[ustk]

@hisefilo I simplified the code and made it compatible for step behavior.
Pull the git if you wanna have a look :)

[ustk]

@hisefilo Also the skew factor is fucked up because the knob doesn't respect a log curve. The result is that we hear the sound only between pos 5 and 8, nothing before. Will check if a valueNormalized can help...

[hisefilo]

@ustk shoul be linear. not logarithmic as gain is...... I guess

[ustk]

@hisefilo The issue is that the knobs are necessarily linear. But if you just apply a factor 100 to it and map it as gain, the dB scale is not respected.
If you test your code above (mine has the same issue), we begin to hear a tone only from the midpoint

We need to use a valueNormalized applied to a dummy knob set in decibel, so it will convert to the right scale for us. I remember having this issue and that's what Christoph suggested.

[hisefilo]

@ustk yepp that sounds good. you nailed it

[ustk]

@hisefilo I pushed it if you want to test...

[hisefilo]

@ustk after dinner will do

[ustk]

@hisefilo So see you tomorrow! 2am here

[hisefilo]

@ustk @lalalandsynth @d-healey a pleasure to work with u guys. tomorrow is the day

[hisefilo]

@ustk morning!!! gain is working fine on drawers :)

[hisefilo]

well we are ready. Only thing left is background render and knobs/sliders filmstrips @lalalandsynth and we will compile and test (and record some blues for demos :)

[ustk]

@hisefilo @lalalandsynth I was thinking to find a more precise rule (like the original) for the drawbars gain factors.
And I simply found it's a mere -3dB rule for all positions, plus -inf for the last one...

I replaced the hacky mapping knob for a lookup table, so it should be more consistent and closer to the original.
Have a listen and tell me ;)

[hisefilo]

@ustk I was thinking in that. A table. :) it's perfect in my opinion

[hisefilo]

@lalalandsynth mate are you ok? are you going to send the renders?

[lalalandsynth]

Hi guys , had to go to real life work today . Just got back.
Pulling now, I guess leave it alone until i deliver the graphics ?

When graphics are applied to do I just commit to master ?

[hisefilo]

@lalalandsynth :) yep. just commit to master!

[lalalandsynth]

@hisefilo

There is a percHarmKnob with three settings ?
And a Keyclick switch ?

I might have misunderstood , in my model its one switch to turn on the perc and one switch to select 2nd and 3rd harmonic .

And I have not implemented a keyclick switch ?

Just so we are on the same page , there is perc setting with 2nd and 3rd and ALSO a keyclick switch in the plugin ? So basically we need to change the 3 setting switch to be 2 switches , on for off/on perc and one for 2nd 3rd and I need to make a Keyclikc switch ?

Also , the order of drawbars is supicious , its KnobDrawBar1 , KnobDrawBar3 and KnobDrawBar2? I will assume that is a mistake and will order them sequentially , just læooked at the drawBars script and its safe to assume that is was not lined up correctly in the project.

[hisefilo]

@lalalandsynth that s right. just link perc on of to keyclick. and I will later change the switch to just 2 positions.

drawbar order is ok. 2nd comes after 3rd (Hammond placed harmonics that way I don't know why)

[lalalandsynth]

@hisefilo So the order of drawbars in the gui should be 1 , 3, 2 ?