Forum
    • Categories
    • Register
    • Login

    Sample archive extraction total progress fix

    Scheduled Pinned Locked Moved Bug Reports
    expansionsamplehr fileinstallation
    2 Posts 2 Posters 31 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • David HealeyD
      David Healey
      last edited by David Healey

      I noticed in the expansion handler's install callback that the (undocumented) TotalProgress value is wrong, it caps out at about 0.4.

      Poking around in the code I spotted that it seems to just be tracking the reading of the first bit of the file. The actual decompressing/writing progress wasn't contributing to the total progress value at all.

      I've made a PR that has TotalProgress tracking the decompressed bytes instead. This gives much more pleasing results. I've tested it with single and multi-part hr archives.

      Free HISE Bootcamp Full Course for beginners.
      YouTube Channel - Public HISE tutorials
      My Patreon - HISE tutorials

      dannytaurusD 1 Reply Last reply Reply Quote 4
      • dannytaurusD
        dannytaurus @David Healey
        last edited by

        @David-Healey Looking forward to getting into expansions. Glad you're around for questions! 😂

        Meat Beats: https://meatbeats.com
        Klippr Video: https://klippr.video

        1 Reply Last reply Reply Quote 0
        • First post
          Last post

        20

        Online

        2.1k

        Users

        13.1k

        Topics

        113.6k

        Posts