• Dark Theme
    • Categories
    • Register
    • Login
    HISE Logo Forum
    • Categories
    • Register
    • Login

    Midilist and -1

    Scheduled Pinned Locked Moved General Questions
    27 Posts 3 Posters 1.1k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • U
      ustk @d.healey
      last edited by 22 Sept 2021, 15:36

      @d-healey I wanted to say I'll do it this way from now, but it's even better if I can reformat this last pull request. Never done that though so let me check ;)

      Can't help pressing F5 in the forum...

      D 1 Reply Last reply 22 Sept 2021, 15:38 Reply Quote 0
      • D
        d.healey @ustk
        last edited by 22 Sept 2021, 15:38

        @ustk Start making branches and cherry-pick the commits from your develop branch, then delete your current pull request.

        Libre Wave - Freedom respecting instruments and effects
        My Patreon - HISE tutorials
        YouTube Channel - Public HISE tutorials

        U 2 Replies Last reply 22 Sept 2021, 15:40 Reply Quote 0
        • U
          ustk @d.healey
          last edited by 22 Sept 2021, 15:40

          @d-healey said in Midilist and -1:

          then delete your current pull request.

          This is what I'm looking for... how?

          Can't help pressing F5 in the forum...

          1 Reply Last reply Reply Quote 0
          • U
            ustk @d.healey
            last edited by 22 Sept 2021, 15:41

            @d-healey I closed it, is that good?

            Can't help pressing F5 in the forum...

            D 1 Reply Last reply 22 Sept 2021, 15:41 Reply Quote 0
            • D
              d.healey @ustk
              last edited by 22 Sept 2021, 15:41

              @ustk Yeah

              Libre Wave - Freedom respecting instruments and effects
              My Patreon - HISE tutorials
              YouTube Channel - Public HISE tutorials

              U 3 Replies Last reply 22 Sept 2021, 15:43 Reply Quote 0
              • U
                ustk @d.healey
                last edited by 22 Sept 2021, 15:43

                @d-healey Ok. There's still a "delete branch" button but I'm a bit afraid of this one...
                I already fucked up my develop a few days ago, so never be stupid twice the same week :)

                Can't help pressing F5 in the forum...

                1 Reply Last reply Reply Quote 0
                • U
                  ustk @d.healey
                  last edited by 22 Sept 2021, 15:52

                  @d-healey Ok so the thing now is that I still have all the commits in my develop. So I have to be careful not to make a pull request from develop until Christoph merges the separate ones.

                  Can't help pressing F5 in the forum...

                  1 Reply Last reply Reply Quote 0
                  • U
                    ustk @d.healey
                    last edited by 22 Sept 2021, 15:55

                    @d-healey No in fact it's not as easy. Obviously I can't create a branch based on develop until I removed all these commits from it. And I'd prefer a delete over a dirty revert so I'll try to delete them first.

                    Can't help pressing F5 in the forum...

                    D 1 Reply Last reply 22 Sept 2021, 16:02 Reply Quote 0
                    • D
                      d.healey @ustk
                      last edited by 22 Sept 2021, 16:02

                      @ustk Give me a few minutes and I'll give you a solution

                      Libre Wave - Freedom respecting instruments and effects
                      My Patreon - HISE tutorials
                      YouTube Channel - Public HISE tutorials

                      1 Reply Last reply Reply Quote 0
                      • D
                        d.healey
                        last edited by 22 Sept 2021, 16:07

                        You can make a new branch based on any commit hash, or just based on Christoph's latests develop branch.

                        Libre Wave - Freedom respecting instruments and effects
                        My Patreon - HISE tutorials
                        YouTube Channel - Public HISE tutorials

                        U 1 Reply Last reply 22 Sept 2021, 16:43 Reply Quote 1
                        • U
                          ustk @d.healey
                          last edited by 22 Sept 2021, 16:43

                          @d-healey Yeah new branch from a specific commit is the way to go. But I have a freakin authentication issue now, the git api messed up the authentication so the Desktop app is blocked too 🙄
                          You'll have to wait for me to fix this then after that I'll make the pull requests

                          Can't help pressing F5 in the forum...

                          D 1 Reply Last reply 22 Sept 2021, 16:46 Reply Quote 0
                          • D
                            d.healey @ustk
                            last edited by 22 Sept 2021, 16:46

                            @ustk

                            You'll have to wait for me to fix this then after that I'll make the pull requests

                            No rush. It's always a pain setting up a new workflow like this but once you get it it makes things easier :)

                            Libre Wave - Freedom respecting instruments and effects
                            My Patreon - HISE tutorials
                            YouTube Channel - Public HISE tutorials

                            U 1 Reply Last reply 22 Sept 2021, 17:15 Reply Quote 0
                            • U
                              ustk @d.healey
                              last edited by 22 Sept 2021, 17:15

                              @d-healey That's done :) although because I had n older commit, it is showing up in the pull request. I realized I could even base the new branches on an even older commit but it's too late... It'll be easier next time when my origin will be even with the upstream.

                              Can't help pressing F5 in the forum...

                              D 1 Reply Last reply 22 Sept 2021, 17:16 Reply Quote 1
                              • D
                                d.healey @ustk
                                last edited by 22 Sept 2021, 17:16

                                @ustk My solution is to always branch from Christoph's develop branch, that way it doesn't matter how messed up my own fork is.

                                Libre Wave - Freedom respecting instruments and effects
                                My Patreon - HISE tutorials
                                YouTube Channel - Public HISE tutorials

                                1 Reply Last reply Reply Quote 1
                                • S
                                  Shannon Burns
                                  last edited by 23 Sept 2021, 22:49

                                  I believe the desktop version may have it as well; I only recently discovered it. Cherry-pick allows you to separate each pull request into its own branch, ensuring that no changes you make are added to the same pull request.

                                  U 1 Reply Last reply 24 Sept 2021, 10:20 Reply Quote 0
                                  • U
                                    ustk @Shannon Burns
                                    last edited by 24 Sept 2021, 10:20

                                    @Shannon-Burns Yes GitHub Desktop has cherry-pick. That's what @d-healey explained to me above about new branches for pull requests that I'd never thought of...

                                    Can't help pressing F5 in the forum...

                                    1 Reply Last reply Reply Quote 0
                                    21 out of 27
                                    • First post
                                      Last post

                                    32

                                    Online

                                    1.9k

                                    Users

                                    10.8k

                                    Topics

                                    94.3k

                                    Posts