HISE Logo Forum
    • Categories
    • Register
    • Login

    Midilist and -1

    Scheduled Pinned Locked Moved General Questions
    27 Posts 3 Posters 1.4k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • ustkU
      ustk @d.healey
      last edited by

      @d-healey I closed it, is that good?

      Can't help pressing F5 in the forum...

      d.healeyD 1 Reply Last reply Reply Quote 0
      • d.healeyD
        d.healey @ustk
        last edited by

        @ustk Yeah

        Libre Wave - Freedom respecting instruments and effects
        My Patreon - HISE tutorials
        YouTube Channel - Public HISE tutorials

        ustkU 3 Replies Last reply Reply Quote 0
        • ustkU
          ustk @d.healey
          last edited by

          @d-healey Ok. There's still a "delete branch" button but I'm a bit afraid of this one...
          I already fucked up my develop a few days ago, so never be stupid twice the same week :)

          Can't help pressing F5 in the forum...

          1 Reply Last reply Reply Quote 0
          • ustkU
            ustk @d.healey
            last edited by

            @d-healey Ok so the thing now is that I still have all the commits in my develop. So I have to be careful not to make a pull request from develop until Christoph merges the separate ones.

            Can't help pressing F5 in the forum...

            1 Reply Last reply Reply Quote 0
            • ustkU
              ustk @d.healey
              last edited by

              @d-healey No in fact it's not as easy. Obviously I can't create a branch based on develop until I removed all these commits from it. And I'd prefer a delete over a dirty revert so I'll try to delete them first.

              Can't help pressing F5 in the forum...

              d.healeyD 1 Reply Last reply Reply Quote 0
              • d.healeyD
                d.healey @ustk
                last edited by

                @ustk Give me a few minutes and I'll give you a solution

                Libre Wave - Freedom respecting instruments and effects
                My Patreon - HISE tutorials
                YouTube Channel - Public HISE tutorials

                1 Reply Last reply Reply Quote 0
                • d.healeyD
                  d.healey
                  last edited by

                  You can make a new branch based on any commit hash, or just based on Christoph's latests develop branch.

                  Libre Wave - Freedom respecting instruments and effects
                  My Patreon - HISE tutorials
                  YouTube Channel - Public HISE tutorials

                  ustkU 1 Reply Last reply Reply Quote 1
                  • ustkU
                    ustk @d.healey
                    last edited by

                    @d-healey Yeah new branch from a specific commit is the way to go. But I have a freakin authentication issue now, the git api messed up the authentication so the Desktop app is blocked too 🙄
                    You'll have to wait for me to fix this then after that I'll make the pull requests

                    Can't help pressing F5 in the forum...

                    d.healeyD 1 Reply Last reply Reply Quote 0
                    • d.healeyD
                      d.healey @ustk
                      last edited by

                      @ustk

                      You'll have to wait for me to fix this then after that I'll make the pull requests

                      No rush. It's always a pain setting up a new workflow like this but once you get it it makes things easier :)

                      Libre Wave - Freedom respecting instruments and effects
                      My Patreon - HISE tutorials
                      YouTube Channel - Public HISE tutorials

                      ustkU 1 Reply Last reply Reply Quote 0
                      • ustkU
                        ustk @d.healey
                        last edited by

                        @d-healey That's done :) although because I had n older commit, it is showing up in the pull request. I realized I could even base the new branches on an even older commit but it's too late... It'll be easier next time when my origin will be even with the upstream.

                        Can't help pressing F5 in the forum...

                        d.healeyD 1 Reply Last reply Reply Quote 1
                        • d.healeyD
                          d.healey @ustk
                          last edited by

                          @ustk My solution is to always branch from Christoph's develop branch, that way it doesn't matter how messed up my own fork is.

                          Libre Wave - Freedom respecting instruments and effects
                          My Patreon - HISE tutorials
                          YouTube Channel - Public HISE tutorials

                          1 Reply Last reply Reply Quote 1
                          • S
                            Shannon Burns
                            last edited by

                            I believe the desktop version may have it as well; I only recently discovered it. Cherry-pick allows you to separate each pull request into its own branch, ensuring that no changes you make are added to the same pull request.

                            ustkU 1 Reply Last reply Reply Quote 0
                            • ustkU
                              ustk @Shannon Burns
                              last edited by

                              @Shannon-Burns Yes GitHub Desktop has cherry-pick. That's what @d-healey explained to me above about new branches for pull requests that I'd never thought of...

                              Can't help pressing F5 in the forum...

                              1 Reply Last reply Reply Quote 0
                              • First post
                                Last post

                              47

                              Online

                              1.7k

                              Users

                              11.7k

                              Topics

                              101.8k

                              Posts