Expansions / Combo Box + SampleMaps

[DanH]

@d-healey No that just hides the expansion column

Using a combo box to switch into an expansion the expansion presets load fine, but when switching back to factory (selecting no expansion in the combo box) the 'factory' user presets don't come back - it stays on the last expansion's presets.

[d.healey]

@DanH Aha, let me test this on my system to see if I can find a solution

[d.healey]

I can confirm it doesn't work. I don't think a wrapper function is the best idea in this case. I think getting the preset browser to refresh itself when an empty expansion is loaded is the best thing. This means it will work automatically as it should without requiring a manual function call.

[DanH]

@d-healey Ok thanks loads for looking into it. Is there a refresh function for the PB currently? I couldn't see on in the APIs

[d.healey]

@DanH said in Expansions / Combo Box + SampleMaps:

Is there a refresh function for the PB currently? I couldn't see on in the APIs

No, and as I say we shouldn't need one. It should be automatic. It needs to be added to the source. I'm looking now to see if there is a quick fix.

[DanH]

@d-healey :folded_hands_light_skin_tone:

[d.healey]

Line 747 in PresetBrowser.cpp.

Replace the function there with this

void PresetBrowser::expansionPackLoaded(Expansion* currentExpansion)
{
	if(expansionColumn != nullptr && currentExpansion != nullptr)
		selectionChanged(-1, -1, currentExpansion->getRootFolder(), false);
	else
		selectionChanged(-1, -1, File(), false);
}

Or use my development branch https://github.com/davidhealey/HISE/tree/development

[DanH]

@d-healey said in Expansions / Combo Box + SampleMaps:

void PresetBrowser::expansionPackLoaded(Expansion* currentExpansion)
{
if(expansionColumn != nullptr && currentExpansion != nullptr)
selectionChanged(-1, -1, currentExpansion->getRootFolder(), false);
else
selectionChanged(-1, -1, File(), false);
}

Testing... It's line 737 in Master Branch for anyone else following..

[d.healey]

@DanH What crazy fool is using the master branch! :p

[DanH]

@d-healey Cos its stable! There's a few things in Develop that don't match up with what I've already made so waiting for things to be ironed out

[d.healey]

@DanH I've found develop to be more stable than master, especially with look and feel stuff. What parts have you found that are unstable?

[DanH]

@d-healey Well it began with tableprocessors but that's been fixed. Waiting for table laf to be enabled now plus I can't compile plugins on it yet but need to test more to find out why

[d.healey]

@DanH said in Expansions / Combo Box + SampleMaps:

Waiting for table laf to be enabled

Does that work on Master branch?

[ustk]

Plugins are compiling with develop branch. If it's not the case the issue's on your side.
But I heard some plugins exported from develop can be undetected by the DAW. This has to be confirmed though.

[DanH]

@d-healey yup. I did @ christoph in a post about it recently

I also find the editor (I know I can reset this) and the windows resizing to be a bit of a pain currently in Dev.

[d.healey]

@DanH Window resizing was fixed and the new editor is awesome, it just doesn't remember some settings properly yet :p

[ustk]

@DanH The more we are for testing, the more the bugs will be fixed :)

[DanH]

@ustk I'm dipping in and out :)

[DanH]

@d-healey works great :) Thank you! Worth pushing to Christoph?

[d.healey]

@DanH I already have an open pull request and everytime I add something it automatically gets added to it - https://github.com/christophhart/HISE/pull/192 - I have no idea how it works but it's a mess :p