Disable midi learn

[d.healey]

Okay by editing the HISE source it's pretty simple to add an "Enable Midi learn" button for knobs and buttons but there's something interesting. If you disable saveInPreset this also prevents MIDI learn, which seems strange. I can think of reasons why you'd want saveInPreset to be enabled but MIDI learn to be disabled (my use case is I'm rolling my own MIDI learn system as I only want specific components to be learnable).

What I propose is removing the link between saveInPreset and MIDI learning completely and instead having a separate Enable MIDI learn button. Any reasons against this? @Christoph-Hart ?

[Casey Kolb]

I think MIDI Learn has to be paired with saveInPreset because the Midi assignments are per preset, not global. I actually learned this from you @d-healey haha. Maybe that doesn't matter though?

[d.healey]

@Lunacy-Audio But what if you want to save a control's value is a preset but you don't want it to have MIDI learn, or you want it to have MIDI learn but you don't want the CC assignment saved in the preset.

[Casey Kolb]

@d-healey Would definitely love that flexibility! This might have been an arbitrary decision, but perhaps there's some deeper implication in HISE I'm unaware of that makes them inextricable.

It scares me that even comboboxes use Midi Learn, meaning you could assign your mod wheel to a list of convolution impulses responses or a sample map selector. Seems super dangerous if abused

[d.healey]

@Lunacy-Audio I disabled the midi learn <> saveInPreset link, and added a separate enable midi learn property and it "seems" to be working fine. I can choose which things I want to save in preset and which things I want to MIDI learn and they are unrelated. I need @Christoph-Hart to chime in and let me know if I'm doing something stupid before I commit to this.

[ustk]

@d-healey Cool ;) so if the link is removed, it would be good to have a property saveMidiLearnInPreset right?

[d.healey]

@ustk If you enable saveInPreset and you enable MIDI learn then it will save the MIDI learn in preset anyway, no need for an extra option.

Currently when you click the saveInPreset button it triggers this function s->setCanBeMidiLearned(newValue); which makes no sense to me.

[ustk]

@d-healey Sounds like the soil was ready to seed the midiLearn system but it hasn't been done...
Ok for the saveInPreset link ;) Have you had the green light for a pull request?

[d.healey]

@ustk Waiting for our benevolent leader to confirm that this is not a terrible idea before I do it.

[d.healey]

The deed is done:

It's available in my fork - https://github.com/davidhealey/HISE/tree/scriptnode

I've also made a pull request so will be in the main repo soon I expect @Christoph-Hart.

[Natan]

@d-healey Good Job Sir
Can You Implement This For Fx Plugins, It's Only Available In Instruments As Far As I Know!!!

[d.healey]

@Natan Nope, I'm crap at C++, I just hack at it.

[Casey Kolb]

@d-healey Any issues with this yet? I'm tempted to add it to my build too.

[d.healey]

@Lunacy-Audio Nope seems fine, I got the blessing from Christoph in a pm.

[Casey Kolb]

Woot! Awesome, great to know.

[Tania Ghosh]

@d-healey I am getting this error.. Unable to Compile.

[Natan]

In Case You're Doing FX Plugin, This Learn Midi Does No Work In FX!!!

[ustk]

@Natan Not sure it works with midi learn but have you enabled the midi input for FX in the projucer and in the preferences? (dunno if both are necessary though…)

[Natan]

@ustk I Mean Right Clicking Over The Parameters And Assign To Midi Controllers Knob, That Feature Not Works With FX Plugins, Or Do I Need To Change Someting In Projucer?

Edit: I Never Changed Anything Regarding Midi And Midi Commands No Idea

[d.healey]

@Tania-Ghosh Nothing to do with the new changes. Are you compiling plugin or standalone?