Collaborative project!

[d.healey]

I've uploaded my code cleanup branch. So far I've just done the leakage script. Let me know if I made a mistake.

[ustk]

@hisefilo That's strange because I put click noise down last night
They are a lot quieter here... Are you sure you pulled the last commit?

[ustk]

@d-healey Leakage seems to work fine, and the project is way quicker to load

[lalalandsynth]

I havent had time to do anything today !
Just wanted to pop in and ask if the note burst issue is gone ?

[hisefilo]

@lalalandsynth never happened at my end so can't tell. Can you try the last commit? no rush

[d.healey]

I've pushed the cleanup for ScriptProcessorMain.js. This one was more complicated so please test.

[hisefilo]

@d-healey I'm away from my keys. will test itb later :)

[d.healey]

@hisefilo Cool, if everything turns out to be ok I'll merge it into the master branch

[hisefilo]

@d-healey if console doesn't claim, should be fine I guess. :)

[d.healey]

@hisefilo The console is fine but I might have messed up some of the pitch/gain/decay values or the interaction between the controls and the modulators - I don't think I have but it's nice to have a second opinion.

[hisefilo]

@d-healey okodoki will tell u later

[hisefilo]

@d-healey Well!! As far as I can see sounds identical. And loops seems fine, and arrays. Didn't check every single value.
Let's move on. Didnt push anything so you can easily merge both.

@ustk * [new branch] Greg's -> origin/Greg's is deprecated right?

[hisefilo]

@d-healey just a question. Loops at runtime leads to glitches (I remember that on some attempt I did). Don't know if this will do the same

[d.healey]

@hisefilo All the loops are in deferred callbacks so shouldn't cause any issues.

[ustk]

@hisefilo Nope Greg's branch is from today for the preset browser look and feel, I'm just waiting you guys to sort the script cleaning before I merge ;)

[hisefilo]

@ustk ohhh nice :) will require a custom Hise compilation??? at my end?

[ustk]

@hisefilo Humm... How old is your version?
The implementation of the LAF is from October, so chances are big you're good with your version
And no, no need to set any flags

[ustk]

@hisefilo Have you modified the key range?

If it's done so we can tick that and the todo list seems to be empty
Though there's still need to add Lalaland logo

[hisefilo]

@ustk 30Jan2020 :)

[hisefilo]

I've just discovered a HUGE sound and playability thing to be improved. Main3 module is doing a weird click due phase shift I did. I will fix that after both merges :)