Collaborative project!
-
I'm doing some code cleanup at the moment.
One thing I notice, these are both the same component but in two different variables.
var LeakageC0tablePitch1 = Synth.getTableProcessor("NotenumberPitchLeakage1");
var LeakageC5tablePitch1 = Synth.getTableProcessor("NotenumberPitchLeakage1");
-
Could I get permission for the github repo? I'll need you guys to test that I haven't screwed anything as I clean up the code. I'll keep it in a separate branch so it won't mess anything up permanently.
-
@d-healey sure. give me some minutes and I'll be in my computer.
-
@d-healey there you are :)
-
I'm confused, where are the widgets with names like this:
NotenumberPitchLeakage1
? I don't see them on the interface script or the nodes. -
Oh never mind, I just realised they are modulators.
-
@ustk said in Collaborative project!:
1 - With no chorus, no Leslie, its still stereo (what is the precise stereo issue here?)
2 - Check Keyclick for your taste (I've fine-tuned it, the level knob that has been proposed can be a pro feature)
3 - 100% Gui size feels a bit large on my monitor. 1920 x1080, definite switch to 75% for me. ?
4 - Add logos (Still need Lalaland)
5 - Leslie needs a full range IR of some sort for its saturation. The Ideal would be to have both IRs low & high from a real Leslie5. I have access to a leslie , not entirely sure how I would impulse it but I can look into it.
6 - Add GNU GPL terms in scripts. @d-healey should they also appear in the exported plugin like in an info panel?
7 - Add PresetBrowser LookAndFeel so the items don't look that tiny... -
@ustk said in Collaborative project!:
Little update
1 - With no chorus, no Leslie, its still stereo (what is the precise stereo issue here?)
2 - Check Keyclick for your taste (I've fine-tuned it, the level knob that has been proposed can be a pro feature)
3 - 100% Gui size feels a bit large on my monitor. 1920 x1080, definite switch to 75% for me. ?
4 - Add logos (Still need Lalaland)
5 - Leslie needs a full range IR of some sort for its saturation. The Ideal would be to have both IRs low & high from a real Leslie
6 - Add GNU GPL terms in scripts. @d-healey should they also appear in the exported plugin like in an info panel?
7 - Add PresetBrowser LookAndFeel so the items don't look that tiny...- I don't see theres an issue. just panning I liked. but we can go full mono if you wish
- Agree. (also on recording I did is very noticeable)
3.The actual UI is 1024x768 on Hise. I don't know why it looks scaled on compiled - @lalalandsynth need help on this?? I can assist you
- Maybe pro-version???
- Sure @d-healey fell free to do it.
- ??? you mean to tweak the C++ code???
-
@d-healey said in Collaborative project!:
The license notice is a copyright notice, so I need to know the name of the copyright holder for the script.
This mean every script should have the name of the guy that did the script??? They are like A LOT of them :0
or theres a general readme with devs involved? -
@hisefilo said in Collaborative project!:
3.The actual UI is 1024x768 on Hise. I don't know why it looks scaled on compiled
I dont mean that it looks scaled , it just looks very large compared to other plugins , I set it to 75% for it to look the proper size. My screen is 1920 x1080 ;)
-
@ustk said in Collaborative project!:
@hisefilo Wow!
I don't know between the other two, but I would say CollaB3 is the last one maybe?
The first one has a hell of a loud keyckick! But the tone's really good, probably the best one here
The second has a loud keyclick too but more filtered so it's nice. Although the stereo/phase is another story... Just to prominent...
The last is balanced in general, but a bit dull, needs more bite/life maybe, hard to say... The stereo seems to narrow as well, the opposite of the second...
Have you used the last commit? Because the Leslie changed quite a bit, there was a big issue in the stereo that I've fixed, but it was late last night so I couldn't try on big monitors...:) cool guys!!!! #1 is CollaB3, #2 Logic, #3 Arturia.
Same drawbar settings. Chorus on.
-
@hisefilo Every file must have a license notice at the top, I'll add them as I go along. If more than one person wrote the script I can put multiple names for the copyright, but this means you'll need the permission of every person to release a proprietary version.
-
@lalalandsynth Ohhh. Well. I guess monitors are getting bigger. Looks like Arturia's 100% on mine. I think we shoudl keep 1024 since will fit iPad perfectly
-
@hisefilo Double Wow then!
To me, the best tone in the test!
But again, the keyclick was very loud, which makes me wonder if you used the last commit because the Leslie changed a lot -
@d-healey said in Collaborative project!:
@hisefilo Every file must have a license notice at the top, I'll add them as I go along. If more than one person wrote the script I can put multiple names for the copyright, but this means you'll need the permission of every person to release a proprietary version.
Got it. Then let's do that. I will be on the Main timbre and Leakage scripts only. The rest are mainly copy pasted from you @d-healey and @ustk and interfase @lalalandsynth
Is this ok? this is how it should be?
-
@ustk nope. was made on MY last commit. Last night before sleep :) I'm now pulling the last commit
-
@hisefilo So if you keep the same test, it should be even better ;)
-
@hisefilo No problem. I'll need everyone to give the legal name they want to use in the copyright notice.
-
@d-healey Augusto Filocamo (AKA Filo)
-
@ustk a bit lost about IR.... we will add one??? The one you sent?? and where in the FX chain?? ... I don't have an IR for those preamp or speakers present in Leslies