createPresetBrowserIcons giving a high crash count

[ustk]

Since I'm tinkering with this Hise is crashing 1 time on 2 or 3 at recompile
the origin seems to be createPresetBrowserIcons LAF function

Sometimes from here:

And sometimes from here:

My code:

presetBrowser_LAF.registerFunction("createPresetBrowserIcons", function(id)
{
	if (id == "favorite_on")
		return Paths.heartFullPath;
	else if (id == "favorite_off")
		return Paths.heartPath;
});

[d.healey]

I've been using it for years without any issues, are you sure it's that function causing the issue? If you comment it out does the crash go away?

[ustk]

@d-healey doing this, waiting for a crash to report

[ustk]

@d-healey So not a single crash since I commented out that function...
Any hint @Christoph-Hart ?

[d.healey]

@ustk Are you sure your Paths are correct?

[ustk]

@d-healey Yeah I wondered about that but they are just simple SVGs I export like every other SVGs...
I could give it a go with dummy square one to see if it helps

[d.healey]

@ustk said in createPresetBrowserIcons giving a high crash count:

they are just simple SVGs

Are they from a standard icon set?

[ustk]

@d-healey nope, created with Inkscape

the ones in question are:

const var heart = "596.t0F..d.QRItNCwF..d.QlKtNCwF..VDQlKtNCwF..VDQRItNCMVafflGD0RFsMjXxVxFD0RFsMzJqfAQ1TlbCg5RVPTVcu2PhYBaTPjupJ3P5d.EDEx7HNznNPAQJDAjCI1QZPAQD8.mCwggXPTrCi5Pm8EGDgKvxNjXjPEHDQOA8NDd2YBQVvawCg2clPjE7V7Phg2clPjE7V7PX.FKDwgO8NjXaBCQ9V2rCIVRQSCQPmapCka43Pjlgq4PdEONDoPDPNjXtjONDYqyHNzdOhCQ.8mfCU0p1PDYUt2Ph8xwzPjRrH2P83bLD4RFsMD3W5BQtjQaCIFdtpBQtjQaC0pAnPjL9a2Po+lIDYbM.NjXRcMIDosC2Mz.+HBQtjQaCABZdPjKYz1Pi0FHn4AQLiWdCIlzFHBQd5mdCY3ajPjbIT3PvwnIDQHoJNjXXnDJDALFENTWloBQnRodCA9ktPDy3k2Ph8RiwPD7Um2P+svLDw8m+MzYnOCQLVefCIFTESCQprAgC4Lv0PDoFb3PpTaMDoPDPNjXElZMDA2FYND37FCQJzZoCs6+sPDT175PhwypqPjtmT6PZM.JDw885NTmLZBQLkXuCIVxUTBQwSstCgPTgPzimS6PFVvGDoVltNjXo02FDoV4jNjb6cAQf1dlCcsRWPjBQ.4PhMdHWPTxAe3Ph28EDQ6hDNDUUjAQYiffCIVXinAQea6eCo1laPjibl2PfflGDwLd4MzXsA.fGPDjN58PrA.fGPj0N58PrA.fEQj0N58PrA.fEQDjN58PiUF";
const var heartPath = Content.createPath();
heartPath.loadFromData(heart);

const var heartFull = "336.t0F..d.QRItNCwF..d.QlKtNCwF..VDQlKtNCwF..VDQRItNCMVafflGD0RFsMjXxVxFD0RFsMzJqfAQ1TlbCg5RVPTVcu2PhYBaTPjupJ3P5d.EDEx7HNznNPAQJDAjCI1QZPAQD8.mCwggXPTrCi5Pm8EGDgKvxNjXjPEHDQOA8NDd2YBQVvawCg2clPjE7V7Phg2clPjE7V7PX.FKDwgO8NjXaBCQ9V2rCIVRQSCQPmapCka43Pjlgq4PdEONDoPDPNjXtjONDYqyHNzdOhCQ.8mfCU0p1PDYUt2Ph8xwzPjRrH2P83bLD4RFsMD3W5BQtjQaCIFdtpBQtjQaC0pAnPjL9a2Po+lIDYbM.NjXScMIDosC2Mz.+HBQsjQaCABZdPTKYz1Pi0F..d.QP5n2CwF..d.QV6n2CwF..VDQV6n2CwF..VDQP5n2CMVY";
const var heartFullPath = Content.createPath();
heartFullPath.loadFromData(heartFull);

[d.healey]

@ustk Looks fine to me

[ustk]

@Christoph-Hart Coming back after checking the stability on a longer period, and I can confirm that I narrowed it down to this.

As soon as I uncomment this:

const var dummyPath1 = Content.createPath();
dummyPath1.startNewSubPath(0,0);
dummyPath1.startNewSubPath(1,1);
dummyPath1.addRectangle([0.2,0.2,0.6,0.6]);

const var dummyPath2 = Content.createPath();
dummyPath2.startNewSubPath(0,0);
dummyPath2.startNewSubPath(1,1);
dummyPath2.addEllipse([0.2,0.2,0.6,0.6]);

presetBrowser_LAF.registerFunction("createPresetBrowserIcons", function(id)
{
	if (id == "favorite_on")
		return dummyPath1;
	else if (id == "favorite_off")
		return dummyPath2;
});

Hise crashes very often at compile

Git issue:
https://github.com/christophhart/HISE/issues/686

[d.healey]

@ustk I'm trying your code and hammering compile but it's not crashing. Do you have a snippet that crashes reliably?

[ustk]

@d-healey Hmmm... That's weird... I'll try to put together a snippet if I can make it crashing. But reliably is the difficult part to get...

The stack trace in my first post might help @Christoph-Hart, I hope

[ulrik]

@ustk it's working here as well, either the dummyPath or heartPath

[ustk]

@ulrik Hmmm I wonder what could cause mine to crash... I'll try to update Hise as I am on a not recent commit, but I doubt it is the cause...