[bug] Pan knob displayed value is wrong

[David Healey]

Not sure when this got introduced but if you set a knob/slider to pan mode the displayed range is -10000 to 10000.

HiseSnippet 797.3ocsU0saSCCE1dadvJ+H.wCPtbfPn10s1JwEL1ePErQEYffqPt1mPspicTryXEDua6Qh2.33jt0L1zFTIxEQ47mOe9bNemLH2J.mylSnMNbRFPn2lEOw3Gs8HtxP5uCgdW19bmGxipTs0jLtyARBkt3KCJnqrDo74mOeKtlaDvLUDxGrJA7FUpxOS6fMesRq2iKgCUo07d8M6KrlssZaAhmEYMIYbwX9WfC3A2VfQdE2MhPeLKoS602nmXMnc21qAcG1sWugh1M2niTB704caIEcFBcQPt7tRk2lG64dvgG5VV4j3Q1uZpRvGTN0PMDDZQhwLWolr8HkVN3zhiiPnKMXVoZwpR0CY6qjpyzOqjcuRCQyhndQitvUAoV+CPhVCRKUAo6yhE4pL+LKA7bKVeC1AS3XuoNTp7kPOgssEcv3eZJeLrWNJbV.q1oYymDgudzyRJLBuxZhrlCrd3slUeTiu2XkF+nQzeZJI4RsERStUqg7K0bXbH+pBbUSQ5PH+IQGw0EvYNhW+yWSW9uqlJpt00bzZ5aT92lASk2ypkgZU36K1AHSKagdwTDht5K6D2cZmHVqjPNQgGxMXu1XG1hTB9ZjjMIuu+NbO+ziAOQLKYPtWEtLzcfiPRTUCdE1Nfar2lU5aZl0DxO8NWaROlPYzdTBYR3ibLsN+jPIY4RGHoJoTCCrNUnjWmBij+rX02f5L8z5D+OcRJ+3Zha5JRRTGGpZugjnzoNOBp9oHSlPe.68NHRBI7BsOxMFOHsxLFjGZKo3oVI5EiMfavMEWX.GoVVYgl6OOeKrIZpg.5qOjGljM3sZRc7+OPBadkjv+VHde1.kWL5xw3BWBFwgg+GXb5pq6v1MIAD9Y.bI1debd2ScMo+c1Bux7k843XPXL7fhzXbEu.vraLf1ElHWHPmpjaFjCUfXvHKE9E9L0XqfLcpwVmZjjxE41OKpHggki2rTChIS4OOVA+KFJGcQ1WXxW8Yg37G0EBbs4Mv1yafqOuAtw7FXm4Mvtyaf8t9.C+J8EEdaZEsgP1evtkaKozcMbbBrbZk7aHVKfQI

[David Healey]

I've fixed this now but I haven't pushed it... yet.

I've never liked that when the knob is at 0 it says 0L instead of just 0. So in my fix I've changed that, but what does everyone else think?

The other thing I'm thinking is when it's less than 0 it is shown as a negative value, which from our point of view makes sense, but from a user's point of view wouldn't it be better to display it as a positive L value instead?

[aaronventure]

@d-healey 100L to 100R. C in the middle.

[David Healey]

@aaronventure C in the middle, nice idea.

[David Healey]

Done - https://github.com/christophhart/HISE/pull/589

[clevername27]

@d-healey Thank you for your code contribution. I seem to be misunderstanding—when I assign a slider directly:

• The Minimum value is 0.0 ; the Maximum is 1.0 ; this would indicate that 0.5 is the Centre.
• The Centre and Default values are -1.0, which isn't between the Minimum and Maximum.

Thanks as always.

[David Healey]

@clevername27 change the mode to pan

[clevername27]

@d-healey Thank you, Dave. In my implementation, I'm changing the values via scripting—assigning a Slider to a Parameter was just a test. If I'm scripting, should my values be -100 to 100, which 0 as centre? Thanks again.

[David Healey]

@clevername27 said in [bug] Pan knob displayed value is wrong:

If I'm scripting, should my values be -100 to 100, which 0 as centre?

Yes, but if you want the panning labels to show up you need to set the mode to pan (which you can also do by scripting).