[bug] Table envelopes always jump after attack completes

[d.healey]

If the last node of the attack envelope is not 1 or 0 then when the end of the table is reached the envelope will jump to 1, even if the note is still held down.

This makes it impossible/useless to set the last node to anything other than 1 or 0.

[d.healey]

Bump this annoying bug is still there.

[ulrik]

@d-healey Bump from me too

[ulrik]

@Christoph-Hart

Take a look at this behavior:

TableEnvelope

[d.healey]

@Christoph-Hart Bump bump

[d.healey]

@Christoph-Hart This is the offending line, any reason we can't remove it?

HISE/hi_core/hi_modules/modulators/mods/TableEnvelope.cpp at develop · christophhart/HISE

The open source framework for sample based instruments - HISE/hi_core/hi_modules/modulators/mods/TableEnvelope.cpp at develop · christophhart/HISE

GitHub (github.com)

[d.healey]

@Christoph-Hart I've been using HISE with the offending line removed for a few days now and not noticed any negatives, can we get this merged if I make a pull request?

[d.healey]

Come on Christoph, do the merge!!!

Prevent table envelope jumping to 1 after sustain phase by davidhealey · Pull Request #492 · christophhart/HISE

Fixes #471

GitHub (github.com)