Collaborative project!

[ustk]

@hisefilo Wow!
I don't know between the other two, but I would say CollaB3 is the last one maybe?

The first one has a hell of a loud keyckick! But the tone's really good, probably the best one here
The second has a loud keyclick too but more filtered so it's nice. Although the stereo/phase is another story... Just to prominent...
The last is balanced in general, but a bit dull, needs more bite/life maybe, hard to say... The stereo seems to narrow as well, the opposite of the second...

Have you used the last commit? Because the Leslie changed quite a bit, there was a big issue in the stereo that I've fixed, but it was late last night so I couldn't try on big monitors...

[ustk]

Little update

1 - With no chorus, no Leslie, its still stereo (what is stereo here?)

2 - Check Keyclick for your taste (I've fine-tuned it, the level knob that has been proposed can be a pro feature)

3 - 100% Gui size feels a bit large on my monitor. 1920 x1080, definite switch to 75% for me. ?

4 - Add logos (Still need Lalaland)

5 - Leslie needs a full range IR of some sort for its saturation. The Ideal would be to have both IRs low & high from a real Leslie

6 - Add GNU GPL terms in scripts. @d-healey should they also appear in the exported plugin like in an info panel?

[d.healey]

@ustk No need for that but the license should be displayed to the user in the installer. Have license headers been added to the script files? If not I can do it.

[ustk]

@d-healey Yes, I forgot the installer needs it too...
Nope, it's still in the todo list, so you're welcome to do it! Thanks!

I imagine no one is working on it at the moment so you can safely push...

Also, what's your opinion about the sound?

[d.healey]

@ustk I haven't checked it for a couple of days but it sounded good to me last time I tried it.

The license notice is a copyright notice, so I need to know the name of the copyright holder for the script. This will also be important if you plan to release a proprietary version later as only the copyright holder will be able to give permission.

[ustk]

@d-healey Very true! I mentioned earlier that we need to find a name that can be used for future projects as well...
You may prepare the license so we just have to replace with the holder name once we solved that question

[ustk]

@d-healey Also I used the svg for your logo so if you want to change the colour, go ahead ;)
Mine is temporary I think...

[ustk]

Little update

1 - With no chorus, no Leslie, its still stereo (what is the precise stereo issue here?)

2 - Check Keyclick for your taste (I've fine-tuned it, the level knob that has been proposed can be a pro feature)

3 - 100% Gui size feels a bit large on my monitor. 1920 x1080, definite switch to 75% for me. ?

4 - Add logos (Still need Lalaland)

5 - Leslie needs a full range IR of some sort for its saturation. The Ideal would be to have both IRs low & high from a real Leslie

6 - Add GNU GPL terms in scripts. @d-healey should they also appear in the exported plugin like in an info panel?

7 - Add PresetBrowser LookAndFeel so the items don't look that tiny...

[d.healey]

What is the difference between all of these sets of scripts? A lot of the folders seem to contain the same files.

[ustk]

@d-healey Definitely, the project has been poorly maintained by us...
But if you pull the last version they should disappear, right?
Otherwise, the only one we're using now is "CollaB3", we have deleted the rest

[d.healey]

I've just pulled the latest (updated 1 hour ago) I still see all of them. I'll just work on the collab3 one though.

[ustk]

@d-healey Strange, when Filo pushed yesterday, I've pulled and all the other versions were gone...

[d.healey]

I'm removed them from my copy now, hopefully this will remove them from github when I push

[ustk]

@d-healey Time will tell

[hisefilo]

@ustk @d-healey morning guys. yes. See "cleaning" commit. I renamed the working version to CollaB3 so we didn't get confused. But I think I ended generating confusion

[hisefilo]

if you want to grab older versions just checkout to commit before cleaning

[d.healey]

I'm doing some code cleanup at the moment.

One thing I notice, these are both the same component but in two different variables.

var LeakageC0tablePitch1 = Synth.getTableProcessor("NotenumberPitchLeakage1");
var LeakageC5tablePitch1 = Synth.getTableProcessor("NotenumberPitchLeakage1");

[d.healey]

Could I get permission for the github repo? I'll need you guys to test that I haven't screwed anything as I clean up the code. I'll keep it in a separate branch so it won't mess anything up permanently.

[hisefilo]

@d-healey sure. give me some minutes and I'll be in my computer.

[hisefilo]

@d-healey there you are :)