Collaborative project!

[hisefilo]

@d-healey if console doesn't claim, should be fine I guess. :)

[d.healey]

@hisefilo The console is fine but I might have messed up some of the pitch/gain/decay values or the interaction between the controls and the modulators - I don't think I have but it's nice to have a second opinion.

[hisefilo]

@d-healey okodoki will tell u later

[hisefilo]

@d-healey Well!! As far as I can see sounds identical. And loops seems fine, and arrays. Didn't check every single value.
Let's move on. Didnt push anything so you can easily merge both.

@ustk * [new branch] Greg's -> origin/Greg's is deprecated right?

[hisefilo]

@d-healey just a question. Loops at runtime leads to glitches (I remember that on some attempt I did). Don't know if this will do the same

[d.healey]

@hisefilo All the loops are in deferred callbacks so shouldn't cause any issues.

[ustk]

@hisefilo Nope Greg's branch is from today for the preset browser look and feel, I'm just waiting you guys to sort the script cleaning before I merge ;)

[hisefilo]

@ustk ohhh nice :) will require a custom Hise compilation??? at my end?

[ustk]

@hisefilo Humm... How old is your version?
The implementation of the LAF is from October, so chances are big you're good with your version
And no, no need to set any flags

[ustk]

@hisefilo Have you modified the key range?

If it's done so we can tick that and the todo list seems to be empty
Though there's still need to add Lalaland logo

[hisefilo]

@ustk 30Jan2020 :)

[hisefilo]

I've just discovered a HUGE sound and playability thing to be improved. Main3 module is doing a weird click due phase shift I did. I will fix that after both merges :)

[ustk]

@hisefilo oh... something that is present in the actual master branch?

[hisefilo]

@ustk yes!

[hisefilo]

@ustk it's a super easy fix. don't worry. will do later. saving _local. as reference

[ustk]

@hisefilo sure my man

[d.healey]

I've added the copyright and license notice to each script file. I put both Filo and Ustk as copyright holders on all files. I added myself to the two I re-wrote during the code cleanup yesterday.

I've also added a full license file to the repo, this file is called COPYING which is the standard GNU naming convention. This file should be displayed to the user in the installer as the license they have to agree to before installing the plugin.

All my changes have now been merged and pushed to github.

[ustk]

@d-healey Good job Dave! But I shouldn't appear on the script license, except for interface script. I did the DSPs but there nothing in there to add license anyway...

Pulling and testing!

[d.healey]

@ustk Ok, I'll update it now.

[ustk]

@d-healey Oups, I just merged my branch at the same time, I hope I haven't made any mistake!
Jus added look and feel and change editable labels to false...