Simple Gain - Width Modulation not working

[alobassmann]

Hi! I am trying to assign an LFO to the width parameter of the Simple Gain and the modulation seems to not be doing anything to the parameter at all:
It works fine if you manually adjust the width value, but doesn't like being told what to do by the LFO it seems

HiseSnippet 1115.3oc6Y0saiSDEdbRlklxOpEVj3ReAWzJVsJoao.hKZ1lephHo0porKHPZYV6iSFU6YLiGWHBwyF7HvixJdAfYrcbrayljFBksn5KrxbNyY72b9elXI31PXHWfLpd93..Y7N3AiYxQMGQnLT2VHiswOm5HG8zHI2mHobF5nwAjvPvAYXT9X8zLpVAE+7pCOh3QX1vTRHzy3TanG0mJmR0pwWQ875Pbfyo94l89M5ZyYM4d7HEjJiqgBH1WPFBmPzSqDFY7f1NTIWLPRjPHxnxQbmwCFw+IVx7eFMj9ROPOnNZfZgRH2g64nQrlJp4Hpmi0jsdHRsnVSUDkSTDOD2m5PynOUgrULCyoRjWeXTpH7JW.d0ecvaFPxHGjvIPZa7.aAMPNkiFOuMtKSBBWhRsmGJmD4Ovi5.BKkJTAErggRCmrBHieG2jqDiIerO4BniPMHaY14fZ0djo50teoaDyVazM4rS3R3T1N6t4urY0M+0MMuJKW2YxS+YDbOOPLS1Z6uXdBtCKx+kf3QlWR7hfrIpr7E0zOX4zz1I65bSjy5xnxSCfzwy2UAkp1T+5q61hHIZSUJM07B.gjpgiQK3RkeehgqJtEDdgjGn77mZUqjvT4Owch7HxhNY5HqTFWMnSanXgT437Qd2.OuZy0yaYg31XKpzdzrwXoYfQkl5eCLlFu9t31ttfsbJ.qf67MqZvYskO3birDmT+.O33Ie92KkfolR84j0DgZAdjBJp3TtSI7sMlQd0trKUNaVbOh3pp4xqqjPUVZeA8Vx7eh+ZkkyXrfnykDuuONVkeWBvwtD2t.dgt9akfXLtWmSSSao9kYF9quXP1Q.+XDvryQbiF5FC5lEgr62+gMdN4RvkK7SymlNysZzCFp9P4WvyA+.tpGF67QDC74b4HJaXt1M9AW2+7vdbdPaFQoFbxuHViHg5JZgfrvxnV1y48IgpBkM831WTHdbHiKfjpj4o2LJT05zjMPbSLCjPPbsCiuCev9OV839I52eQS0qmb55YLZ80KRokzK8ChM+Y1Ysiva3wUIHNyI7N.h2BaQdSHS6Y7HoJfpOQJn+rJGftcSUW61fBpLF3E2wYIs+ex3Z5wwAQ.yIdveodRYVOq8TEy5SXhtdU12BeBmFBo4Di+s4w.CDWOcSwhr+w0OZxq9sYczjfk9nIWsLakkK9pXic4l+Bp+tVOWxsrK6+YMyVnbU0IXLowr1pFn7Tcrm0QfKIxSNgZQmo9bFOXDmQKTV4LP47ObHHxi8YtgdpTRxWt3gMNC7.UQloj93F8nLfHT5IXE0E2fiTNO60GgSfqoNB3tSORqgCjr1w6pe3j+2lkduaXV5CuOK88YoecYo269rz2mk99rzKQV5aiugOwVvegcxE2p8k2HlhZeyhu+9p395wl0QwWladaruJq3KrsKtTWSv8VUAexpJ39qpfe5pJ3Aqpfe1pJ3muXA0Esx8W.gP8sZmbCFFYWehQYze2F4ALA 

Just for context, I'm using the pre-compiled version of HISE 4.0.0 (as opposed to building it from the projucer) in case that's any help

Cheers!

[d.healey]

Confirmed

[alobassmann]

I am building a set of slider packs to control different LFOs and I've been making it work by just assigning them via the processorID box. I'm guessing there's a scripting way to do the same? Could that be a work around this issue?

[d.healey]

@alobassmann said in Simple Gain - Width Modulation not working:

I'm guessing there's a scripting way to do the same? Could that be a work around this issue?

I don't see how that will fix this particular issue.

[alobassmann]

@d-healey I was wondering if bypassing the LFO modulator and assigning the slider values directly to the width parameter on the Simple Gain would be any different (can that be done at all?)

[d.healey]

@alobassmann Yeah that would work, but I still think there is a bug with the LFO.

[alobassmann]

I may be in over my head here but scouting through the source code in GitHub it seems like some of the Simple Gain sliders are duplicates? (Width, Gain and Delay are all called "Gain")

hi_core/hi_modules/effects/editors/GainEditor.cpp

//==============================================================================
GainEditor::GainEditor (ProcessorEditor *p)
    : ProcessorEditorBody(p)
{
    //[Constructor_pre] You can add your own custom stuff here..
    //[/Constructor_pre]

    addAndMakeVisible (widthSlider = new HiSlider ("Gain"));
    widthSlider->setRange (-100, 36, 1);
    widthSlider->setSliderStyle (Slider::RotaryHorizontalVerticalDrag);
    widthSlider->setTextBoxStyle (Slider::TextBoxRight, false, 80, 20);
    widthSlider->addListener (this);

    addAndMakeVisible (gainSlider = new HiSlider ("Gain"));
    gainSlider->setRange (-100, 36, 1);
    gainSlider->setSliderStyle (Slider::RotaryHorizontalVerticalDrag);
    gainSlider->setTextBoxStyle (Slider::TextBoxRight, false, 80, 20);
    gainSlider->addListener (this);

    addAndMakeVisible (delaySlider = new HiSlider ("Gain"));
    delaySlider->setRange (-100, 36, 1);
    delaySlider->setSliderStyle (Slider::RotaryHorizontalVerticalDrag);
    delaySlider->setTextBoxStyle (Slider::TextBoxRight, false, 80, 20);
    delaySlider->addListener (this);

    addAndMakeVisible (balanceSlider = new HiSlider ("Balance"));
    balanceSlider->setRange (-100, 36, 1);
    balanceSlider->setSliderStyle (Slider::RotaryHorizontalVerticalDrag);
    balanceSlider->setTextBoxStyle (Slider::TextBoxRight, false, 80, 20);
    balanceSlider->addListener (this);


    //[UserPreSize]
	gainSlider->setup(getProcessor(), GainEffect::Gain, "Gain");
	gainSlider->setMode(HiSlider::Decibel, -100.0, 36.0, 0.0);
    gainSlider->setIsUsingModulatedRing(true);

    delaySlider->setup(getProcessor(), GainEffect::Delay, "Delay");
    delaySlider->setMode(HiSlider::Time, 0, 500, 100);
    delaySlider->setIsUsingModulatedRing(true);

    widthSlider->setup(getProcessor(), GainEffect::Width, "Width");
	widthSlider->setMode(HiSlider::Discrete, 0.0, 200.0, 100.0);
    widthSlider->setIsUsingModulatedRing(true);

	balanceSlider->setup(getProcessor(), GainEffect::Balance, "Balance");
	balanceSlider->setMode(HiSlider::Pan);
	balanceSlider->setIsUsingModulatedRing(true);

[d.healey]

@alobassmann is GainEditor.cpp the Simple Gain effect?