Note release?

yall

hello I did a simple little vst without anything it was just to try to sample a few piano notes. turn goes very well when I play manually but when I put notes on my midi grid in my daw, some notes are played entirely as if the release was set to the bottom. an idea? ps: I put 2 buttons to manage the attack and the release.

yall

@d-healey help please ^^

d.healey

@yall Are you using buttons or knobs for your envelope?

yall

@d-healey nope. I just use gain modulation envelope for attack and release. and then the gain velocity. I had put in + an ahdsr to control the end of my notes

d.healey

@yall

ps: I put 2 buttons to manage the attack and the release.

More detail please.

yall

@d-healey I have 2 buttons connected to gain modulation attack and release. . and just a gain velocity curve. the samples were extracted with samplerobot and recorded in sfz. then in sample map then in ch1. but sometimes certain notes last a long time when I pressed a little time

d.healey

@yall Try using knobs instead of buttons and give them the full range (0-200000) in ms. That way you can have more control over the release time.

yall

@d-healey yes they are well tuned and work perfectly but it's just when I read my midi recording that certain notes are held as if I had left my finger on the key for 20 seconds

d.healey

@yall Sounds like a hanging notes issue. Without seeing some code there is not much I can tell you.

yall

@d-healey

HiseSnippet 4332.3oc6b07iaibkmpaSOVZ73wy.mrSvlcAQiDf1HNsEo9NClsYK0pc2q6tkrjr8L6rCZyVrjZtlhjCIUa2dh20HHAYukiKxMeXAVr21C6gjKAF4uf.DjC4RfygcABBvB+evt0G7ihTTRThc6tE1Q.1rqp36U+duWUuppWUrZZp2EXYoaxjJcmSL.LotJa6SzrOp1QRJZL6rISpqvZnHooKvT8DCIKKfLSpTKeGTooReIF7u2rdUIUIst.+rXXdftRWvtJCTr8yso3cUTU2RRFzQY.0amWbmt5Z0zU0GBQxxrYYLj59Xo9f8kPu1RrLotbcYEacy11R1.KlTWppt7IsOR+IZj2+AJVJGpBPI3YZCYDI6szUkQHFkKSsiTTka5JwVLLoXa5K+KSj+avtmhrhW995gqiKfymBZ8QpkBBukC.OdZ3kkBdQ.oTTP5RDH8Ars6ZpXX6WBBOuK6NZ1.ydRP0NMTHuKyR+p2mslN7MzrWafziAaYBS3QwpExl8Vb4yl8lebF3Onx2xl6XIStpCss00349DNWh6CrqoOvPWClX0UbJeEHc9D0TRCnNdZHEuBtpBWSBSolDBVSjLKLEhJDEQEmBQEihnRSgnRQQT4oPT4nHpxTHpRTDwmcZFprAIC9BGpWU+oi2X48FQXhElrIVHBRxMYRxEAI4mLI4ifjBSljBQPRwISRwHHozjIoTDjTdxjTNBRpLYRpDUWurSouWVRmuLYTzTUz.b8Fp00VQWiSWyocBhZSc0U65R5sfrWcH3lY9pLoILYMKn+L22iT3Gm44eblo3nXMKT9XppIopdHzw9pgqVD5FGzDlNzDlGnILYnIDCnUX5PK27.sBSFZEhAzJNcnkedfVwICshw.ZklNzJLOPqzjgVoX.sxSGZEmGnUdxPqbLfVkoCsRyCzpLYnUIFPiO6zwV44x6Q1o39HabPWL7sUYtP2zbtEGua7wv8Fe14BdSwAGOsGNzuae6tnw94NT+o291Q.XuYFLQDqzi.vO4S3uYlzvLRWWqOjSqopKIeeKfYSS.DUvQlZUuc8Nb7qYfy.MBU5zYR+7LooYh.jIXtLE1HDfMHlvA+4ymbt7YxrI2HrgBK4Q7HNfIe.t.YiOOJDObTHDN7YPw3wfhAY.RyRIIkvRBQTlBiJETVfrhBLkiqFobHMB7eTroRbYSkIxF9rwkOvdTivnzYh3+POg8yxL04JGcOsvcYPc0t8s4rjFXnB3FHYvA6oEwzyolNmjrrat9U3J2hSnvs3xUBwPex26j1XNaBoGuJdDdcxZ0U7JM7JwHvYOIicUf4.Ik7Z9D6Tzp2DqIHPXMr9TwFLvBhl.rXs+AcEsUW4uWakaFsqOWdLQGIdvEaD8.xpAppOG+9ee9u3lerqgxGdi2d3aNnP0951fFZqhq7LOOCW3h50Kxxb3EREGUwn.cXNIBWUa3fCAlzhN5Egq9OXHEXGeHEni3QWR6FpWTWaGME6FF.swEGDFmFaLLotgCpfupMN3CWyI3CjAMXTjYRkl0YDDFLjoC5CSXxutC4tZdLCxv5kLDG91hLy..DhA.l.4ERF4ESF4kRF4kSF4UBS9aVONjmw0zmc9pdO54SH8yhousphLvDS+0XaU+A0aUkaW3icCviG8y90+t0iCORyt4F60bm8uS.xE+iO6+LVjeY11672UO.su9Y23ODyptcm5sp2fK.4u7m+y+8wh7Lrauyc1lq186DR68O+aEiW0uaiGFA4wT4eE181.g+4i52g8tZ5GFrcyqu2u3+Y83S7HMZ9HQl6uylR1Rn.u53DD5Xz.XZqf74lZSvwJcAjvvBs6.qGaqavj5VdSB.xZRk9dNU5NCj5CbDW7eWf4ozh5IzIdhhr8QdYH9OIdDPo+QTAL+DwdJpNQA+uj8qZ1pwea8ZcNXqF6tY8VOu5F0tKbhdZ8QJPO.8tAADdIDN.hrbBZ.8IhT.hWLHf9M+vv.50GKhFxmNR89oEHYXCdps6KjgkuXoRkD3KvbXeZpN1czqTKiz7dfO8TzlA.OiX.sogjIjGTLySfCJVbeUXw5QCozy+Einm4w5XIUiijbHg6m7m+SqOKJcgEYktvbnzERpRWH4J8bKxJ8bygROWRU54RtRO+hrRO+bnzymTkd9jqzKrPpzS63SedZpWHoZ8BIWqWbgVqOOs0KlTsdwoq0yLEsdoKBZ8YSUWXNT0kRpptTxafWdgtAdw4PqWNoZ8xIWqWYgVqWZNz5URpVuRBz5ocVkP1EZ0d4YQs6Kxyjd+iFckQYmthmMFARzG6F+PJr+hcEOl9jSwL55tmV.FgblM02hrva1TeW3eLPBmWF3ehCeMSpsIGwM9LjGYIOEHOxQdjm7n.4QQxiRjGkIOpvLVvxFiXYNFcfXawDv1BikseZRXawwx1uHIrsz3XKmTRXa4ww1W1MIrsxXQau4gsTwVcbv8nDw2w1Mi6wIhuiso6q0FOeupsywsjv2sT0krUz52A5rAy82mkNq.Qf3Mq6WEF1g7M+peTXWXu3dhNg1iDGuLr2Ebxg5RlxT9duJadgx4KUrRtxzttQGyx7EDpTNe4b7AcoinnR9JEKIToP.e6HIEGSwk9hTreUFNtUf02CQfbke.GO+ZEuEJuMUrLTkNoQWaoiA6i2BHXw1lCA3h2U+IPpf4HviSusBIIuPIb5ZCsr0GbGSIiiT5ZQS4lfdRCUs2vv.HYhNTtvB6IoZQJsppT2GCYUKnpUGVR10JVA+qb4rkpjsDo15n2uuJXOc4fDiN.r0NRRCNzABJ37tuE3Aft15lTXwmBXoaoJY219D0PrpYcWq.M3gY21Vxz1uVDbyutlLUcWLyyCzb5CiaH+8aG8hOkdjFiPsiXtyHsitqng6llsiLdjGE7931BbLv7PdzvrvgIsA3Ryv9Pf8tvRTYF.0iLo9lr6qaNPRU4Y.4l.ytPXiFC2ZXudJOE0p46xLPQVVEzT2RAsEg9P40qiZegDEUDC4LwUHi1vAssgRqk+a9Hzn0CrP4RlhPpaNxX10TARZGzFBE0Cp9vCPAFGOHtUWIUvVRHao6Vhzq2+85FpC6qn0zU1HyD3prOrdGNhhkQwZOfsj2aP1kQEqlAIzcyG8sYePL1hEey0qjNKMWvZTZfAzayog05bzv7dXM2YmkwY2q7MKh8Oa6E0RWePanUXg2tzpQi8NK6w3tyfT8XTOKMMuCKdLsEb6x0Xe3Na1Y6jZX9FwYOW8sLbeYxrLoY2RQEBjPlj2kcKSvWNDn08DGyRfbn+jcxKhWFj+9+ZYCLv8ynllkq0ikka6mMN6mw+hnLYJGOH7dJeNZWoT6yqM8FwXev8Ugu15zwjJbwvjdNZ570tyqk6Cm9QPvWQ8xiSlg6ZtdIQeSbg5PdYV7GJW.yzm8JZyDy2QjXVQmtftJGhlt3X7Sl+UmiFEOE27ZStZv.XsqzgdA8D+2zKN8UOfxjXXJRl8af4b1CthtfssWQDmGZkFHEeUcUYF33Q80Ffq+KCm6bO6Pw65E6HBjUrk7VgJPC82xQDAOzx8DJUtP474lMAKvRWOLJA6x34rEgH8ctfJRz6W2i5GsHgltyBjHQuYXuVMJQ5cHyTXARlni82K+xnjoKwtcsEHAhNpiOxNZAZ2EIAJP7NONJAxyu6EGg55SHv6uqWf2CbPsVO3toPEA9Pi1t+Hm.t+FOKasptwqWgs1tMZWm6Ns1X+MyTqw90p2piSp1arai8yPJG4CJSil02m7W3Wfy40yzty82bmFjhc96NaWeiNspmoUi81.9RYxvXIcLXGMxWO.QGEb6ZniTH0d5DPQllkmmub9x7iDkvQroupUD1zYoAU4In0caPQ9FHXlP6fYucUDFtrhAitZox7Uxlsb1nZKMgi64XjmWoEdhZEGAA2ej4Fs5HyMxTWURS9f1ae.eV9Cdr6TihblVia9RzyF7CYch+ZcsiAp5FfPyH7JraXaK08wNSl+xr3KBgYah6vt.iYNhh+Lw3Et.2yC6So8Lr3qcSy1B.mrqE3LS8FXp7LhSXClGouYfs0uD8hNTc5axxtQmNg6YsYDtDGsC5nCOvExSOsyG7tcTfuXd9bkCze78lockgerGs4MC094k+iiHEZA2Ul2mk3kspo9SrfsRC37fOetJkDxUPHfCWrTTpXEAnO2Q2tcxVv7SWhrELnuGl1Pm4jsrhdKGPkT+oFRZVPSs0FVPlLbfVfMq.8J3aRDSOxCVH56CxZjbQe+NDBBVle9M50C8Qn8C33y5Q0FxxQCxVPezCFi.rIrYu8XJaKoi0MgpGzUrBcYNPaGnfKCppaJi2AJeXt+vADcgk2l8PRii6m6FH843OzxrqkKzuaMi4Cy9KH67khk8Fl.IOciSMbqnd3QEAYszeRSIYYXyy3RWafjY2ipJYVUenlLRR+bRA6oa5nOCWheynvk3poGozLOmYqHl+1X2bzw5JIsyhko2h3WTOZeIspu6aeeIid60bc18zkGpJYG7xzAEXDmBPtXouAaP2RMvFk1mP6f9T6F1ItP7CXapX28nnw3RQfQFlyDL5buD8dr060Cz01GfWhcqO8L5RHZ4libuP8grM0UOw3HcMktjHUhAgejnG+0CECieDKoFF9dzl28HAAy66x4dCgS4jV6dcwpJFvoSXlTMO+jE8KEylGeS+vvxcAucLxZbwFieKVGiKGRodwFqWi8dm+.LdcJElwNkveSnS429q6T90cJ+5NkiGfWw6FTDugP2wGbA1gnI0mDNOdo.8gdXvIv8YhQbSKtCbwvl1MQlpv8.W9scOvEgF1nnH.UyWzAI1zewFjWGcNxOmfXK8gn3PrmjsINvMvkq1Ftfjt.mSIH5JyH0RnusbR5rnzHPzFnIiS7+B+4THOJcJmB4cKjVM7W4Nhaaa3hSG.qYmqmDmKiSuqqjSi6IUiXeOo1zDfudTBrbsWIVcHbwBlAy8+PDWUaL.ttz.0kCvaAL.R1AGy+JhsZcGS8gFgo5MqiWcTGSotOFcp4nJngF.ZPsokwZl5VV8fhClWVzE0bnYejtxOG7oMxJXdnXQPYVQVp6aAPMhT551Bv+sw0R1Nj0qtDKIMenzBgRmKT57gRWHT5hgRWxOs2kUC08mawQtPWtR7bFCYC9i0f5Mqpz2qJH4PeO25orw.h5Nx8gRGC5oaNfhSQ3o+xmU2ItWJdc0m7U16BP.FRsznST28nz4F2ZuwgBEMaZTtmtlNYp8A6c.as2uOvjF6QJPNaz.0MkgavwoVm8tJZ.Iyfc5mIcA+LecFGo85ib1WDNjCuDMhxodyr2w8yF3APiTWTsi.72vKImm3vOsPD8l0gdsb7SDd9aAc34bXfBZXNEWR0oRTvVNVK66T2fbdDQrkh8huupyhuQcomo0e+h+7+9+1rDTLtabi+0MFy5uE+iO6Gu9+Ob82A72bkX2wUX5PbzNtH2twtiqach4AdqoRUfMWw0v+58YpeFeM3ebbC81U196gxqBIMpT5zmGd.R7J5dqNx+oXXKdqh6jFBiScv53lyM5EjOB.mIWE5CCfFrdevFT2sYteaMTWUZdecTT29ZaZdBcdh+h+5+q0oC.B9hNCZUAOCP0+Bl6ub8SsHc71dckStIAYZ9b3uItK3seuJKdYPbnUsddA02F1tttrBJaN+Mwe9xdmgpTKoR0LF+y87k.Wc3aETNPpqo9AcI2LdHrdEbNPTp4bH62Ckly69zikM6ZYQG7EkC51EMUpuOOCSzzHLGzjaNnI+bPSg4flhyAMklCZJOQZPqjdig15CH9+gYzrNogUp5dMrVl4+C.p3Qbt

d.healey

I don't see anything there that could cause hanging notes. Which DAW are you using?

Here's another tip:

	if(value==1)
	{
		Engine.loadUserPreset("PRESET 1.preset");
		
	}
	
	if(value==2)
		{
			Engine.loadUserPreset("PRESET 2.preset");
		}
	
    if(value==3)
		{
		Engine.loadUserPreset("PRESET 3.preset");
		}
	
	if(value==4)
			{
			Engine.loadUserPreset("PRESET 4.preset");
			}
if(value==5)
		{
		Engine.loadUserPreset("PRESET 5.preset");
		}
if(value==6)
		{
		Engine.loadUserPreset("PRESET 6.preset");
		}		
		if(value==7)
				{
				Engine.loadUserPreset("PRESET 7.preset");
				}	
if(value==8)
			{
			Engine.loadUserPreset("PRESET 8.preset");
			}			
if(value==9)
			{
			Engine.loadUserPreset("PRESET 9.preset");
			}			
if(value==10)
			{
			Engine.loadUserPreset("PRESET 10.preset");
			}

Can be replaced with

if (value >= 1)
    Engine.loadUserPreset("PRESET " + value + ".preset");

yall

@d-healey
I am the champion of code that is too long. thank you.
I really don't understand where this problem can come from. I just re-exported my vst without any velocity to see if the problem is not from the

d.healey

@yall Which DAW are you using? Have you tried a different DAW?

yall

@d-healey fl studio and cubase. same problem

d.healey

@yall Can you share some MIDI that causes the issue?

yall

@d-healey
in fact I play anything in recording mode. so I don't use a midi file. I think the problem may come from the basic samples being imported in SFZ but I don't understand why. they are well converted and the sample maps too and the hr1 installation is going well

Adam_G

hey @yall did you ever figure this one out? im running into the same issue with a project im working on..

d.healey

@Adam_G Can you reproduce the problem with a sine-wave generator or does it only happen with a sampler?

Adam_G

@d-healey said in Note release?:

@Adam_G Can you reproduce the problem with a sine-wave generator or does it only happen with a sampler?

actually this particular project has both a sampler and a sine wave generator playing together though its the sampler note thats not being released it sounds like. could that be whats causing it? they sound so good together.. lol

d.healey

@Adam_G Make a minimal snippet that demonstrates the issue.

Note release?

26

1.8k

10.2k

89.3k