@ulrik said in Changing Sample Start Mod:

But the sample map xml files are also changed when saving the project, if I open the maps in a text editor I can see the changes are made

Aha I misunderstood. So it's autosaving them, hmm that's unexpected.

Yes indeed it is.

@ulrik said in Changing Sample Start Mod:

So if I understand right, it doesn't matter as long as it's referring to the right ch1

Needs testing in a compiled plugin.

Ok I have tested it in a stand alone, and that works fine

@ulrik said in Changing Sample Start Mod:

The user can change all samples in range between 0 - 5000 smpl, that is already fixed

In that case I would just use sample start mod and a constant modulator or set the start offset in the note on callback, rather than changing the sample properties at run time.

Yes I have been thinking in that direction as well, but I also have a script that already make use of the SampleStartMod, so that will add up to the Sample Start setting I guess.
But I think it would be the best way to use Sample Start Mod for this purpose as well

Thank you David for the feedback, it's much appreciated!

But the sample map xml files are also changed when saving the project, if I open the maps in a text editor I can see the changes are made

Aha I misunderstood. So it's autosaving them, hmm that's unexpected.

@ulrik said in Changing Sample Start Mod:

So if I understand right, it doesn't matter as long as it's referring to the right ch1

Needs testing in a compiled plugin.

@ulrik said in Changing Sample Start Mod:

The user can change all samples in range between 0 - 5000 smpl, that is already fixed

In that case I would just use sample start mod and a constant modulator or set the start offset in the note on callback, rather than changing the sample properties at run time.

@ulrik said in Changing Sample Start Mod:

And it seems the "embedded map" is still referring to the right .cr1 file.

Yes

@ulrik said in Changing Sample Start Mod:

Could you explain?

The changes are saved with the project but not with the sample map.

But the sample map xml files are also changed when saving the project, if I open the maps in a text editor I can see the changes are made

But since your use case is for the user to be able to edit the start any way then this doesn't matter because they can't save the sample map once it's embedded.

That is great to hear.
But while working with the project the sample maps are changed and it leads to the message that it's bad practice to load embedded samplemaps.
So if I understand right, it doesn't matter as long as it's referring to the right ch1

@ulrik said in Changing Sample Start Mod:

A feature for the user to adjust the sample start

Do you want them to be able to set the start at any point of the sample? How many samples are we dealing with?

The user can change all samples in range between 0 - 5000 smpl, that is already fixed

And it seems the "embedded map" is still referring to the right .cr1 file.

Yes

@ulrik said in Changing Sample Start Mod:

Could you explain?

The changes are saved with the project but not with the sample map. But since your use case is for the user to be able to edit the start any way then this doesn't matter because they can't save the sample map once it's embedded.

@ulrik said in Changing Sample Start Mod:

A feature for the user to adjust the sample start

Do you want them to be able to set the start at any point of the sample? How many samples are we dealing with?

If you change any sample map property then the sample map has changed, when you save the project it will save this as an embedded sample map unless you save the sample map xml.

And it seems the "embedded map" is still referring to the right .cr1 file.

...unless you save the sample map xml

Could you explain?
It is in fact saving the changes already when saving the project

What's the reason for changing these properties dynamically

A feature for the user to adjust the sample start

Do you have any thoughts about how to do it another way?

as soon as I change the Sample Start, or the Sample Start Mod

If you change any sample map property then the sample map has changed, when you save the project it will save this as an embedded sample map unless you save the sample map xml.

What's the reason for changing these properties dynamically>

Usually the sample start mod is fixed in the sample map and you control the position used with a modulator in the Sample Start chain.

Hi David
Yes I know that, what is your recommendations regarding this?
Because as soon as I change the Sample Start, or the Sample Start Mod and save the project the changes will be applied to the sample map as well.
So when I load the project again I'll get the

Sampler1:! Loading embedded samplemaps is bad practice. Save the samplemap to a file instead.

even though the samples for that map are saved as Monolith.

Do I get that message because the sampler doesn't recognize which monolith it should use for that map or...?

Even if I load that sample map after changing the Sample Start or Sample Start Mod, it will still load the right .ch1 file so why is it compiling about loading embedded samplemaps?
Sorry if I don't understand the logic behind this